Open Stack

On Thu, 2013-01-03 at 17:17 +0000, Mark McLoughlin wrote:
> On Mon, 2012-12-24 at 09:47 -0800, James E. Blair wrote:
> 
> > I looked into this, and I believe the problem is that in this file:
> > 
> > https://github.com/openstack/keystone/blob/stable/folsom/tests/test_keystoneclient.py
> > 
> > It checks out python-keystoneclient git repos from gerrit into the
> > keystone workspace and attempts tests with different branches.  The
> > problem is that different versions of python-keystoneclient will have
> > different dependencies, and since they are not being installed properly
> > with setuptools, those dependencies will not be in the environment.  In
> > this case, 'requests', which is a current dependency of keystoneclient,
> > is not available.
> > 
> > In general, I don't think _inside_ the test cases is a good place to be
> > installing software.  This might be more appropriate as a set of jenkins
> > jobs and tox configs that install the needed dependencies before running
> > tests.
> 
...
> To fix the stable/folsom issues, how about we say that the stable/folsom
> tests only need to test the 0.2.0 version of keystoneclient, not master?
> 
> That's as simple as this change:
> 
>   @@ -789,7 +789,7 @@ class KeystoneClientTests(object):
>  
>    class KcMasterTestCase(CompatTestCase, KeystoneClientTests):
>        def get_checkout(self):
>   -        return KEYSTONECLIENT_REPO, 'master'
>   +        return KEYSTONECLIENT_REPO, '0.2.0'
>  
>        def test_tenant_add_and_remove_user(self):
>            client = self.get_client(admin=True)

Proposed here: https://review.openstack.org/18898

Cheers,
Mark.