Open Stack

On Wed, Feb 20, 2013 at 9:16 PM, Monty Taylor <mordred at inaugust.com> wrote:

> Hey all!
>
> I'm working through Quantum patches to migrate unittests to testtools as
> step one in getting the testr parallel test running in place.
> Unfortunately for me, you are all WAY to productive and write more tests
> than I can keep up with the conversion of. :)
>

Hooray!


>
> To that end, I'd like to ask if folks could start doing the following to
> help:
>
> - If you add new tests and as part of doing that you add a setUp or a
> tearDown method - PLEASE add an upcall. This is going to be enforced by
> testtools soon anyway, so it's good to get in the habit
>
> - If you aren't overriding things in those methods, don't add them. For
> instance:
>
> def tearDown(self):
>     pass
>
>   is a bad idea - just leave it out
>
> (also - thanks for being so great about writing tests - it's an awesome
> problem to have)
>


Got it.  Folks, let's make sure we start enforcing this as part of the
review process.

Dan



>
> Monty
>
> _______________________________________________
> OpenStack-dev mailing list
> OpenStack-dev at lists.openstack.org
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>



-- 
~~~~~~~~~~~~~~~~~~~~~~~~~~~
Dan Wendlandt
Nicira, Inc: www.nicira.com
twitter: danwendlandt
~~~~~~~~~~~~~~~~~~~~~~~~~~~
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstack.org/pipermail/openstack-dev/attachments/20130221/451fe617/attachment.html>