Open Stack

On Thu, Feb 21, 2013 at 10:59 AM, Eric Windisch <eric at cloudscaling.com>wrote:

> Yes, I'm okay with the duplicate message checking being able to affect
> ZMQ, although I still suggest it may be of value to have this be a
> toggle as the value is particularly situational. (Generally message
> signing *or* mirrored queues - neither are default scenarios)
>

I'm curious.  How do you propose to implement a toggle (a check) say for
AMQP mirroring in common code?  Putting implementation specific checks in
common code is what concerns me.  We either require all implementations to
do duplicate message checking (even future ones) or we move it to
implementation specific code.  That is my opinion.

It seems better for the implementation specific code (e.g. AMQP) to check
whether some common feature like message singing is enabled and not do
duplicate message checking if it were.


> I have nothing against the AMQP-specific patch
> directly, except that I foresee a need to do this in rpc-common for
> Havana, and we'll be making a mess for backwards compatibility.


One of my points about duplicate message checking in general is that it is
backward and forward compatible.  If a unique ID exists in the message then
it is used for duplicate checking.  If a unique ID does not exist, then
duplicate checking simply isn't done.  That doesn't sound messy.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstack.org/pipermail/openstack-dev/attachments/20130221/a760075b/attachment.html>