[openstack-dev] [Horizon] "import only module" message and #noqa
Gabriel pettier
gabriel.pettier at cloudwatt.com
Mon Dec 30 14:43:03 UTC 2013
Hi
Reading horizon's code and recent reviews, i'm under the impression that
it's a common practice to use #noqa to bypass the "import only modules"
qa message, i'm unconvinced of the advantages of this policy (i think
the namespace is often cleaner when one import only the symbols needed
from the modules), so i think this policy could be removed, by adding
"H302" to the list of ignored errors in tox.ini.
This would allow removing a lot of #noqa comments, making for cleaner
code.
If there are significant advantages to this policy, however, it should
be made more consistently applied to fix all these imports.
Regards
--
Gabriel Pettier
Software Engineer at CloudWatt.com
06 85 10 36 34
More information about the OpenStack-dev
mailing list