[openstack-dev] [Nova] All I want for Christmas is one more +2 ...

Matt Riedemann mriedem at linux.vnet.ibm.com
Mon Dec 23 14:33:27 UTC 2013



On 12/12/2013 8:22 AM, Day, Phil wrote:
> Hi Cores,
>
> The “Stop, Rescue, and Delete should give guest a chance to shutdown”
> change https://review.openstack.org/#/c/35303/ was approved a couple of
> days ago, but failed to merge because the RPC version had moved on.
> Its rebased and sitting there with one +2 and a bunch of +1s  -would be
> really nice if it could land before it needs another rebase please ?
>
> Thanks
>
> Phil
>
>
>
> _______________________________________________
> OpenStack-dev mailing list
> OpenStack-dev at lists.openstack.org
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>

Since this is happening to others that are requesting reviews in the 
mailing list, even on patches with several +1s and a +2, and it's way 
after the fact, I'm going to link this:

http://lists.openstack.org/pipermail/openstack-dev/2013-September/015264.html

Maybe we should update the blurb here also to say 'in IRC' to nix any 
confusion about the mailing list.

https://wiki.openstack.org/wiki/ReviewChecklist#Notes_for_Non-Core_Developers

-- 

Thanks,

Matt Riedemann




More information about the OpenStack-dev mailing list