Open Stack

Ok so this is interesting. I think this new feature will have caused
bugs in anything using this idiom:


def foo(bar=CONF....):

because that is only evaluated at import time - any later reevaluation
of the config settings won't propagate into code. (This is why we
recently avoided that idiom in Ironic, but part of that review was
looking at where else it was used).

So - something for reviewers to watch out for - default parameter
values from config settings in daemons is no longer 'safe' (it never
really was, but now it's clearly always unsafe).

-Rob

On 21 December 2013 09:09, Doug Hellmann <doug.hellmann at dreamhost.com> wrote:
>
>
>
> On Fri, Dec 20, 2013 at 11:22 AM, Sean Dague <sean at dague.net> wrote:
>>
>> On 12/20/2013 10:56 AM, Sean Dague wrote:
>> > On 12/20/2013 09:59 AM, Sean Dague wrote:
>> > <snip>
>> >> So as Clint said, SIGHUP is only appropriate to do that *if* the
>> >> process
>> >> is daemonized. If it's in the foreground it's not.
>> >>
>> >> So that logic needs to be better.
>> >
>> > This is basically a blocker for adding any upgrade testing from
>> > something later than havana. Grenade upstream is still functioning
>> > because the service code wasn't merged into nova until after havana was
>> > cut.
>> >
>> > However there is a desire to do more interesting upgrade patterns, and
>> > without the ability to shutdown nova services on master in the gate,
>> > that's going to hit us pretty hard.
>> >
>> > So I'd like to get this fixed soon. As digging us out of this later is
>> > going to be way more expensive.
>>
>> Work around here for review - https://review.openstack.org/#/c/63444/
>
>
> That fix has landed in oslo, and I'm working on a patch to copy it into nova
> now.
>
> Doug
>
>
>>
>>
>>
>>         -Sean
>>
>> --
>> Sean Dague
>> Samsung Research America
>> sean at dague.net / sean.dague at samsung.com
>> http://dague.net
>>
>>
>> _______________________________________________
>> OpenStack-dev mailing list
>> OpenStack-dev at lists.openstack.org
>> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>>
>
>
> _______________________________________________
> OpenStack-dev mailing list
> OpenStack-dev at lists.openstack.org
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>



-- 
Robert Collins <rbtcollins at hp.com>
Distinguished Technologist
HP Converged Cloud