Open Stack

On Tue, Dec 10, 2013 at 06:35:38PM +0900,
Maru Newby <marun at redhat.com> wrote:

> 
> On Dec 10, 2013, at 4:47 PM, Isaku Yamahata <isaku.yamahata at gmail.com> wrote:
> 
> > On Tue, Dec 10, 2013 at 07:28:10PM +1300,
> > Robert Collins <robertc at robertcollins.net> wrote:
> > 
> >> On 10 December 2013 19:16, Isaku Yamahata <isaku.yamahata at gmail.com> wrote:
> >> 
> >>> Answering myself. If connection is closed, it will reconnects automatically
> >>> at rpc layer. See neutron.openstack.common.rpc.impl_{kombu, qpid}.py.
> >>> So notifications during reconnects can be lost if AMQP service is set
> >>> to discard notifications during no subscriber.
> >> 
> >> Which is fine: the agent repulls the full set it's running on that
> >> machine, and life goes on.
> > 
> > On what event?
> > Polling in agent seems effectively disabled by self.needs_resync with
> > the current code.
> 
> If the agent is not connected, it is either down (needs_resync will be set to True on launch) or experiencing a loss of connectivity to the amqp service (needs_resync will have been set to True on error).  The loss of notifications is not a problem in either case.

I agree in launch case.
But suppose only port_xxx_end notifications are sent. No change of network nor
subnet. In that case I don't see code path that sets needs_resync = True
unless dhcp driver fails.
-- 
Isaku Yamahata <isaku.yamahata at gmail.com>