Open Stack

Adrian, 

I had a look a little while ago and I don't *think* it's too bad.
Because it's hooking into sockets and dealing with web requests though
there is a lot of messing with what is unicode vs ascii and the py2 vs
py3 differences. 

I'm sure it's doable, but i hate those kind of problems :) 

>From a dev point of view it's a good library and i recommend the various
clients look at it rather than our home grown client stubbing. 

Internally he's done some interesting things like maintaining his own
compat rather than just using six, and it's tested using an unknown
framework that does a hook into PyObject * (CPython) which is just
wrong. But we don't need to fix the whole project, just py33.

Jamie


On Wed, 2013-12-04 at 23:44 +0000, Adrian Otto wrote:
> Jamie,
> 
> Thanks for the guidance here. I am checking to see if any of our developers might take an interest in helping with the upstream work. At the very least, it might be nice to have some understanding of how much work there is to be done in HTTPretty.
> 
> Cheers,
> 
> Adrian
> 
> On Dec 4, 2013, at 3:29 PM, Jamie Lennox <jamielennox at redhat.com>
>  wrote:
> 
> > Adrian, 
> > 
> > The main blocker for the time being with keystoneclient and py3 is our
> > use of a library called HTTPretty in our testing - on which there is a
> > very recent thread. There is upstream work to make this py3 compatible
> > but i'm not sure how quickly it's moving. 
> > 
> > Any code in keystoneclient itself that is not py33 compatible should be
> > considered a bug - but obviously due to the missed testing we don't pick
> > this up very often.
> > 
> > There is no timeline at the moment, however anyone with py33 experience
> > looking to make this happen faster could contribute to this branch on
> > github: https://github.com/gabrielfalcao/HTTPretty/pull/124 and help
> > upstream. Once there is a py33 release available keystoneclient will not
> > be far behind. 
> > 
> > Jamie 
> > 
> > On Wed, 2013-12-04 at 20:59 +0000, Adrian Otto wrote:
> >> Dolph, 
> >> 
> >> 
> >> Is anyone already focusing on py33 compatibility for
> >> python-keystoneclient? Has that effort been scoped? I'd like to judge
> >> whether it's reasonable to expect us to patch it up to be compatible
> >> in the near term, or relax our expectations. For Solum, we are trying
> >> to make all our code py33 compatible from the start, so we take it
> >> seriously when the py33 gate fails. Please advise.
> >> 
> >> 
> >> Thanks,
> >> 
> >> 
> >> Adrian
> >> 
> >> On Dec 4, 2013, at 12:24 PM, Dolph Mathews <dolph.mathews at gmail.com>
> >> wrote:
> >> 
> >>> 
> >>> On Wed, Dec 4, 2013 at 1:26 PM, Georgy Okrokvertskhov
> >>> <gokrokvertskhov at mirantis.com> wrote:
> >>>        Hi, 
> >>> 
> >>> 
> >>>        I have failed tests in gate-solum-python33 because
> >>>        kesytoneclient fails to import xmlrpclib. 
> >>>        The exact error is:
> >>>        "File
> >>>        "/home/jenkins/workspace/gate-solum-python33/.tox/py33/lib/python3.3/site-packages/keystoneclient/openstack/common/jsonutils.py", line 42, in <module>
> >>>        2013-11-28 18:27:12.655 |     import xmlrpclib
> >>>        2013-11-28 18:27:12.655 | ImportError: No module named
> >>>        'xmlrpclib
> >>>        "
> >>>        This issue appeared because of xmlrpclib was renamed in
> >>>        python33.
> >>>        Is there any plan to release a new version
> >>>        of keystoneclient with the fix for that issue? As I see it
> >>>        is fixed in master.
> >>> 
> >>> 
> >>>        If there is no new release for keystoneclient can you
> >>>        recommend any workaround for this issue?
> >>> 
> >>> 
> >>> 
> >>> 
> >>> I'd be happy to make a release keystoneclient, but I don't believe
> >>> that's the only issue with python 3 at the moment (at least on the
> >>> CLI?). For example:
> >>> 
> >>> 
> >>>  https://bugs.launchpad.net/python-keystoneclient/+bug/1249165
> >>> 
> >>> 
> >>> In the current master, the above issue is only reproducible after
> >>> syncing oslo (otherwise it fails on yet another python 3
> >>> incompatibility).
> >>> 
> >>> 
> >>>        Thanks
> >>>        Georgy
> >>> 
> >>>        _______________________________________________
> >>>        OpenStack-dev mailing list
> >>>        OpenStack-dev at lists.openstack.org
> >>>        http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
> >>> 
> >>> 
> >>> 
> >>> 
> >>> 
> >>> _______________________________________________
> >>> OpenStack-dev mailing list
> >>> OpenStack-dev at lists.openstack.org
> >>> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
> >> 
> >> 
> >> 
> > 
> > 
> > _______________________________________________
> > OpenStack-dev mailing list
> > OpenStack-dev at lists.openstack.org
> > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
> 
> 
> _______________________________________________
> OpenStack-dev mailing list
> OpenStack-dev at lists.openstack.org
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev