Open Stack

On 08/29/2013 04:25 AM, Robert Collins wrote:
> On 29 August 2013 17:33, Christopher Yeoh <cbkyeoh at gmail.com> wrote:
>> On Wed, 28 Aug 2013 15:56:33 +0000
>> Joshua Harlow <harlowja at yahoo-inc.com> wrote:
>>
>>> Shrinking that rotation granularity would be reasonable to. Rotate
>>> once every 2 weeks or some other time period still seems useful to me.
>>>
>>
>> I wonder if the quality of reviewing would drop if someone was doing it
>> all day long though. IIRC the link that Robert pointed to in another
>> thread seemed to indicate that the ability for someone to pick up bugs
>> reduces significantly if they are doing code reviews continuously.
> 
> Right, it did - 30m or something from memory; so we have an upper
> bound on reviews in a day - review, rest (e.g. hack), review, ...

And I have certainly felt this in my experience lately.  I've been
wanting to help the review load so much that I've spent _a lot_ of time
on reviews.  I noticed that the quality of my reviews dropped as I did
more and more of them.  I need to hack more.  :-)

-- 
Russell Bryant