[openstack-dev] Osl and dangerous code merging

Doug Hellmann doug.hellmann at dreamhost.com
Wed Aug 21 14:58:54 UTC 2013


IIUC, git sub-modules point to a specific revision of the external
repository, right? So would projects still have to explicitly update to
newer versions of the incubator code by changing that sub-module reference?

With the copy process we have now it is possible to update only part of the
incubator code in a project. Is that a feature we would want to retain if
using sub-modules?

Doug


On Tue, Aug 20, 2013 at 7:27 AM, Roman Bogorodskiy <
rbogorodskiy at mirantis.com> wrote:

> FWIW, I've created a sample project using olso as a submodule:
>
> https://github.com/novel/oslo-helloworld
>
> I spotted some minor difficulties:
>
> 1. As olso directory layout is not designed to be used as a submodule, a
> symlink has to be created to place code to the proper location
> 2. sys.path hack has to be applied for proper imports
>
>
> On Thu, Aug 8, 2013 at 2:39 PM, Mark McLoughlin <markmc at redhat.com> wrote:
>
>> What do you mean by "dangerous code merging" in the subject? The body of
>> your mail doesn't make any reference to whatever "danger" you're seeing.
>>
>> On Thu, 2013-08-08 at 14:16 +0400, Boris Pavlovic wrote:
>> > Hi All,
>> >
>> > Could somebody answer me, why we are merging oslo code in other projects
>> > and don't use
>> > git submodules (http://git-scm.com/book/en/Git-Tools-Submodules)
>>
>> The idea of using submodules has come a few times. I don't have a
>> fundamental objection to it, except any time I've seen submodules used
>> in a project they've been extremely painful for everyone involved.
>>
>> I'd be happy to look at a demo of a submodule based system for projects
>> to use code from oslo-incubator.
>>
>> Mark.
>>
>>
>> _______________________________________________
>> OpenStack-dev mailing list
>> OpenStack-dev at lists.openstack.org
>> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>>
>
>
> _______________________________________________
> OpenStack-dev mailing list
> OpenStack-dev at lists.openstack.org
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstack.org/pipermail/openstack-dev/attachments/20130821/035955d4/attachment.html>


More information about the OpenStack-dev mailing list