I prefer nova/compute/plugins/virt/libvirt, because I think a plugin might not call libvirt or any virt driver. By the way, can nova core or those who are interested in the bp review our patch sets at https://review.openstack.org/#/q/status:open+project:openstack/nova+branch:master+topic:bp/ubs,n,z? Thanks. -- Shane From: Gary Kotton [mailto:gkotton at vmware.com] Sent: Sunday, August 04, 2013 1:41 AM To: OpenStack Development Mailing List (openstack-dev at lists.openstack.org) Subject: [openstack-dev] [Nova] Monitoring plugin file names Hi, As part of the BP blueprint utilization-aware-scheduling<https://blueprints.launchpad.net/openstack/?searchtext=utilization-aware-scheduling> a plugin has been added. I have an issue with the placement of the drivers (the code is looking good:)) and would like to know what the community thinks. Here are a few examples: 1. https://review.openstack.org/#/c/35760/17 - a new file has been added - nova/compute/plugins/libvirt_cpu_monitor_plugin.py<https://review.openstack.org/#/c/35760/17/nova/compute/plugins/libvirt_cpu_monitor_plugin.py> 2. https://review.openstack.org/#/c/39190/ - a new file has been added - nova/compute/plugins/libvirt_memory_monitor_plugin.py<https://review.openstack.org/#/c/39190/1/nova/compute/plugins/libvirt_memory_monitor_plugin.py> I think that these monitoring plugins should either reside in the directory nova/virt/libvirt/plugins or nova/compute/plugins<https://review.openstack.org/#/c/39190/1/nova/compute/plugins/libvirt_memory_monitor_plugin.py>/virt/libvirt. It would be interesting to know what others think. Thanks Gary -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstack.org/pipermail/openstack-dev/attachments/20130805/11ea45aa/attachment.html>