Open Stack

On 29/04/13 17:50 -0400, Russell Bryant wrote:
>On 04/29/2013 05:04 PM, Robert Collins wrote:
>> Here are the key takeaways we came up with:
>>  * No more big landings [except the purely mechanical]. Set a hard
>> limit - maybe 500 lines of diff. Big landings are more risky per line
>> of diff than small ones due to reviewer cognitive overhead - reviewers
>> get non-linearly less effective the larger the review.
>>
>
>I don't think we can set a # of lines that always makes sense.  However,
>I feel like in Nova we already do a nice job of pushing back hard on
>large patches in favor of breaking them up into a reasonable patch series.
>
>https://wiki.openstack.org/wiki/GitCommitMessages
>
>So, at least for Nova, this is business as usual.
>

This is the case for Glance as well. I guess it also depends on the
case (lets say someone adds a new store backend, it most likely will
be big if we count unittests as well). 

99,9% of the cases, patches are small and big patches are pushed back.

Cheers,
FF

-- 
{ name: "Flavio Percoco",
   gpg: "87112EC1", 
   internal: "8261386",
   phone: "+390687502386",
   irc: ["fpercoco", "flaper87"]}