Open Stack

Hi Gareth,

Clay gave you a -2 (core members for a project can), not a -1.
-2s (displayed as 'X') are permanent, and stay even when a new patchset is
pushed.
The reason for this is that the reviewer who gave it is supposed to look at
the new patches to see whether his/her concerns were addressed.

Salvatore

PS: I'm not a native english speaker so I cannot really comment, but should
"it still keep" be "it still keeps"?
Also... is 'contributer' a legal spelling? I usually use "contributor".
That would make 1$ for each email you ever sent :)
PPS: I'm not a grammar nazi, sorry for pointing out these things!


On 7 April 2013 11:50, Gareth <academicgareth at gmail.com> wrote:

> I have some problems with my changeset
> https://review.openstack.org/#/c/24022/
>
> Clay gave a -1 to this patch set 3. But when I uploaded set 4, that -1(or
> X) is still here. After jenkins's work, it still keep a X. I also try
> "recheck bug #xxx", but it doesn't work.
>
> What happened on this?
>
> --
> Gareth
>
> *Cloud Computing, Openstack, Fitness, Basketball
> *
> *Openstack contributer*
> *My promise: if you find any spelling or grammar mistake in my email from
> Mar 1 2013, notice me *
> *and I'll donate 1$ or 1￥ to open organization specified by you.*
>
> _______________________________________________
> OpenStack-dev mailing list
> OpenStack-dev at lists.openstack.org
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstack.org/pipermail/openstack-dev/attachments/20130407/d628e1c8/attachment.html>