[openstack-dev] [CI] Gerrit Trivial Rebase Detection (LP bug 881184)
vishvananda at gmail.com
Fri Sep 7 02:00:52 UTC 2012
I also noticed the new version of git-review is available now which
will not rebase patches automatically if they don't need a rebase.
On Sep 6, 2012, at 12:01 PM, Jeremy Stanley <fungi at yuggoth.org> wrote:
> The CI Team will be merging a long-requested_ feature to Gerrit
> on review.openstack.org at 16:00 UTC this coming Monday, 2012-09-10.
> Automatic Detection of Trivially-Rebased Commits
> Any committed patchset with no substantive changes (where the git
> patch-id_ and commit message remain the same) will have code
> review flags automatically_ reapplied from its predecessor
> patchset on that Change-Id. Patchsets where the commit message
> differs but the patch-id still remains the same will *not* have code
> reviews reapplied, but will have a comment automatically added from
> the Trivial Rebase user noting that the code itself is unchanged.
> It's hoped that these changes will improve workflow for code
> reviews, allowing reviewers to avoid re-reading identical patchsets
> looking for nonexistent alterations. The script itself is provided
> in upstream Gerrit's contrib_ directory and has been put through
> its paces with our OpenStack-specific modifications_ on a couple
> of non-production Gerrit servers already (including review-dev.o.o
> where it is currently installed and active_), so the CI Team
> doesn't anticipate any disruption. Follow up to the list with any
> questions and I'll be happy to answer!
> ..  https://bugs.launchpad.net/openstack-ci/+bug/881184
> ..  http://www.kernel.org/pub/software/scm/git/docs/git-patch-id.html
> ..  Automatically but not instantly--there is a delay of a few
> seconds before the review flags reappear in the WebUI.
> ..  https://gerrit.googlesource.com/gerrit/+/master/contrib
> ..  https://review.openstack.org/12373
> ..  https://review-dev.openstack.org/488
> Jeremy Stanley on behalf of the OpenStack CI Team
> OpenStack-dev mailing list
> OpenStack-dev at lists.openstack.org
More information about the OpenStack-dev