Open Stack

On 10/11/2012 02:10 PM, Joe Gordon wrote:
> git bisect points to this as the offending commit:
>
> commit 5b4b7e4083b85bd9c10792cf0adb11dc07e92333
>
> Author: David Ripton <dripton at redhat.com <mailto:dripton at redhat.com>>
>
> Date:   Tue Oct 9 16:51:24 2012 -0400
>
>
>      Tell SQLite to enforce foreign keys.
>
>      Fixes bug 1021023.
>
>      This requires SQLite version 3.6.19 or greater.  Older versions of
>
>      SQLite have no support for enforcing foreign keys.  However, SQLite
>
>      ignores unknown PRAGMA commands rather than treating them as errors,
>
>      so this change should be harmless with old versions of SQLite.
>
>      SQLAlchemy events require SQLAlchemy 0.7 or greater.  But other code
>
>      in this module already uses events, so this change should impose no
>
>      new SQLAlchemy version requirements.
>
>      Change-Id: Ic3eeeddbe012af65fe18c884674699cf16725d8d
>
>
> :100644 100644 6c349e0... a1257e1... M  nova/db/sqlalchemy/session.py
>
>
>
>
> looks like we need a newer version of SQLite

Could be, though I'm seeing the unit test failure now with SQLite 
3.7.11, which is plenty new enough.

The revert just got approved, so my broken patch is now my problem 
rather than everyone's problem.  Sorry for the disruption.

(Note that both Jenkins and Smokestack thought the patch was okay. 
Apparently it blew up Jenkins in a way that kept it from reporting 
failure correctly, and Dan Smith just submitted a patch for that.  Not 
sure about Smokestack yet.)

-- 
David Ripton   Red Hat   dripton at redhat.com