Open Stack

----- Original Message -----
> From: "Clark Boylan" <clark.boylan at gmail.com>
> To: openstack-dev at lists.openstack.org
> Sent: Tuesday, October 2, 2012 11:18:32 PM
> Subject: Re: [openstack-dev] SmokeStack broken?
> 
> On 10/02/2012 03:10 PM, Dan Prince wrote:
> > 
> > 
> > ----- Original Message -----
> >> From: "Sean Dague" <sdague at linux.vnet.ibm.com>
> >> To: OpenStack-dev at lists.openstack.org
> >> Sent: Tuesday, October 2, 2012 12:11:42 AM
> >> Subject: [openstack-dev] SmokeStack broken?
> >>
> >> SmokeStack seems to be acting up and failing on it's unit tests
> >> runs,
> >> which has left a string of -1 on all the reviews today. Anyone
> >> have
> >> the
> >> ability to poke at it?
> > 
> > Hi Sean,
> > 
> > I'm on travel and just now got some time to have a look at this.
> > 
> > The failed tests were getting errors trying to create the virtual
> > env for testing. The following error seems to be the root cause:
> > 
> >     (Currently using distribute 0.6.24
> >     (/tmp/smokestack_unittest/nova_source/dist/nova-2013.1/.tox/py27/lib/python2.7/site-packages/distribute-0.6.24-py2.7.egg))
> >     Complete output from command python setup.py egg_info:
> >     The required version of distribute (>=0.6.28) is not available,
> > 
> > The failures started happening when we recently reverted this
> > commit:
> > 
> > https://github.com/openstack/nova/commit/6e9f3bb10a105411b0eb3e8f22a252af0784cb0b
> > 
> > Note the -1 there in the Gerrit review from SmokeStack. Since the
> > failure was ignored some reviews today got marked with -1.
> > Appologies for that... I usually try to react to this sort of
> > thing faster... that said the failure is valid although it is
> > somewhat related to the tox version being used as well.
> > 
> > Digging into it a bit... it looks like we now require a more recent
> > distribute version to run Nova tests. This is because Python-MySQL
> > explicitly requires 0.6.28... so I think we should now update our
> > dependency in test-requires to this:
> > 
> > https://review.openstack.org/13972
> > 
> > I was also able to work around the issue by installing a newer
> > version of tox (1.4.2) which automatically requires the more
> > recent distribute.
> The fix that was used on the Jenkins slaves was to install virtualenv
> 1.8 or newer, https://review.openstack.org/#/c/13804/. Since
> virtualenv
> bundles distribute we had to use a version of virtualenv that
> included
> distribute 0.6.28. (installing newer tox may install newer virtualenv
> as
> well).

Thanks for the info Clark. I tested it a bit further and it appears that just simply updating test-requires to require distribute 0.6.28 alone doesn't quite seem to fix it because as you said virtualenv bundles distribute. Users would still need to update their virtualenv installation as well. When using tox (which is usually pre-installed) it would be nice if we had a good place to check for this. Any ideas on how we might make this more user friendly?

Dan

> 
> Clark
> > 
> > My guess is that other Nova devs might hit this same failure if
> > they try and recreate their virtual env's with the new version of
> > pip-requires.
> > 
> > Dan
> > 
> >> The -1 is probably shying a lot of folks off
> >> reviewing patches which are actually fine.
> >>
> >> 	-Sean
> >>
> >> --
> >> Sean Dague
> >> IBM Linux Technology Center
> >> email: sdague at linux.vnet.ibm.com
> >> alt-email: sldague at us.ibm.com
> >>
> >>
> >> _______________________________________________
> >> OpenStack-dev mailing list
> >> OpenStack-dev at lists.openstack.org
> >> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
> >>
> > 
> > _______________________________________________
> > OpenStack-dev mailing list
> > OpenStack-dev at lists.openstack.org
> > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
> > 
> 
> 
> _______________________________________________
> OpenStack-dev mailing list
> OpenStack-dev at lists.openstack.org
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>