[openstack-dev] [keystone] Move utils.Ec2Signer class into keystoneclient?

Steven Hardy shardy at redhat.com
Fri Nov 30 09:57:49 UTC 2012


On Mon, Nov 26, 2012 at 12:36:05PM -0500, Adam Young wrote:
> On 11/26/2012 12:21 PM, heckj wrote:
> >Hey Steve,
> >
> >Where are you going to make the signed URLs from? Keystoneclient seems like a reasonable place to encapsulate this if you want to import and use from a generic location, but if it's from a different openstack project, it might make more sense to put it into OSLO - for me that just depends on where you're going to use it from and if we can see other projects wanting to do the same thing.
> Once we get Oslo as a stand alone library, we can review migrating
> pieces from Keystone to Oslo, but for now, and especially for
> authentication pieces that are Keystone specific (like this) they
> should certainly be in the Keystone client, for the same reason the
> signing code belongs there.

Review up (awaiting approval ;) https://review.openstack.org/#/c/16964/

This adds Ec2Signer to keystoneclient - when this is merged I'll post
another patch making keystone/contrib/ec2/core.py import from keystoneclient
and remove Ec2Signer from keystone.common.utils

Thanks,

Steve



More information about the OpenStack-dev mailing list