Open Stack

On 07/25/2012 11:02 PM, Sumit Naiksatam (snaiksat) wrote:
>
> Thanks Bob for bringing this up. The following option you stated 
> sounds good to me:
>
> "to have a variable in quantum.conf specify which plugin-specific .ini 
> file(s) need(s)"
>
> To take it one step further, could this variable be pointed to a 
> directory name? That way it would require a single configuration in 
> the quantum.conf, and all the ini files in that directory could be loaded.
>

Sadly this is not supported by the common config code at the moment. The 
fact that we are using the common configuration code enables the 
application to pass a number of different configuration files via the 
command line options.

In my opinion one of the nice things about the common configuration is 
that it give the user a lot of flexibility. There may be some who want 
to have all of the information in one configuration file - for example 
quantum.conf. Others may want to preserve the same format as today. Both 
of these are supported. By default we will be using the latter to 
support backward compatibility.

> Thanks,
>
> ~Sumit.
>
> *From:*Dan Wendlandt [mailto:dan at nicira.com]
> *Sent:* Wednesday, July 25, 2012 12:46 PM
> *To:* OpenStack Development Mailing List
> *Subject:* Re: [openstack-dev] [Quantum] Agents and configuration files
>
> On Wed, Jul 25, 2012 at 12:23 PM, Robert Kukura <rkukura at redhat.com 
> <mailto:rkukura at redhat.com>> wrote:
>
> On 07/24/2012 01:24 PM, Gary Kotton wrote:
> > Hi,
>
> > I have made a first patch - https://review.openstack.org/#/c/10234. It
> > was actually simpler than I had expected. By a fluke the change also
> > imported better logging for the agents. This should also move to the
> > openstack-common logging.
> > I still need to do some additional work:
> > 1. ensure agent tests are OK
> > 2. update devstack to support the configurations
>
> I have begun reviewing patch set 5, and so far it looks good. I'd like
> to see this merged quickly to resolve the plugin unit test issues
> currently on master.
>
> But I do have one significant concern about the direction the quantum
> configuration has taken. My understanding is that with this patch,
> neither the quantum-server nor the agents are intended to load the
> plugin-specific .ini file unless a second --config-file option
> referencing it is passed in the command line. Unless I am missing
> something, this means that the quantum-server command line will now need
> to be plugin-specific in order for the plugin-specific .ini file to be
> loaded. Although this can be handled in devstack, it seems to be
> problematic for downstream systemd/init/upstart scripts which should
> generally not require customization once they are installed.
>
> I'm not very familiar with the common config mechanisms yet, but would
> it be possible for both the quantum-server/plugin and the agent to
> automatically load their .ini file(s), to have the quantum.conf file
> somehow include the .ini file(s), or to have a variable in quantum.conf
> specify which plugin-specific .ini file(s) need(s) to be loaded? This
> way, the quantum-server command line in the systemd/init/upstart scripts
> would only need to reference quantum.conf, and would not need to be
> customized based on which plugin is chosen.
>
> Jumping into this thread late, so please ignore this if the ideas I'm 
> suggesting have already been considered and rejected.  Bob, I tend to 
> share your viewpoint on this.  I do think its nice to be able to 
> specify a particular config file for the plugin (currently, this is 
> impossible, the plugin will just search a set of paths), however, I 
> wonder if this could be achieved either by putting all plugin config 
> into separate sections of the quantum.conf, or by having an entry of 
> quantum.conf point to plugin config in some way.
>
> dan
>
>
>     -Bob
>
>
>     > Thanks
>     > Gary
>     >
>     > On 07/24/2012 08:15 PM, Gary Kotton wrote:
>     >> Hi,
>     >> Please see my inline below.
>     >> Thanks
>     >> Gary
>     >>
>     >> On 07/24/2012 07:47 PM, Salvatore Orlando wrote:
>     >>> I +1 what Mark and Gary agreed on the IRC.
>     >>> That's exactly what I meant by 'namespaces' on yesterday's
>     meeting.
>     >>>
>     >>> Cheers,
>     >>> Salvatore
>     >>>
>     >>> On 24 July 2012 16:30, Sumit Naiksatam (snaiksat)
>     <snaiksat at cisco.com <mailto:snaiksat at cisco.com>
>
>     >>> <mailto:snaiksat at cisco.com <mailto:snaiksat at cisco.com>>> wrote:
>     >>>
>     >>>     Hi Gary,
>     >>>
>     >>>
>     >>>
>     >>>     Are you asking this just in the context of the RPC related
>     >>>     configurations, or also for moving all the existing
>     configuration
>     >>>     from the plugin-specific configuration files (the ones under
>     >>>     etc/quantum/plugins) to a single configuration file?
>     >>>
>     >>
>     >> The RPC was the motivation for this. This is information that is
>     >> required by both the agents and the plugins. In addition to
>     this due
>     >> to the fact that is is from the openstack-common (which used the
>     >> global cfg.CONF) complicates things.
>     >>
>     >> There is still the option to use multiple files with input like:
>     >>   --config-file=/etc/quantum.conf
>     --config-file=/etc/quantum/quantum.conf
>     --config-dir=/etc/quantum/plugins.d
>     >>
>     >> Thanks
>     >> Gary
>     >>
>     >>
>     >>>
>     >>>
>     >>>     Moving plugin-independent common configuration to a common
>     file
>     >>>     makes sense to me (including the agent and/or RPC related
>     >>>     configurations as discussed in the IRC meeting yesterday).
>     >>>     However, I am not in favor of moving all plugin-specific
>     >>>     configurations to a single/common file.
>     >>>
>     >>>
>     >>>
>     >>>     Thanks,
>     >>>
>     >>>     ~Sumit.
>     >>>
>     >>>
>     >>>
>
>     >>>     *From:*Gary Kotton [mailto:gkotton at redhat.com
>     <mailto:gkotton at redhat.com>
>     >>> <mailto:gkotton at redhat.com <mailto:gkotton at redhat.com>>]
>     >>>     *Sent:* Tuesday, July 24, 2012 6:03 AM
>     >>>     *To:* openstack-dev at lists.openstack.org
>     <mailto:openstack-dev at lists.openstack.org>
>     >>> <mailto:openstack-dev at lists.openstack.org
>     <mailto:openstack-dev at lists.openstack.org>>
>     >>>     *Subject:* Re: [openstack-dev] [Quantum] Agents and
>     configuration
>
>     >>>     files
>     >>>
>     >>>
>     >>>
>     >>>     Hi,
>     >>>     Can people please raise their concerns about moving all of the
>     >>>     plugin.ini files into quantum.conf.
>     >>>     This will solve us a number of problems. Please let me know if
>     >>>     you have any reservations.
>     >>>     Thanks
>     >>>     Gary
>     >>>
>     >>>     On 07/24/2012 09:17 AM, Gary Kotton wrote:
>     >>>
>     >>>     Hi,
>     >>>
>
>     >>>     *Background*: The quantum service makes use of the
>     configuration
>
>     >>>     file quantum.conf. In addition to this there is a common
>     >>>     configuration file shared between the plugin and the agent
>     >>>     (plugin.ini). The aforementioned files are loaded by the
>     common
>     >>>     configuration files.
>     >>>
>
>     >>>     *Current developments*: A number of current developments, for
>
>     >>>     example notifications (https://review.openstack.org/#/c/9835/)
>     >>>     and scalable agents (https://review.openstack.org/#/c/9591/)
>     >>>     require RPC configurations.
>     >>>
>     >>>     From the discussion last night the community the consensus
>     is to
>     >>>     have the common configuration items that may be relevant
>     to one
>     >>>     or more agent/plugin in the quantum configuration file. This
>     >>>     change will require the agents to also load the quantum.conf
>     >>>     configuration files.
>     >>>
>
>     >>>     *Open issues*:
>
>     >>>     1. I do not think that the common configuration supports
>     mapping
>     >>>     of name spaces to configuration files.
>     >>>     2. Configuration file loading. With the plugins the
>     configuration
>     >>>     files are loaded in two stages. If possible it would be great
>     >>>     that the files could be loaded at once - this can be done by
>     >>>     listing the plugin/agent ini file(s) in the quantum.conf. When
>     >>>     this is loaded then the other files will be loaded.
>     >>>
>     >>>     Please let me know if you have any comments or objections. I
>     >>>     would like to move ahead and start to work on this.
>     >>>
>     >>>     Thanks
>     >>>     Gary
>     >>>
>     >>>
>     >>>
>     >>>
>     >>>
>     >>>
>     >>>     _______________________________________________
>     >>>
>     >>>     OpenStack-dev mailing list
>     >>>
>
>     >>> OpenStack-dev at lists.openstack.org
>     <mailto:OpenStack-dev at lists.openstack.org>
>     <mailto:OpenStack-dev at lists.openstack.org
>     <mailto:OpenStack-dev at lists.openstack.org>>
>
>     >>>
>     >>> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>     >>>
>     >>>
>     >>>
>     >>>
>     >>>     _______________________________________________
>     >>>     OpenStack-dev mailing list
>     >>> OpenStack-dev at lists.openstack.org
>     <mailto:OpenStack-dev at lists.openstack.org>
>
>     >>> <mailto:OpenStack-dev at lists.openstack.org
>     <mailto:OpenStack-dev at lists.openstack.org>>
>
>     >>> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>     >>>
>     >>>
>     >>
>     >>
>     >> _______________________________________________
>     >> OpenStack-dev mailing list
>     >> OpenStack-dev at lists.openstack.org
>     <mailto:OpenStack-dev at lists.openstack.org>
>     >> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>     >
>     >
>     >
>     > _______________________________________________
>     > OpenStack-dev mailing list
>     > OpenStack-dev at lists.openstack.org
>     <mailto:OpenStack-dev at lists.openstack.org>
>     > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>     >
>
>
>     _______________________________________________
>     OpenStack-dev mailing list
>     OpenStack-dev at lists.openstack.org
>     <mailto:OpenStack-dev at lists.openstack.org>
>     http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>
>
>
> -- 
> ~~~~~~~~~~~~~~~~~~~~~~~~~~~
> Dan Wendlandt
>
> Nicira, Inc: www.nicira.com <http://www.nicira.com>
>
> twitter: danwendlandt
> ~~~~~~~~~~~~~~~~~~~~~~~~~~~
>
>
> _______________________________________________
> OpenStack-dev mailing list
> OpenStack-dev at lists.openstack.org
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstack.org/pipermail/openstack-dev/attachments/20120726/087f7285/attachment-0001.html>