Open Stack

Hi John,

Overall, I think you've done an absolute shit job of ... wait a
second ... I'm not that guy :-P

(Sorry, couldn't resist)

Since cinder forked from nova, it has obviously gotten out of sync in a
bunch of places. I've pushed some patches to re-sync some pieces again
and also delete some unused code.

Since it's pretty hard to figure out from gerrit what order the patches
come in, I thought I'd do a map :)

Firstly, patches to sync cfg related changes:

  https://review.openstack.org/9863 Sync to newer openstack.common.cfg
  https://review.openstack.org/9864 Pass 'cinder' project into ConfigOpts
  https://review.openstack.org/9865 Misused and not used config options
  https://review.openstack.org/9866 Remove old flagfile support
  https://review.openstack.org/9867 Sync with latest version of openstack.common.cfg
  https://review.openstack.org/9868 Use cfg's new behavior of reset() clearing overrides
  https://review.openstack.org/9869 Use cfg's new global CONF object
  https://review.openstack.org/9870 Sync cfg and iniparser from openstack-common.

And a patch to delete cfg related code which I don't think is relevant
to cinder:

  https://review.openstack.org/9871 Remove 'cinder-manage config convert'

Now a patch to remove @synchronized, since it's unused in cinder. Later
RPC related patches conflict with this which is why it's here:

  https://review.openstack.org/9888 Remove unused synchronization decorator

And a big bunch of patches to adopt the rpc module from openstack-common:

  https://review.openstack.org/9890 Make use of openstack.common.jsonutils.
  https://review.openstack.org/9899 Stop using cinder.exception from cinder.rpc.
  https://review.openstack.org/9900 Make kombu support optional for running unit tests.
  https://review.openstack.org/9901 Add base support for rpc API versioning.
  https://review.openstack.org/9902 Add version to scheduler rpc API.
  https://review.openstack.org/9903 Localize rpc options to rpc code.
  https://review.openstack.org/9904 Remove cinder.context dependency from cinder.rpc
  https://review.openstack.org/9905 Remove cinder.log usage from cinder.rpc.
  https://review.openstack.org/9906 Move queue_get_for() from db to rpc.
  https://review.openstack.org/9907 Use openstack.common.cfg.CONF.
  https://review.openstack.org/9908 Add missing ack to impl_qpid.
  https://review.openstack.org/9909 Use save_and_reraise_exception() from common.
  https://review.openstack.org/9910 Add missing gettextutils from openstack-common.
  https://review.openstack.org/9911 Use rpc from openstack-common.

Now a series of 4 patches to remove unused code. They come together
because they conflict in various ways:

https://review.openstack.org/9880 Remove unused raise_http_conflict_for_instance_invalid_state()
https://review.openstack.org/9881 Remove unused metadata serialization
https://review.openstack.org/9882 Remove unused get_{id,version}_from_href()
https://review.openstack.org/9883 Remove unused check_snapshots_enabled

And, finally, 5 non-conflicting patches to remove unused code. These do
not depend on each other:

  https://review.openstack.org/9884 Remove unused enabled_apis flag
  https://review.openstack.org/9885 Remove unused fake memcache client
  https://review.openstack.org/9886 Remove some unused helper scripts
  https://review.openstack.org/9887 Remove unused OverLimitFault
  https://review.openstack.org/9889 Remove unused wrap_errors decorator

You can kiss my ass,^H^H^H^H^H^H^H^H
Regards,
Mark.