[openstack-dev] Change in openstack/quantum[master]: add name into port and subnet.

Dan Wendlandt dan at nicira.com
Mon Jul 16 15:41:47 UTC 2012


On Sat, Jul 14, 2012 at 11:14 PM, Yong Sheng Gong <gongysh at cn.ibm.com>wrote:

>  Hi dan
> Gary thinks the name or network, subnet and port should be unique, But I
> think it can duplicate.
> For now keystone's uername is unique, but nova servers' names are not.
>
> Do we need to discuss it at Monday's meeting?
>

Sure, I'll add it to the agenda.  As I mentioned in the review, I think the
analog here is nova server names, which need not be unique.

Dan



>
> Thanks
> Yong Sheng Gong
>
>
>
> -----"garyk (Code Review)" <review at openstack.org> <review at openstack.org>wrote: -----
> To: Yong Sheng Gong/China/IBM at IBMCN
> From: "garyk (Code Review)" <review at openstack.org> <review at openstack.org>
> Date: 07/15/2012 01:55PM
> Cc: garyk <gkotton at redhat.com> <gkotton at redhat.com>
> Subject: Change in openstack/quantum[master]: add name into port and
> subnet.
>
>
> garyk has posted comments on this change.
>
> Change subject: add name into port and subnet.
> ......................................................................
>
>
> Patch Set 1: Looks good to me (core reviewer)
>
> Would it be possible that you send a mail to the list and we discuss it at
> Mondays meeting.
> In the mean time the code looks good.
>
> --
> To view, visit https://review.openstack.org/9836
> To unsubscribe, visit https://review.openstack.org/settings
>
> Gerrit-MessageType: comment
> Gerrit-Change-Id: I40c834ed66e2da14a414232c86c9fd4f5c1d9154
> Gerrit-PatchSet: 1
> Gerrit-Project: openstack/quantum
> Gerrit-Branch: master
> Gerrit-Owner: gongysh <gongysh at cn.ibm.com> <gongysh at cn.ibm.com>
> Gerrit-Reviewer: Jenkins
> Gerrit-Reviewer: garyk <gkotton at redhat.com> <gkotton at redhat.com>
> Gerrit-Reviewer: gongysh <gongysh at cn.ibm.com> <gongysh at cn.ibm.com>
>
>


-- 
~~~~~~~~~~~~~~~~~~~~~~~~~~~
Dan Wendlandt
Nicira, Inc: www.nicira.com
twitter: danwendlandt
~~~~~~~~~~~~~~~~~~~~~~~~~~~
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstack.org/pipermail/openstack-dev/attachments/20120716/66c47e28/attachment.html>


More information about the OpenStack-dev mailing list