Open Stack

On 07/14/2012 07:11 AM, Yong Sheng Gong wrote:
> Hi,
> I am trying to introduce notifier and rpc  modules into quantum from
> openstack.common project. Besides the previous pep8's problem, I found
> another one.
> 
> After I executed the update.sh in openstack.common with
> modules=cfg,exception,importutils,iniparser,jsonutils,policy,setup,notifier,timeutils,log,context,local,rpc,gettextutils,excutils
> in quantum project's openstack-common.conf file, I cannot execute
> 'python setup.py install' in quantum project's top dir.
> 
> Beginning lines in quantum's setup.py are:
> import setuptools
> 
> from quantum.openstack.common import setup
> 
> setup.write_vcsversion('quantum/vcsversion.py')
> 
> Obviously, it is expecting the openstack.common.setup.write_vcsversion()
> function, however which is gone in recent change of opoenstack.common
> project.
> 
> Should quantum project's setup.py change accordingly?

Yes. I will make a patch today or tomorrow.

> Thanks
> Yong Sheng Gong
> 
> 
> -----Yun Mao <yunmao at gmail.com> wrote: -----
> To: OpenStack Development Mailing List <openstack-dev at lists.openstack.org>
> From: Yun Mao <yunmao at gmail.com>
> Date: 07/14/2012 09:06PM
> Subject: Re: [openstack-dev] pep8-1.3.3 result of openstack common codes
> 
> perhaps the pep8 check should ignore the openstack-common code. Thanks,
> 
> Yun
> 
> On Sat, Jul 14, 2012 at 5:24 AM, Yong Sheng Gong <gongysh at cn.ibm.com> wrote:
>> Hi,
>>
>> Quantum needs to use some codes in openstack common project, but
> pep8-1.3.3
>> (quantum project sticks to the latest pep8 version) complains many pep8
>> violations:
>> quantum/openstack/common/log.py:68:19: E121 continuation line
> indentation is
>> not a multiple of four
>>                   'amqplib=WARN',
>>                   ^
>> quantum/openstack/common/log.py:74:19: E123 closing bracket does not match
>> indentation of opening bracket's line
>>                   ],
>>                   ^
>> quantum/openstack/common/log.py:91:5: E123 closing bracket does not match
>> indentation of opening bracket's line
>>     ]
>>     ^
>> quantum/openstack/common/log.py:107:5: E123 closing bracket does not match
>> indentation of opening bracket's line
>>     ]
>>     ^
>> quantum/openstack/common/log.py:211:39: E128 continuation line
>> under-indented for visual indent
>>                                       line.rstrip().splitlines())
>>                                       ^
>> quantum/openstack/common/log.py:212:21: E128 continuation line
>> under-indented for visual indent
>>                     for line in lines]
>>                     ^
>> quantum/openstack/common/log.py:251:17: E125 continuation line does not
>> distinguish itself from next logical line
>>                 CONF.list_notifier_drivers):
>>                 ^
>> quantum/openstack/common/log.py:254:34: E127 continuation line
> over-indented
>> for visual indent
>>                                  'error_notification',
>>                                  ^
>> quantum/openstack/common/log.py:416:13: E125 continuation line does not
>> distinguish itself from next logical line
>>             CONF.logging_debug_format_suffix):
>>             ^
>> quantum/openstack/common/rpc/__init__.py:50:80: E501 line too long (81
>> 79
>> characters)
>>                 default=['quantum.openstack.common.exception',
>> 'nova.exception'],
>>
>> ^
>> quantum/openstack/common/rpc/impl_zmq.py:51:80: E501 line too long (85
>> 79
>> characters)
>>
>> default='quantum.openstack.common.rpc.matchmaker.MatchMakerLocalhost',
>>
>> ^
>> quantum/openstack/common/notifier/api.py:39:5: E123 closing bracket
> does not
>> match indentation of opening bracket's line
>>     ]
>>     ^
>> quantum/openstack/common/notifier/api.py:124:18: E121 continuation line
>> indentation is not a multiple of four
>>                  _('%s not in valid priorities') % priority)
>>                  ^
>> quantum/openstack/common/notifier/api.py:131:20: E127 continuation line
>> over-indented for visual indent
>>                    publisher_id=publisher_id,
>>                    ^
>> quantum/openstack/common/notifier/api.py:132:20: E127 continuation line
>> over-indented for visual indent
>>                    event_type=event_type,
>>                    ^
>> quantum/openstack/common/notifier/api.py:133:20: E127 continuation line
>> over-indented for visual indent
>>                    priority=priority,
>>                    ^
>> quantum/openstack/common/notifier/api.py:134:20: E127 continuation line
>> over-indented for visual indent
>>                    payload=payload,
>>                    ^
>> quantum/openstack/common/notifier/api.py:135:20: E127 continuation line
>> over-indented for visual indent
>>                    timestamp=str(timeutils.utcnow()))
>>                    ^
>> quantum/openstack/common/notifier/api.py:141:25: E127 continuation line
>> over-indented for visual indent
>>                         locals())
>>                         ^
>> quantum/openstack/common/notifier/list_notifier.py:22:9: E128 continuation
>> line under-indented for visual indent
>>         default=['quantum.openstack.common.notifier.no_op_notifier'],
>>         ^
>> quantum/openstack/common/notifier/list_notifier.py:23:9: E126 continuation
>> line over-indented for hanging indent
>>         help='List of drivers to send notifications')
>>         ^
>> quantum/openstack/common/notifier/log_notifier.py:33:13: E126 continuation
>> line over-indented for hanging indent
>>             'quantum.openstack.common.notification.%s' %
>> message['event_type'])
>>             ^
>> quantum/openstack/common/notifier/rabbit_notifier.py:25:9: E128
> continuation
>> line under-indented for visual indent
>>         default=['notifications', ],
>>         ^
>> quantum/openstack/common/notifier/rabbit_notifier.py:26:9: E126
> continuation
>> line over-indented for hanging indent
>>         help='AMQP topic used for openstack notifications')
>>
>> I don't know if I can update the openstack common project codes.
>> Thanks
>> Yong Sheng Gong
>>
>> _______________________________________________
>> OpenStack-dev mailing list
>> OpenStack-dev at lists.openstack.org
>> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>>
> 
> _______________________________________________
> OpenStack-dev mailing list
> OpenStack-dev at lists.openstack.org
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
> 
> 
> 
> _______________________________________________
> OpenStack-dev mailing list
> OpenStack-dev at lists.openstack.org
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>