[neutron] Freeze exception
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512 Hi all, I'd like to propose the following exception to be included in the next Icehouse release: https://review.openstack.org/#/c/105392/ The fix can be seen as critical, because it fixes db failures in trivial cases, like when doing port deletion requests by Neutron. The result of the failure is that request is not served, and the affected port is still present in the database. This may also block instance deletion when bound to a Neutron port. The issue affects most Neutron plugins. The fix was already pushed to gate before but failed to merge and required trivial rebase, it has two +2's, one of them from Neutron PTL. Cheers, /Ihar -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.22 (Darwin) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCgAGBQJT317QAAoJEC5aWaUY1u57bZwIAKolcoePN+eUiZ03JxMFLrvl IISj/Np9zKy6PDqn0mFeZy2P+d/fJamc4FI8VC1FaJaBtOci3LS/B6xCTilvdPIJ 7DolR4X3be1AfyKdQglRnTJrb+7wM0oSfytEDpU0dQDxP16ML+S8BIwHse7Cp3th GoAMTTlKt5B8gCJSWfQvz6IKX93j3D6u9cccl5kSK21zNHgjIKLTTV08s07rsbu+ s1O8b3sfqCm13v1EcR9rQx8FTOOSCnrVnIJtsyZaB/SzwDGZQ2fcv87BA6nXp6WB D5r20tIEnVfxGbotdYGN2surNZtw4IPpiv2kJgp/bRhPKX6LonKEYU6z9EiMyC4= =DqGL -----END PGP SIGNATURE-----
On Mon, Aug 4, 2014 at 5:22 AM, Ihar Hrachyshka <ihrachys@redhat.com> wrote:
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512
Hi all,
I'd like to propose the following exception to be included in the next Icehouse release: https://review.openstack.org/#/c/105392/
The fix can be seen as critical, because it fixes db failures in trivial cases, like when doing port deletion requests by Neutron. The result of the failure is that request is not served, and the affected port is still present in the database. This may also block instance deletion when bound to a Neutron port.
The issue affects most Neutron plugins.
The fix was already pushed to gate before but failed to merge and required trivial rebase, it has two +2's, one of them from Neutron PTL.
+1, getting this into merged would be very beneficial to our users.
Cheers, /Ihar -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.22 (Darwin) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
iQEcBAEBCgAGBQJT317QAAoJEC5aWaUY1u57bZwIAKolcoePN+eUiZ03JxMFLrvl IISj/Np9zKy6PDqn0mFeZy2P+d/fJamc4FI8VC1FaJaBtOci3LS/B6xCTilvdPIJ 7DolR4X3be1AfyKdQglRnTJrb+7wM0oSfytEDpU0dQDxP16ML+S8BIwHse7Cp3th GoAMTTlKt5B8gCJSWfQvz6IKX93j3D6u9cccl5kSK21zNHgjIKLTTV08s07rsbu+ s1O8b3sfqCm13v1EcR9rQx8FTOOSCnrVnIJtsyZaB/SzwDGZQ2fcv87BA6nXp6WB D5r20tIEnVfxGbotdYGN2surNZtw4IPpiv2kJgp/bRhPKX6LonKEYU6z9EiMyC4= =DqGL -----END PGP SIGNATURE-----
_______________________________________________ Openstack-stable-maint mailing list Openstack-stable-maint@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-stable-maint
2014-08-04 15:24 GMT+02:00 Kyle Mestery <mestery@mestery.com>:
+1, getting this into merged would be very beneficial to our users.
I've asked in backport review, repeating here: are there known 3rd party Neutron plugins which need to be made aware of this change? Out-of-tree drivers are generally frowned upon but I'm not sure if this is a part of documented plugin API? Cheers, Alan
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512 On 05/08/14 09:07, Alan Pevec wrote:
2014-08-04 15:24 GMT+02:00 Kyle Mestery <mestery@mestery.com>:
+1, getting this into merged would be very beneficial to our users.
I've asked in backport review, repeating here: are there known 3rd party Neutron plugins which need to be made aware of this change? Out-of-tree drivers are generally frowned upon but I'm not sure if this is a part of documented plugin API?
This patch does not change default behaviour for disassociate_floatingips() which is 'notify after db transaction'. Plugins that are not in the tree may utilize the new optional behaviour (do_notify=False) in case they also call the method from under another transaction to avoid the issue, but those fixes belong to those plugins, and the change proposed does not break them more than the original code. So we don't break third-party plugins, though we give them mechanism to avoid specific db deadlock timeout in case it occurs in their code. => should be safe to backport. /Ihar -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.22 (Darwin) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCgAGBQJT4IeZAAoJEC5aWaUY1u574FYH/0UOnrDeSp8N5Y/R6Xv/gCZX KneRjVsZeQWHoraE8xvSaTHMf/mKr7MKG25PCSF9vJzkLnF9dpzBSyYiu3A6LvkR JpXbxqw4QLnki1YPhyUuFbd0VNDbFSJMVVoXPzAAj/cYfhDYw1zxj6KPWvwC96Ap o/t5RRDURLlopi7NAhBKiyCChhZc3ddUMoCqpFOXlqq5VYqITNLADVf7q42ldpvc sBj9V/u/HvCZwxQcfnkcxSLZeHWyAqMF6aEGj+duYJaAN+zCOY1A4UmDDYBukAVq TGHlbG5YUFm4ZOlfpYobbGMpBDgsB0NFUefSt7UlVYF1jO8XauSNilTHNWYLpYg= =vWWy -----END PGP SIGNATURE-----
2014-08-05 9:28 GMT+02:00 Ihar Hrachyshka <ihrachys@redhat.com>:
So we don't break third-party plugins, though we give them mechanism to avoid specific db deadlock timeout in case it occurs in their code.
Would be good to document this in ReleaseNotes/2014.1.2#Known_Issues_and_Limitations section of relnotes. Chuck, please create draft wiki for 2014.1.2 so we can start collecting such items. Cheers, Alan
On Tue, Aug 5, 2014 at 3:33 AM, Alan Pevec <apevec@gmail.com> wrote:
2014-08-05 9:28 GMT+02:00 Ihar Hrachyshka <ihrachys@redhat.com>:
So we don't break third-party plugins, though we give them mechanism to avoid specific db deadlock timeout in case it occurs in their code.
Would be good to document this in ReleaseNotes/2014.1.2#Known_Issues_and_Limitations section of relnotes.
Chuck, please create draft wiki for 2014.1.2 so we can start collecting such items.
Sorry I was dealing with an internal deadline here. Done. https://wiki.openstack.org/wiki/Releases/2014.1.2
Cheers, Alan
+1 to the exception. We've been lenient the last few releases WRT allowing changes in that were approved pre-freeze but failed on gate issues. On Mon, Aug 4, 2014 at 3:22 AM, Ihar Hrachyshka <ihrachys@redhat.com> wrote:
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512
Hi all,
I'd like to propose the following exception to be included in the next Icehouse release: https://review.openstack.org/#/c/105392/
The fix can be seen as critical, because it fixes db failures in trivial cases, like when doing port deletion requests by Neutron. The result of the failure is that request is not served, and the affected port is still present in the database. This may also block instance deletion when bound to a Neutron port.
The issue affects most Neutron plugins.
The fix was already pushed to gate before but failed to merge and required trivial rebase, it has two +2's, one of them from Neutron PTL.
Cheers, /Ihar -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.22 (Darwin) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
iQEcBAEBCgAGBQJT317QAAoJEC5aWaUY1u57bZwIAKolcoePN+eUiZ03JxMFLrvl IISj/Np9zKy6PDqn0mFeZy2P+d/fJamc4FI8VC1FaJaBtOci3LS/B6xCTilvdPIJ 7DolR4X3be1AfyKdQglRnTJrb+7wM0oSfytEDpU0dQDxP16ML+S8BIwHse7Cp3th GoAMTTlKt5B8gCJSWfQvz6IKX93j3D6u9cccl5kSK21zNHgjIKLTTV08s07rsbu+ s1O8b3sfqCm13v1EcR9rQx8FTOOSCnrVnIJtsyZaB/SzwDGZQ2fcv87BA6nXp6WB D5r20tIEnVfxGbotdYGN2surNZtw4IPpiv2kJgp/bRhPKX6LonKEYU6z9EiMyC4= =DqGL -----END PGP SIGNATURE-----
_______________________________________________ Openstack-stable-maint mailing list Openstack-stable-maint@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-stable-maint
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512 Merged. On 04/08/14 12:22, Ihar Hrachyshka wrote:
Hi all,
I'd like to propose the following exception to be included in the next Icehouse release: https://review.openstack.org/#/c/105392/
The fix can be seen as critical, because it fixes db failures in trivial cases, like when doing port deletion requests by Neutron. The result of the failure is that request is not served, and the affected port is still present in the database. This may also block instance deletion when bound to a Neutron port.
The issue affects most Neutron plugins.
The fix was already pushed to gate before but failed to merge and required trivial rebase, it has two +2's, one of them from Neutron PTL.
Cheers, /Ihar
_______________________________________________ Openstack-stable-maint mailing list Openstack-stable-maint@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-stable-maint
-----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.22 (Darwin) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCgAGBQJT4M40AAoJEC5aWaUY1u57hx0IAI6EKcvU1+6HTp82dhBxYptS 3WNUPOZQLw1Vlb5hzdx0TB7/oLsIsc4DSQNz4alBy+eQEK4WWHEv3y3GxBsa9w+I CKz0Xv+WYx2++SxKG0/ycLk+TL8IKh/0BJ5N6noxS75dA8DnZb8N7oINPzHLeG28 oLzan7Yau/BxxZpLxSjn/m1x5GXGAxKnHxSVZZs1o/LLQ+Rue/Vh9qzO4k9kI9qT TH/sCgOgwhv4TuFB8NAOiX3PCZR2xUAUHhcxDiDi3w6dRHw+/hsx46e51DOZRiFk bXhMwg8kcm0RKqZsB26SgJCbIG0d2J4zkLImCyUhUy8weYfgTDcIBuBDQnyng/w= =XseY -----END PGP SIGNATURE-----
participants (5)
-
Adam Gandelman
-
Alan Pevec
-
Chuck Short
-
Ihar Hrachyshka
-
Kyle Mestery