Havana freeze exception request
Hi guys, I have a request for a small Havana release expection: https://review.openstack.org/#/c/117144/ It’s just adding the Hyper-V compute driver name in the CONF.compute_driver option description, along with the shortened class path, matchig what has been done for other drivers: “hyperv.HyperVDriver”. Nothing extremely important, just a matter of consistency between compute driver configurations. Thanks, Alessandro
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512 On 17/09/14 15:46, Alessandro Pilotti wrote:
Hi guys,
I have a request for a small Havana release expection: https://review.openstack.org/#/c/117144/
It?s just adding the Hyper-V compute driver name in the CONF.compute_driver option description, along with the shortened class path, matchig what has been done for other drivers: ?hyperv.HyperVDriver?. Nothing extremely important, just a matter of consistency between compute driver configurations.
I don't see how this patch is critical for the release. It doesn't solve any major failure, so we can miss it this time. /Ihar -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.22 (Darwin) iQEcBAEBCgAGBQJUGZO/AAoJEC5aWaUY1u57OwoH/0Kz9wmiSdkqXQInJZpVuzt8 uc+cZPpRGZUHHsGdRRnEAc+DROHQHQbTWaZyjlLMjSF92b1QnmAHpibOrbsqcVEK kTFFZxibawwfPobZ7SI6lT2lSDX5R7pmVoKLfM7cYYBS5r9BtgijqSAH2R7FiGF5 cqULUxf+axjX4VQ4EeBjS57asZ2G/eYFDC/v1+XrMI1opMKIsoIZwO72iMYDg4sg S83BNyCZUqXyGSA8mcYJvPQ4bbzvYoIm1K+CS6JGBUbCu1WFNFOjHiHmFpTiAQrl /PqUKcvYiHHRFadimnRX9+nfpSVVoQfgvlDucGDNHQqm5qEZ1ICxpd4oJGudOig= =g9tv -----END PGP SIGNATURE-----
Alessandro Pilotti wrote:
Hi guys,
I have a request for a small Havana release expection: https://review.openstack.org/#/c/117144/
It’s just adding the Hyper-V compute driver name in the CONF.compute_driver option description, along with the shortened class path, matchig what has been done for other drivers: “hyperv.HyperVDriver”. Nothing extremely important, just a matter of consistency between compute driver configurations.
Does this potentially break existing translations ? (at first glance it looks like a non-translated string so it would be alright). That said this is not really necessary, just a nice to have. If we have a lot of spare cycles I guess we can allow this, but otherwise I would just keep it out. -- Thierry Carrez (ttx)
Hi, I do not see a problem with approving this. I think that the issue is more with the patch of the driver - that is, the change in https://review.openstack.org/#/c/117144/3/nova/virt/hyperv/__init__.py Thanks Gary On 9/17/14, 5:00 PM, "Thierry Carrez" <thierry@openstack.org> wrote:
Alessandro Pilotti wrote:
Hi guys,
I have a request for a small Havana release expection: https://review.openstack.org/#/c/117144/
It¹s just adding the Hyper-V compute driver name in the CONF.compute_driver option description, along with the shortened class path, matchig what has been done for other drivers: ³hyperv.HyperVDriver². Nothing extremely important, just a matter of consistency between compute driver configurations.
Does this potentially break existing translations ? (at first glance it looks like a non-translated string so it would be alright).
That said this is not really necessary, just a nice to have. If we have a lot of spare cycles I guess we can allow this, but otherwise I would just keep it out.
-- Thierry Carrez (ttx)
_______________________________________________ Openstack-stable-maint mailing list Openstack-stable-maint@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-stable-maint
I do not see a problem with approving this. I think that the issue is more with the patch of the driver - that is, the change in https://review.openstack.org/#/c/117144/3/nova/virt/hyperv/__init__.py
That's adding shortcut, previous path would still work, so it's backward compatbile. I'm +2, it's not risky and proposed by the driver maintainer, let's make their last wish (on Havana) true. Cheers, Alan
On 18 Sep 2014, at 19:44, Alan Pevec <apevec@gmail.com> wrote:
I do not see a problem with approving this. I think that the issue is more with the patch of the driver - that is, the change in https://review.openstack.org/#/c/117144/3/nova/virt/hyperv/__init__.py
That's adding shortcut, previous path would still work, so it's backward compatbile. I'm +2, it's not risky and proposed by the driver maintainer, let's make their last wish (on Havana) true.
Cool, I just wanted to have the last commit ever on Havana (kidding!). It’s just a matter of consistency in the driver class path option across versions, so that we don’t have to deal with users asking why the driver is not getting loaded when they copy config files acress releases. Thanks!! Alessandro
Cheers, Alan
_______________________________________________ Openstack-stable-maint mailing list Openstack-stable-maint@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-stable-maint
participants (5)
-
Alan Pevec
-
Alessandro Pilotti
-
Gary Kotton
-
Ihar Hrachyshka
-
Thierry Carrez