Re: [Openstack-stable-maint] [openstack-dev] stable/havana jobs failing due to keystone bug 1357652
2014-08-17 18:30 GMT+02:00 Nathan Kinder <nkinder@redhat.com>:
This requirement change was backported for stable/icehouse: https://review.openstack.org/#/c/112337/ It seems like the right thing to do is to propose a similar change for stable/havana instead of reverting the keystoneclient change.
We had similar issue last month, it's due to fact we test master clients against stable releases of services. Change is appropriate for stable because it changes test requirements, not runtime deps for the project itself: https://review.openstack.org/106974 Cheers, Alan
On 8/17/2014 3:22 PM, Alan Pevec wrote:
2014-08-17 18:30 GMT+02:00 Nathan Kinder <nkinder@redhat.com>:
This requirement change was backported for stable/icehouse: https://review.openstack.org/#/c/112337/ It seems like the right thing to do is to propose a similar change for stable/havana instead of reverting the keystoneclient change.
We had similar issue last month, it's due to fact we test master clients against stable releases of services. Change is appropriate for stable because it changes test requirements, not runtime deps for the project itself: https://review.openstack.org/106974
Cheers, Alan
_______________________________________________ Openstack-stable-maint mailing list Openstack-stable-maint@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-stable-maint
The other thing I thought was we could cap the version of python-keystoneclient in stable/havana, would that be bad? stable/havana is going to be end of life pretty soon anyway. -- Thanks, Matt Riedemann
2014-08-17 22:25 GMT+02:00 Matt Riedemann <mriedem@linux.vnet.ibm.com>:
The other thing I thought was we could cap the version of python-keystoneclient in stable/havana, would that be bad? stable/havana is going to be end of life pretty soon anyway.
No, we had cap on some clients and it was creating situations with conflicting requirements, last example was swiftclient<2. Another alternative was to start stable/* from clients but that was rejected in the past. Theory is that *clients are backward compatible but I'm not sure if addition of new dependencies was considered when decision to go with master-only clients was made. I think it's fine to add new test-requirements on stable, we should just somehow get an early warning that client change is going to break stable branch and update test-req preemptively. Cheers, Alan
On 8/17/2014 3:36 PM, Alan Pevec wrote:
2014-08-17 22:25 GMT+02:00 Matt Riedemann <mriedem@linux.vnet.ibm.com>:
The other thing I thought was we could cap the version of python-keystoneclient in stable/havana, would that be bad? stable/havana is going to be end of life pretty soon anyway.
No, we had cap on some clients and it was creating situations with conflicting requirements, last example was swiftclient<2. Another alternative was to start stable/* from clients but that was rejected in the past. Theory is that *clients are backward compatible but I'm not sure if addition of new dependencies was considered when decision to go with master-only clients was made.
I think it's fine to add new test-requirements on stable, we should just somehow get an early warning that client change is going to break stable branch and update test-req preemptively.
Cheers, Alan
OK, so here is where we appear to be: 1. We need the oslo.utils changes in python-keystoneclient reverted on master to get the stable/havana backports for global-requirements to pass Jenkins. The revert is here: https://review.openstack.org/#/q/status:open+project:openstack/python-keysto... 2. The backports for oslo.i18n and oslo.utils to stable/havana are here: https://review.openstack.org/#/q/status:open+project:openstack/requirements+... 3. Once 1 and 2 are done, we can restore the changes to python-keystoneclient on master. -- Thanks, Matt Riedemann
2014-08-17 22:58 GMT+02:00 Matt Riedemann <mriedem@linux.vnet.ibm.com>: ...
3. Once 1 and 2 are done, we can restore the changes to python-keystoneclient on master.
2.5 add oslo.utils in stable Keystone test-reqs: https://review.openstack.org/#/q/Ia29f69731d4dc79e8fc5d14afa932558de387799,n... BTW are Icehouse periodic jobs running? I don't see them listed in "Stable check of openstack/keystone failed" reports and this issue affects Icehouse Keystone too! Cheers, Alan
participants (2)
-
Alan Pevec
-
Matt Riedemann