Change in parameters in recent stable release patch
Hi stable maints, A change in parameters was backported a couple months ago to stable/icehouse: https://review.openstack.org/#/c/99692/4 As a reminder, we don't change parameters in stable patches to ensure backward compatibility in stable branches. -- Thierry Carrez (ttx)
Hi, My understanding was that this is backward compatible. If I missed something then humble apologies. Thanks Gary On 9/29/14, 10:35 AM, "Thierry Carrez" <thierry@openstack.org> wrote:
Hi stable maints,
A change in parameters was backported a couple months ago to stable/icehouse:
https://review.openstack.org/#/c/99692/4
As a reminder, we don't change parameters in stable patches to ensure backward compatibility in stable branches.
-- Thierry Carrez (ttx)
_______________________________________________ Openstack-stable-maint mailing list Openstack-stable-maint@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-stable-maint
This patch adds a new parameter and changes the internals of how another is handled, but there's no backwards incompatibility to the user-facing bits... as far as I can tell? I would have upvoted this backport myself, so if there's a backwards incompatibility that I'm overlooking here, I'd appreciate being enlightened. On Mon, Sep 29, 2014 at 3:22 AM, Gary Kotton <gkotton@vmware.com> wrote:
Hi, My understanding was that this is backward compatible. If I missed something then humble apologies. Thanks Gary
On 9/29/14, 10:35 AM, "Thierry Carrez" <thierry@openstack.org> wrote:
Hi stable maints,
A change in parameters was backported a couple months ago to stable/icehouse:
https://review.openstack.org/#/c/99692/4
As a reminder, we don't change parameters in stable patches to ensure backward compatibility in stable branches.
-- Thierry Carrez (ttx)
_______________________________________________ Openstack-stable-maint mailing list Openstack-stable-maint@lists.openstack.org
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-stable-maint
_______________________________________________ Openstack-stable-maint mailing list Openstack-stable-maint@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-stable-maint
Dolph Mathews wrote:
This patch adds a new parameter and changes the internals of how another is handled, but there's no backwards incompatibility to the user-facing bits... as far as I can tell?
I would have upvoted this backport myself, so if there's a backwards incompatibility that I'm overlooking here, I'd appreciate being enlightened.
My understanding is that it changes how the --vlan parameter is used. Previously it was used as vlan start, now it means vlan ID. This breaks scripts that made use of the --vlan parameter. Some users therefore had to adapt their scripts: https://github.com/bloomberg/chef-bcpc/commit/64f6962bd0067c8dcc1be4c3a7eda2... and were not very happy about it: https://twitter.com/jerenkrantz/status/516353673434497024 That's backwards incompatibility in my book... A better change would have been to keep --vlan as is, add --vlan-id and --vlan-start as a replacement, and start only documenting the latter set / deprecating the first set. That way you fix the issue without breaking existing users. -- Thierry Carrez (ttx)
My understanding is that it changes how the --vlan parameter is used. Previously it was used as vlan start, now it means vlan ID. This breaks scripts that made use of the --vlan parameter.
ok, let's discuss damage control: I guess reverting this in 2014.1.3 would just create more confusion? As a first step I've added it to relnotes, stealing Thierry's wording: https://wiki.openstack.org/wiki/ReleaseNotes/2014.1.2#Known_Issues_and_Limit... Any other suggestions? Cheers, Alan
Humble apologies for this. My bad! On 10/1/14, 2:42 PM, "Alan Pevec" <apevec@gmail.com> wrote:
My understanding is that it changes how the --vlan parameter is used. Previously it was used as vlan start, now it means vlan ID. This breaks scripts that made use of the --vlan parameter.
ok, let's discuss damage control: I guess reverting this in 2014.1.3 would just create more confusion? As a first step I've added it to relnotes, stealing Thierry's wording:
https://wiki.openstack.org/wiki/ReleaseNotes/2014.1.2#Known_Issues_and_Lim itations Any other suggestions?
Cheers, Alan
Alan Pevec wrote:
My understanding is that it changes how the --vlan parameter is used. Previously it was used as vlan start, now it means vlan ID. This breaks scripts that made use of the --vlan parameter.
ok, let's discuss damage control: I guess reverting this in 2014.1.3 would just create more confusion?
I agree that reverting would just add more breakage and confusion :)
As a first step I've added it to relnotes, stealing Thierry's wording: https://wiki.openstack.org/wiki/ReleaseNotes/2014.1.2#Known_Issues_and_Limit... Any other suggestions?
Nope, sounds good. -- Thierry Carrez (ttx)
participants (4)
-
Alan Pevec
-
Dolph Mathews
-
Gary Kotton
-
Thierry Carrez