Approval procedure
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512
Hi, I'm walking thru the list of stable backports for Neutron, and I've found an instance when a patch was pushed to gate by its author (or better, backporter) without receiving any feedback from other team members.
Let me remind you that (quoting [1]):
"Each backported commit proposed to gerrit should be reviewed and +2ed by two stable-maint members before it is approved. Where a stable-maint member has backported a fix, a single other +2 is sufficient for approval."
So please refrain from pushing patches before another maintainer checks your backport. Without following that rule, we miss opportunity for peer review.
[1]: https://wiki.openstack.org/wiki/StableBranch#Gerrit
Cheers, /Ihar
Which patch was this?
On 7/22/14, 2:37 PM, "Ihar Hrachyshka" ihrachys@redhat.com wrote:
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512
Hi, I'm walking thru the list of stable backports for Neutron, and I've found an instance when a patch was pushed to gate by its author (or better, backporter) without receiving any feedback from other team members.
Let me remind you that (quoting [1]):
"Each backported commit proposed to gerrit should be reviewed and +2ed by two stable-maint members before it is approved. Where a stable-maint member has backported a fix, a single other +2 is sufficient for approval."
So please refrain from pushing patches before another maintainer checks your backport. Without following that rule, we miss opportunity for peer review.
Cheers, /Ihar -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.22 (Darwin) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
iQEcBAEBCgAGBQJTzkziAAoJEC5aWaUY1u57yiEH/jc21KWveS4TUNkuFOJrSwfb cNjCW3c0QoRWDt4oyJ4edcqu6snwCkXOOpSGEsrprf3v/sqKsPhNQvyMGPKUSL6a QCrYXZFIx1WRFcR04a3zqLDWcuu3dUqz0BdJ38zoQTBOsvWJrtuuqdoTs0K/Niw7 bPEleyFO9MWW1FUt4wSb1GCK5KEkDzvGiY+poVk8p5CPbpJS8msIe8j6BNQFywDx 7OhyHA6IAQsiQANETvIF3ooVA2I/6jqtvaysI+qbh4qHuvUgRABcdOwh9mdG+rRd cs7bIjrU9+1hSfCMJbv1+d4O9I+VV3N1WZ2W0Yy57sS8kdvt7hbJIec+/s8y2f4= =NEGm -----END PGP SIGNATURE-----
Openstack-stable-maint mailing list Openstack-stable-maint@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-stable-maint
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512
I didn't really want to call out any names, but since you ask, those patches are here:
- - https://review.openstack.org/#/c/108534/ - - https://review.openstack.org/#/c/108533/ - - https://review.openstack.org/#/c/106199/
Probably other patches of the same author are of the same nature.
/Ihar
On 22/07/14 18:28, Gary Kotton wrote:
Which patch was this?
On 7/22/14, 2:37 PM, "Ihar Hrachyshka" ihrachys@redhat.com wrote:
Hi, I'm walking thru the list of stable backports for Neutron, and I've found an instance when a patch was pushed to gate by its author (or better, backporter) without receiving any feedback from other team members.
Let me remind you that (quoting [1]):
"Each backported commit proposed to gerrit should be reviewed and +2ed by two stable-maint members before it is approved. Where a stable-maint member has backported a fix, a single other +2 is sufficient for approval."
So please refrain from pushing patches before another maintainer checks your backport. Without following that rule, we miss opportunity for peer review.
Cheers, /Ihar
Openstack-stable-maint mailing list Openstack-stable-maint@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-stable-maint
Hi Ihar,
I had directly approved those patches as they were just reviewed and merged into master (they were also pretty trivial bugs imo). I'll wait for another +2 though in the future.
Best,
Aaron
On Tue, Jul 22, 2014 at 10:07 AM, Ihar Hrachyshka ihrachys@redhat.com wrote:
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512
I didn't really want to call out any names, but since you ask, those patches are here:
Probably other patches of the same author are of the same nature.
/Ihar
On 22/07/14 18:28, Gary Kotton wrote:
Which patch was this?
On 7/22/14, 2:37 PM, "Ihar Hrachyshka" ihrachys@redhat.com wrote:
Hi, I'm walking thru the list of stable backports for Neutron, and I've found an instance when a patch was pushed to gate by its author (or better, backporter) without receiving any feedback from other team members.
Let me remind you that (quoting [1]):
"Each backported commit proposed to gerrit should be reviewed and +2ed by two stable-maint members before it is approved. Where a stable-maint member has backported a fix, a single other +2 is sufficient for approval."
So please refrain from pushing patches before another maintainer checks your backport. Without following that rule, we miss opportunity for peer review.
Cheers, /Ihar
Openstack-stable-maint mailing list Openstack-stable-maint@lists.openstack.org
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-stable-maint
-----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.22 (Darwin) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
iQEcBAEBCgAGBQJTzpo5AAoJEC5aWaUY1u57ZAEH/i3GTKkt7y4CvhmcAxvMUvJd ldm4ewrriTfFbsptvZzRSHMzdE6U+XBKS19NXmWZ8EjgGisNIKSxZSTA07JNsUUa er+rPYLUNZhyiQQ/0hUrksYEmyyILnzBA+Q3S7GMEejwUz2k58/t8QjRmXDv8sUT XEZ/Yv6GF0ggHtrTT2DkBWuz+UmgIWSQGXNEuYgjSNLKfSRaSebhuJ+1cV4/ypx9 8KUn2EfAy1+WVdbVVCq7X0t17zbtX+ciz/BDJjyNNuhQmqXPMldbCcDIYA4aEK0u dM0RBsCZLH2UorUrUcxlePGRHTSlITN7ho//ASaP7Byz57xi0F0SbGEzcBYrMD0= =3osn -----END PGP SIGNATURE-----
Openstack-stable-maint mailing list Openstack-stable-maint@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-stable-maint
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512
On 23/07/14 00:03, Aaron Rosen wrote:
Hi Ihar,
I had directly approved those patches as they were just reviewed and merged into master (they were also pretty trivial bugs imo). I'll wait for another +2 though in the future.
Not everything from master belongs to stable branches though, and there is a reason why stable maintainers' team is different from per-project core team.
I hope that Neutron backports will get more love from now on, so feedback should not take too much time and block valuable bug fixes.
And thanks for considering my argument.
/Ihar
Best,
Aaron
On Tue, Jul 22, 2014 at 10:07 AM, Ihar Hrachyshka <ihrachys@redhat.com mailto:ihrachys@redhat.com> wrote:
I didn't really want to call out any names, but since you ask, those patches are here:
https://review.openstack.org/#/c/108533/ - https://review.openstack.org/#/c/106199/
Probably other patches of the same author are of the same nature.
/Ihar
On 22/07/14 18:28, Gary Kotton wrote:
Which patch was this?
On 7/22/14, 2:37 PM, "Ihar Hrachyshka" <ihrachys@redhat.com
wrote:
Hi, I'm walking thru the list of stable backports for Neutron, and I've found an instance when a patch was pushed to gate by its author (or better, backporter) without receiving any feedback from other team members.
Let me remind you that (quoting [1]):
"Each backported commit proposed to gerrit should be reviewed and +2ed by two stable-maint members before it is approved. Where a stable-maint member has backported a fix, a single other +2 is sufficient for approval."
So please refrain from pushing patches before another maintainer checks your backport. Without following that rule, we miss opportunity for peer review.
Cheers, /Ihar
Openstack-stable-maint mailing list Openstack-stable-maint@lists.openstack.org
mailto:Openstack-stable-maint@lists.openstack.org
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-stable-maint
Openstack-stable-maint mailing list Openstack-stable-maint@lists.openstack.org mailto:Openstack-stable-maint@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-stable-maint
On 7/23/14, 11:41 AM, "Ihar Hrachyshka" ihrachys@redhat.com wrote:
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512
On 23/07/14 00:03, Aaron Rosen wrote:
Hi Ihar,
I had directly approved those patches as they were just reviewed and merged into master (they were also pretty trivial bugs imo). I'll wait for another +2 though in the future.
Not everything from master belongs to stable branches though, and there is a reason why stable maintainers' team is different from per-project core team.
The patches above were something that was needed to get into the stable version. The problem with the stable version at the moment is that patches are back ported (which are fixing issues that break open stack) and these are not being reviewed.
I think that in this case Aaron took the initiative and pushed code that was an important fix.
It would be nice if we were all involved in getting he stable review cadence back again. If not then we really need to reevaluate the situation.
A luta continua
I hope that Neutron backports will get more love from now on, so feedback should not take too much time and block valuable bug fixes.
And thanks for considering my argument.
/Ihar
Best,
Aaron
On Tue, Jul 22, 2014 at 10:07 AM, Ihar Hrachyshka <ihrachys@redhat.com mailto:ihrachys@redhat.com> wrote:
I didn't really want to call out any names, but since you ask, those patches are here:
https://review.openstack.org/#/c/108533/ - https://review.openstack.org/#/c/106199/
Probably other patches of the same author are of the same nature.
/Ihar
On 22/07/14 18:28, Gary Kotton wrote:
Which patch was this?
On 7/22/14, 2:37 PM, "Ihar Hrachyshka" <ihrachys@redhat.com
wrote:
Hi, I'm walking thru the list of stable backports for Neutron, and I've found an instance when a patch was pushed to gate by its author (or better, backporter) without receiving any feedback from other team members.
Let me remind you that (quoting [1]):
"Each backported commit proposed to gerrit should be reviewed and +2ed by two stable-maint members before it is approved. Where a stable-maint member has backported a fix, a single other +2 is sufficient for approval."
So please refrain from pushing patches before another maintainer checks your backport. Without following that rule, we miss opportunity for peer review.
Cheers, /Ihar
Openstack-stable-maint mailing list Openstack-stable-maint@lists.openstack.org
mailto:Openstack-stable-maint@lists.openstack.org
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-stable-main t
Openstack-stable-maint mailing list Openstack-stable-maint@lists.openstack.org mailto:Openstack-stable-maint@lists.openstack.org
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-stable-main t
-----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.22 (Darwin) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
iQEcBAEBCgAGBQJTz3UuAAoJEC5aWaUY1u572RYIAIw7wJkRxmKXILMoA6BkrCE/ 8Jt04FEuiKPW+7jZ/UgTbZCAyzjWuB7bUkPCYy9ITHQ9m8KaD9hsjyyGRwiLs8P1 y0TLwmNVq3b7lTn+qFGnCAHtKozv7t7qTn5HXyIf/v3JYiYCHUBlfT5XDyLqos7X mtRIUzBJj6zVnKkgjJS5FQVWbw7ZWzi7lLX+bEUTDT9YROnM1SlOzHPOAg2P6M7V 1p8EPewBlxdoI6/D7LJQraP4KPc4ijY0wNju11VKUjYd21nWI1kWCgWFlql7z1wv 0auGknz4RI/T2H9zK3CP87kZLAm9FSd+BNbaUhjSl9fmm6sAq0WDoUm30zVD4og= =zixh -----END PGP SIGNATURE-----
participants (3)
-
Aaron Rosen
-
Gary Kotton
-
Ihar Hrachyshka