-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512
On 23/07/14 00:03, Aaron Rosen wrote:
Hi Ihar,
I had directly approved those patches as they were just reviewed and merged into master (they were also pretty trivial bugs imo). I'll wait for another +2 though in the future.
Not everything from master belongs to stable branches though, and there is a reason why stable maintainers' team is different from per-project core team.
I hope that Neutron backports will get more love from now on, so feedback should not take too much time and block valuable bug fixes.
And thanks for considering my argument.
/Ihar
Best,
Aaron
On Tue, Jul 22, 2014 at 10:07 AM, Ihar Hrachyshka <ihrachys@redhat.com mailto:ihrachys@redhat.com> wrote:
I didn't really want to call out any names, but since you ask, those patches are here:
https://review.openstack.org/#/c/108533/ - https://review.openstack.org/#/c/106199/
Probably other patches of the same author are of the same nature.
/Ihar
On 22/07/14 18:28, Gary Kotton wrote:
Which patch was this?
On 7/22/14, 2:37 PM, "Ihar Hrachyshka" <ihrachys@redhat.com
wrote:
Hi, I'm walking thru the list of stable backports for Neutron, and I've found an instance when a patch was pushed to gate by its author (or better, backporter) without receiving any feedback from other team members.
Let me remind you that (quoting [1]):
"Each backported commit proposed to gerrit should be reviewed and +2ed by two stable-maint members before it is approved. Where a stable-maint member has backported a fix, a single other +2 is sufficient for approval."
So please refrain from pushing patches before another maintainer checks your backport. Without following that rule, we miss opportunity for peer review.
Cheers, /Ihar
Openstack-stable-maint mailing list Openstack-stable-maint@lists.openstack.org
mailto:Openstack-stable-maint@lists.openstack.org
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-stable-maint
Openstack-stable-maint mailing list Openstack-stable-maint@lists.openstack.org mailto:Openstack-stable-maint@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-stable-maint