Dolph Mathews wrote:
This patch adds a new parameter and changes the internals of how another is handled, but there's no backwards incompatibility to the user-facing bits... as far as I can tell?
I would have upvoted this backport myself, so if there's a backwards incompatibility that I'm overlooking here, I'd appreciate being enlightened.
My understanding is that it changes how the --vlan parameter is used. Previously it was used as vlan start, now it means vlan ID. This breaks scripts that made use of the --vlan parameter. Some users therefore had to adapt their scripts: https://github.com/bloomberg/chef-bcpc/commit/64f6962bd0067c8dcc1be4c3a7eda2... and were not very happy about it: https://twitter.com/jerenkrantz/status/516353673434497024 That's backwards incompatibility in my book... A better change would have been to keep --vlan as is, add --vlan-id and --vlan-start as a replacement, and start only documenting the latter set / deprecating the first set. That way you fix the issue without breaking existing users. -- Thierry Carrez (ttx)