-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512 I didn't really want to call out any names, but since you ask, those patches are here: - - https://review.openstack.org/#/c/108534/ - - https://review.openstack.org/#/c/108533/ - - https://review.openstack.org/#/c/106199/ Probably other patches of the same author are of the same nature. /Ihar On 22/07/14 18:28, Gary Kotton wrote:
Which patch was this?
On 7/22/14, 2:37 PM, "Ihar Hrachyshka" <ihrachys@redhat.com> wrote:
Hi, I'm walking thru the list of stable backports for Neutron, and I've found an instance when a patch was pushed to gate by its author (or better, backporter) without receiving any feedback from other team members.
Let me remind you that (quoting [1]):
"Each backported commit proposed to gerrit should be reviewed and +2ed by two stable-maint members before it is approved. Where a stable-maint member has backported a fix, a single other +2 is sufficient for approval."
So please refrain from pushing patches before another maintainer checks your backport. Without following that rule, we miss opportunity for peer review.
[1]: https://wiki.openstack.org/wiki/StableBranch#Gerrit
Cheers, /Ihar
_______________________________________________ Openstack-stable-maint mailing list Openstack-stable-maint@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-stable-maint
-----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.22 (Darwin) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCgAGBQJTzpo5AAoJEC5aWaUY1u57ZAEH/i3GTKkt7y4CvhmcAxvMUvJd ldm4ewrriTfFbsptvZzRSHMzdE6U+XBKS19NXmWZ8EjgGisNIKSxZSTA07JNsUUa er+rPYLUNZhyiQQ/0hUrksYEmyyILnzBA+Q3S7GMEejwUz2k58/t8QjRmXDv8sUT XEZ/Yv6GF0ggHtrTT2DkBWuz+UmgIWSQGXNEuYgjSNLKfSRaSebhuJ+1cV4/ypx9 8KUn2EfAy1+WVdbVVCq7X0t17zbtX+ciz/BDJjyNNuhQmqXPMldbCcDIYA4aEK0u dM0RBsCZLH2UorUrUcxlePGRHTSlITN7ho//ASaP7Byz57xi0F0SbGEzcBYrMD0= =3osn -----END PGP SIGNATURE-----