Re: [Openstack-i18n] Wrong plural formula for russian
Dear Daisy, Akihiro, Alex, thank you very much for your investigation and fix of this issue. Kind regards. Ilya Alekseyev 2016-03-15 10:14 GMT+03:00 Ying Chun Guo <guoyingc@cn.ibm.com>:
I think you are right. plural can be only set once. After setting, it's not able to change.
python-neutronclient is fixed.
Best regards Ying Chun Guo (Daisy)
Akihiro Motoki <amotoki@gmail.com> wrote on 03/14/2016 07:21:10 PM:
From: Akihiro Motoki <amotoki@gmail.com> To: Ying Chun Guo/China/IBM@IBMCN Cc: Alex Eng <aeng@redhat.com>, Ilya Alekseyev <ilyaalekseyev@acm.org>, "openstack-i18n@lists.openstack.org" <openstack-i18n@lists.openstack.org> Date: 03/14/2016 07:22 PM Subject: Re: [Openstack-i18n] Wrong plural formula for russian
Hi Daisy,
Hi, Akihiro
I tried to upload a new Russian translation file with the correct
2016-03-14 17:33 GMT+09:00 Ying Chun Guo <guoyingc@cn.ibm.com>: plural
formula to django-openstack-auth. And then I downloaded it. Yet the header is not changed at all. I'm afraid uploading po files will not change the header.
I made some tests with nplurals. My conclusion is that Zanata allows to update nplurals ONLY ONCE. I succeed to change nplural to 2 by putting japanese PO file, but once it was changed, even though I put Japanese PO file with nplural==1, nplural was not changed.
I tested it using neutronclient Japanese. As an unfortunate result, Japanese resource in neutronclient now have the wrong nplurals (2). Could you reset neutronclient in Japanese? (There is no translation in neutronclient, so we can do this more easily :-)
Thanks, Akihiro
Best regards Ying Chun Guo (Daisy)
Akihiro Motoki <amotoki@gmail.com> wrote on 03/12/2016 09:13:09 PM:
From: Akihiro Motoki <amotoki@gmail.com> To: Ying Chun Guo/China/IBM@IBMCN Cc: Alex Eng <aeng@redhat.com>, Ilya Alekseyev <ilyaalekseyev@acm.org>, "openstack-i18n@lists.openstack.org" <openstack-i18n@lists.openstack.org> Date: 03/12/2016 09:14 PM Subject: Re: [Openstack-i18n] Wrong plural formula for russian
Hi Daisy, Alex,
I think the steps Daisy describes is the last resort. Regarding translation statistics, I have nothing to say as I don't know any about stats.
There are a couple of things I would like to note.
* It is better to first try to upload Russian PO files with
even though you failed it last time. * We need to check other Russian resources other than Horizon. I checked django-openstack-auth and nova and they have nplurals=4. There might be more. At now only Horizon and dashboard-related projects use plural cases, so we see this issue only in Horizon now.
Akihiro
2016-03-11 14:20 GMT+09:00 Ying Chun Guo <guoyingc@cn.ibm.com>:
Thank you for the investigation, Akihiro and Alex.
Below are the steps we previously used. We can follow the same steps, just changing "stable" version to "master" version. I think the statistic data will not be affected in step 1 to 5. But, if we delete master-old, the contribution data in master-old will be removed. So my suggestion is to do the same steps, and keep master-old version (mark it as readonly) till 6 month or 12 month later when the contribution data is not
nplurals=3 that
important.
1. Create Russian translation files with only the correct header and the pluralities translation items. 2. Create a new version named as russian-fix 3. Upload the source files and the Russian translation files created in #1 to the version russian-fix 4. Merge the stable version with version russian-fix 5. Rename stable version to stable-old, and rename russian-fix to stable.
Alex and Akihiro, please confirm my proposal. Then I can take actions.
Best regards Ying Chun Guo (Daisy)
Alex Eng <aeng@redhat.com> wrote on 2016/03/11 04:36:15:
From: Alex Eng <aeng@redhat.com> To: Ilya Alekseyev <ilyaalekseyev@acm.org> Cc: Akihiro Motoki <amotoki@gmail.com>, Ying Chun Guo/China/ IBM@IBMCN, "openstack-i18n@lists.openstack.org" <openstack- i18n@lists.openstack.org> Date: 2016/03/11 04:37 Subject: Re: [Openstack-i18n] Wrong plural formula for russian
Hi,
If we fix the plural forms in pot file and push to Zanata, that would not affect the statistics.
But I remember last time when we trying to fix this, there are
some
limitation of the pluralform wont update after the file is being uploaded once to Zanata. And we have to create a new version with fixed pot file and use "merge translation" feature to bring over all the translations.
We can do the same thing again and the statistics won't be affected. (copied translation doesn't count in as contribution)
I checked and Zanata has the correct form.
nplurals=3; plural=(n%10==1 && n%100!=11 ? 0 : n%10>=2 && n%10<=4 && (n%100<10 || n%100>=20) ? 1 : 2)
---------------------------------------------
Alex Eng Senior Software Engineer Globalisation Tools Engineering DID: +61 3514 8262 Mobile: +614 2335 3457
Red Hat, Asia-Pacific Pty Ltd Level 1, 193 North Quay Brisbane 4000 Office: +61 7 3514 8100 Fax: +61 7 3514 8199 Website: www.redhat.com
On Fri, Mar 11, 2016 at 3:00 AM, Ilya Alekseyev <ilyaalekseyev@acm.org> wrote: Daisy,
i remember we fixed this for Liberty. But looks like somewhere wrong config or error in script that creating master version. How ca we fix it? How i can help with this issue?
Alex, is it possible to fix plural formula ofr version and keep statistics safe?
We need to fix it as soon as possible, because 4 plural forms making issues for russian translation (empty message, empty buttons, etc, as we can seee in Kilo release).
Kind regards, Ilya Alekseyev.
С уважением, Илья Алексеев
Russian OpenStack Community
2016-03-10 19:37 GMT+03:00 Akihiro Motoki <amotoki@gmail.com>: Russian translations in the horizon repo is downloaded from Zanata, OpenStack translation platform. It seems Zanata has wrong plural configuration.
> Daisy, Alex, Could you check Russian configuration in Zanata is correct?
2016-03-10 22:42 GMT+09:00 Ilya Alekseyev <ilyaalekseyev@acm.org>: > Dear collegues, > > i've checked current russian translation in horizon repository and find > out > that we have wrong plural formula in upstream. > > https://github.com/openstack/horizon/blob/master/ openstack_dashboard/locale/ru/LC_MESSAGES/django.po#L35-L37 > > There is only 3 plural forms in Russian. > And correct formula should be > nplurals=3; plural=(n%10==1 && n%100!=11 ? 0 : n%10>=2 && n%10<=4 && > (n%100<10 || n%100>=20) ? 1 : 2); > > Looks like some script is wrong. > Does anybody know how to fix it? > > Kind regards, > Ilya Alekseyev > > _______________________________________________ > Openstack-i18n mailing list > Openstack-i18n@lists.openstack.org > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-i18n >
participants (1)
-
Ilya Alekseyev