How is openstack-manuals/common-rst updated?
Hi team, During translation of common-rst in Zanata, I found a bit odd entries in openstack-manuals/doc/common-rst/source/locale/common-rst.pot. When and how is openstack-manuals/common-rst updated? For example, we see the following in common-rst.pot: --- #: ../common/app_support.rst:3 msgid "Community support" msgstr "" #: ../common/app_support.rst:5 msgid "Community Support" msgstr "" ---- However, we actually have only the first entry in common-rst/*.rst: --- $ grep -r 'Community Support' doc/common-rst/*.rst $ grep -r 'Community support' doc/common-rst/*.rst doc/common-rst/app_support.rst:Community support --- If you look at app_support.rst, we have only the first one. Where does the second one come from? In tools/generatepot-rst.sh, processing on 'common-rst' is skipped. I wonder which script we update common-rst.pot. Thanks, Akihiro
On 10/15/2015 07:02 PM, Akihiro Motoki wrote:
Hi team,
During translation of common-rst in Zanata, I found a bit odd entries in openstack-manuals/doc/common-rst/source/locale/common-rst.pot.
When and how is openstack-manuals/common-rst updated?
For example, we see the following in common-rst.pot: --- #: ../common/app_support.rst:3 msgid "Community support" msgstr ""
#: ../common/app_support.rst:5 msgid "Community Support" msgstr "" ----
However, we actually have only the first entry in common-rst/*.rst: --- $ grep -r 'Community Support' doc/common-rst/*.rst $ grep -r 'Community support' doc/common-rst/*.rst doc/common-rst/app_support.rst:Community support ---
If you look at app_support.rst, we have only the first one. Where does the second one come from?
In tools/generatepot-rst.sh, processing on 'common-rst' is skipped. I wonder which script we update common-rst.pot.
generatepot-rst.sh generates the file in every invocation, just run "tox -e generatepot-rst -- user-guide" A git status afterwards will show: ... modified: doc/common-rst/source/locale/common-rst.pot modified: doc/user-guide/source/locale/user-guide.pot Just the invocation " tox -e generatepot-rst -- common-rst" is skipped Still that does not answer your initial question why the line is there twice. Debugging is welcome, Andreas -- Andreas Jaeger aj@{suse.com,opensuse.org} Twitter/Identica: jaegerandi SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg) GPG fingerprint = 93A3 365E CE47 B889 DF7F FED1 389A 563C C272 A126
Thanks Andreas, It seems I ran "tox -e generatepot-rst" on an unrelated doc. Now it works. Regarding the problem that I see obsolete strings in the common-rst pot, I will investigate more. There is no need to rush, but it is worth fixed soon. Akihiro 2015-10-16 2:24 GMT+09:00 Andreas Jaeger <aj@suse.com>:
On 10/15/2015 07:02 PM, Akihiro Motoki wrote:
Hi team,
During translation of common-rst in Zanata, I found a bit odd entries in openstack-manuals/doc/common-rst/source/locale/common-rst.pot.
When and how is openstack-manuals/common-rst updated?
For example, we see the following in common-rst.pot: --- #: ../common/app_support.rst:3 msgid "Community support" msgstr ""
#: ../common/app_support.rst:5 msgid "Community Support" msgstr "" ----
However, we actually have only the first entry in common-rst/*.rst: --- $ grep -r 'Community Support' doc/common-rst/*.rst $ grep -r 'Community support' doc/common-rst/*.rst doc/common-rst/app_support.rst:Community support ---
If you look at app_support.rst, we have only the first one. Where does the second one come from?
In tools/generatepot-rst.sh, processing on 'common-rst' is skipped. I wonder which script we update common-rst.pot.
generatepot-rst.sh generates the file in every invocation, just run "tox -e generatepot-rst -- user-guide"
A git status afterwards will show: ... modified: doc/common-rst/source/locale/common-rst.pot modified: doc/user-guide/source/locale/user-guide.pot
Just the invocation " tox -e generatepot-rst -- common-rst" is skipped
Still that does not answer your initial question why the line is there twice. Debugging is welcome,
Andreas -- Andreas Jaeger aj@{suse.com,opensuse.org} Twitter/Identica: jaegerandi SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg) GPG fingerprint = 93A3 365E CE47 B889 DF7F FED1 389A 563C C272 A126
Hi Akihiro, Andreas, Ahhhhhh... this must be a bug (I made...). Cause: The tool is simply adding the new strings to common-rst [1]. So, the unused strings are remaining... Background (from my understand): Each document uses the common contents. However, each document has the different exclude_patterns, because Sphinx warns if there are unused files. Therefore, each document has a partial common-rst file, not a whole common-rst. Solution: ... I don't have a good idea as of now... Add a new document that contains all common file? OpenStack Common Guide (dummy, just to create pot file :) I will re-consider the situation. Any idea is welcome. Regards, KATO Tomoyuki [1] https://github.com/openstack/openstack-manuals/blob/master/tools/generatepot... [2] https://github.com/openstack/openstack-manuals/blob/master/doc/install-guide...
Thanks Andreas,
It seems I ran "tox -e generatepot-rst" on an unrelated doc. Now it works.
Regarding the problem that I see obsolete strings in the common-rst pot, I will investigate more. There is no need to rush, but it is worth fixed soon.
Akihiro
2015-10-16 2:24 GMT+09:00 Andreas Jaeger <aj@suse.com>:
On 10/15/2015 07:02 PM, Akihiro Motoki wrote:
Hi team,
During translation of common-rst in Zanata, I found a bit odd entries in openstack-manuals/doc/common-rst/source/locale/common-rst.pot.
When and how is openstack-manuals/common-rst updated?
For example, we see the following in common-rst.pot: --- #: ../common/app_support.rst:3 msgid "Community support" msgstr ""
#: ../common/app_support.rst:5 msgid "Community Support" msgstr "" ----
However, we actually have only the first entry in common-rst/*.rst: --- $ grep -r 'Community Support' doc/common-rst/*.rst $ grep -r 'Community support' doc/common-rst/*.rst doc/common-rst/app_support.rst:Community support ---
If you look at app_support.rst, we have only the first one. Where does the second one come from?
In tools/generatepot-rst.sh, processing on 'common-rst' is skipped. I wonder which script we update common-rst.pot.
generatepot-rst.sh generates the file in every invocation, just run "tox -e generatepot-rst -- user-guide"
A git status afterwards will show: ... modified: doc/common-rst/source/locale/common-rst.pot modified: doc/user-guide/source/locale/user-guide.pot
Just the invocation " tox -e generatepot-rst -- common-rst" is skipped
Still that does not answer your initial question why the line is there twice. Debugging is welcome,
Andreas -- Andreas Jaeger aj@{suse.com,opensuse.org} Twitter/Identica: jaegerandi SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg) GPG fingerprint = 93A3 365E CE47 B889 DF7F FED1 389A 563C C272 A126
2015-10-16 7:45 GMT+09:00 KATO Tomoyuki <tomo@dream.daynight.jp>:
Hi Akihiro, Andreas,
Ahhhhhh... this must be a bug (I made...).
Cause: The tool is simply adding the new strings to common-rst [1]. So, the unused strings are remaining...
Background (from my understand): Each document uses the common contents. However, each document has the different exclude_patterns, because Sphinx warns if there are unused files. Therefore, each document has a partial common-rst file, not a whole common-rst.
Is it applied to sphinx-build -b gettext? As far as I tested on documents using RST in openstack-manuals, there is no warning. tox -e generatepot-rst -- user-guide or others. I just proposed https://review.openstack.org/235611 Doesn't it work? Akihiro
Solution: ... I don't have a good idea as of now... Add a new document that contains all common file? OpenStack Common Guide (dummy, just to create pot file :)
I will re-consider the situation. Any idea is welcome.
Regards, KATO Tomoyuki
[1] https://github.com/openstack/openstack-manuals/blob/master/tools/generatepot... [2] https://github.com/openstack/openstack-manuals/blob/master/doc/install-guide...
Thanks Andreas,
It seems I ran "tox -e generatepot-rst" on an unrelated doc. Now it works.
Regarding the problem that I see obsolete strings in the common-rst pot, I will investigate more. There is no need to rush, but it is worth fixed soon.
Akihiro
2015-10-16 2:24 GMT+09:00 Andreas Jaeger <aj@suse.com>:
On 10/15/2015 07:02 PM, Akihiro Motoki wrote:
Hi team,
During translation of common-rst in Zanata, I found a bit odd entries in openstack-manuals/doc/common-rst/source/locale/common-rst.pot.
When and how is openstack-manuals/common-rst updated?
For example, we see the following in common-rst.pot: --- #: ../common/app_support.rst:3 msgid "Community support" msgstr ""
#: ../common/app_support.rst:5 msgid "Community Support" msgstr "" ----
However, we actually have only the first entry in common-rst/*.rst: --- $ grep -r 'Community Support' doc/common-rst/*.rst $ grep -r 'Community support' doc/common-rst/*.rst doc/common-rst/app_support.rst:Community support ---
If you look at app_support.rst, we have only the first one. Where does the second one come from?
In tools/generatepot-rst.sh, processing on 'common-rst' is skipped. I wonder which script we update common-rst.pot.
generatepot-rst.sh generates the file in every invocation, just run "tox -e generatepot-rst -- user-guide"
A git status afterwards will show: ... modified: doc/common-rst/source/locale/common-rst.pot modified: doc/user-guide/source/locale/user-guide.pot
Just the invocation " tox -e generatepot-rst -- common-rst" is skipped
Still that does not answer your initial question why the line is there twice. Debugging is welcome,
Andreas -- Andreas Jaeger aj@{suse.com,opensuse.org} Twitter/Identica: jaegerandi SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg) GPG fingerprint = 93A3 365E CE47 B889 DF7F FED1 389A 563C C272 A126
On 10/16/2015 12:45 AM, KATO Tomoyuki wrote:
Hi Akihiro, Andreas,
Ahhhhhh... this must be a bug (I made...).
Cause: The tool is simply adding the new strings to common-rst [1]. So, the unused strings are remaining...
Background (from my understand): Each document uses the common contents. However, each document has the different exclude_patterns, because Sphinx warns if there are unused files.
Ah, the exclude_patterns - indeed that will be a challenge why we need to collect these.
Therefore, each document has a partial common-rst file, not a whole common-rst.
Solution: ... I don't have a good idea as of now... Add a new document that contains all common file? OpenStack Common Guide (dummy, just to create pot file :)
Perhaps. Or delete before we start the common-rst pot file and then collect all content?
I will re-consider
I fear we need to revert Akihiro's patch that I +2ed. Thanks all for looking into this, Andreas the situation.
Any idea is welcome.
Regards, KATO Tomoyuki
[1] https://github.com/openstack/openstack-manuals/blob/master/tools/generatepot... [2] https://github.com/openstack/openstack-manuals/blob/master/doc/install-guide...
Thanks Andreas,
It seems I ran "tox -e generatepot-rst" on an unrelated doc. Now it works.
Regarding the problem that I see obsolete strings in the common-rst pot, I will investigate more. There is no need to rush, but it is worth fixed soon.
Akihiro
2015-10-16 2:24 GMT+09:00 Andreas Jaeger <aj@suse.com>:
On 10/15/2015 07:02 PM, Akihiro Motoki wrote:
Hi team,
During translation of common-rst in Zanata, I found a bit odd entries in openstack-manuals/doc/common-rst/source/locale/common-rst.pot.
When and how is openstack-manuals/common-rst updated?
For example, we see the following in common-rst.pot: --- #: ../common/app_support.rst:3 msgid "Community support" msgstr ""
#: ../common/app_support.rst:5 msgid "Community Support" msgstr "" ----
However, we actually have only the first entry in common-rst/*.rst: --- $ grep -r 'Community Support' doc/common-rst/*.rst $ grep -r 'Community support' doc/common-rst/*.rst doc/common-rst/app_support.rst:Community support ---
If you look at app_support.rst, we have only the first one. Where does the second one come from?
In tools/generatepot-rst.sh, processing on 'common-rst' is skipped. I wonder which script we update common-rst.pot.
generatepot-rst.sh generates the file in every invocation, just run "tox -e generatepot-rst -- user-guide"
A git status afterwards will show: ... modified: doc/common-rst/source/locale/common-rst.pot modified: doc/user-guide/source/locale/user-guide.pot
Just the invocation " tox -e generatepot-rst -- common-rst" is skipped
Still that does not answer your initial question why the line is there twice. Debugging is welcome,
Andreas -- Andreas Jaeger aj@{suse.com,opensuse.org} Twitter/Identica: jaegerandi SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg) GPG fingerprint = 93A3 365E CE47 B889 DF7F FED1 389A 563C C272 A126
_______________________________________________ OpenStack-docs mailing list OpenStack-docs@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-docs
-- Andreas Jaeger aj@{suse.com,opensuse.org} Twitter/Identica: jaegerandi SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg) GPG fingerprint = 93A3 365E CE47 B889 DF7F FED1 389A 563C C272 A126
Thanks for finding it. I thought I tested all of RST docs but I might be missing something. My vote is to create a dummy document which covers all common RST files and that generatepot-rst for other books does not touch common-rst.pot. Akihiro 2015-10-16 18:04 GMT+09:00 Andreas Jaeger <aj@suse.com>:
On 10/16/2015 12:45 AM, KATO Tomoyuki wrote:
Hi Akihiro, Andreas,
Ahhhhhh... this must be a bug (I made...).
Cause: The tool is simply adding the new strings to common-rst [1]. So, the unused strings are remaining...
Background (from my understand): Each document uses the common contents. However, each document has the different exclude_patterns, because Sphinx warns if there are unused files.
Ah, the exclude_patterns - indeed that will be a challenge why we need to collect these.
Therefore, each document has a partial common-rst file, not a whole common-rst.
Solution: ... I don't have a good idea as of now... Add a new document that contains all common file? OpenStack Common Guide (dummy, just to create pot file :)
Perhaps. Or delete before we start the common-rst pot file and then collect all content?
I will re-consider
I fear we need to revert Akihiro's patch that I +2ed.
Thanks all for looking into this,
Andreas
the situation.
Any idea is welcome.
Regards, KATO Tomoyuki
[1] https://github.com/openstack/openstack-manuals/blob/master/tools/generatepot... [2] https://github.com/openstack/openstack-manuals/blob/master/doc/install-guide...
Thanks Andreas,
It seems I ran "tox -e generatepot-rst" on an unrelated doc. Now it works.
Regarding the problem that I see obsolete strings in the common-rst pot, I will investigate more. There is no need to rush, but it is worth fixed soon.
Akihiro
2015-10-16 2:24 GMT+09:00 Andreas Jaeger <aj@suse.com>:
On 10/15/2015 07:02 PM, Akihiro Motoki wrote:
Hi team,
During translation of common-rst in Zanata, I found a bit odd entries in openstack-manuals/doc/common-rst/source/locale/common-rst.pot.
When and how is openstack-manuals/common-rst updated?
For example, we see the following in common-rst.pot: --- #: ../common/app_support.rst:3 msgid "Community support" msgstr ""
#: ../common/app_support.rst:5 msgid "Community Support" msgstr "" ----
However, we actually have only the first entry in common-rst/*.rst: --- $ grep -r 'Community Support' doc/common-rst/*.rst $ grep -r 'Community support' doc/common-rst/*.rst doc/common-rst/app_support.rst:Community support ---
If you look at app_support.rst, we have only the first one. Where does the second one come from?
In tools/generatepot-rst.sh, processing on 'common-rst' is skipped. I wonder which script we update common-rst.pot.
generatepot-rst.sh generates the file in every invocation, just run "tox -e generatepot-rst -- user-guide"
A git status afterwards will show: ... modified: doc/common-rst/source/locale/common-rst.pot modified: doc/user-guide/source/locale/user-guide.pot
Just the invocation " tox -e generatepot-rst -- common-rst" is skipped
Still that does not answer your initial question why the line is there twice. Debugging is welcome,
Andreas -- Andreas Jaeger aj@{suse.com,opensuse.org} Twitter/Identica: jaegerandi SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg) GPG fingerprint = 93A3 365E CE47 B889 DF7F FED1 389A 563C C272 A126
_______________________________________________ OpenStack-docs mailing list OpenStack-docs@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-docs
-- Andreas Jaeger aj@{suse.com,opensuse.org} Twitter/Identica: jaegerandi SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg) GPG fingerprint = 93A3 365E CE47 B889 DF7F FED1 389A 563C C272 A126
I filed a bug on this. https://bugs.launchpad.net/openstack-manuals/+bug/1507138 I am working on a solution to create a document which covers all files under common-rsrt. I can upload my idea for review soon. Akihiro 2015-10-16 18:16 GMT+09:00 Akihiro Motoki <amotoki@gmail.com>:
Thanks for finding it. I thought I tested all of RST docs but I might be missing something.
My vote is to create a dummy document which covers all common RST files and that generatepot-rst for other books does not touch common-rst.pot.
Akihiro
2015-10-16 18:04 GMT+09:00 Andreas Jaeger <aj@suse.com>:
On 10/16/2015 12:45 AM, KATO Tomoyuki wrote:
Hi Akihiro, Andreas,
Ahhhhhh... this must be a bug (I made...).
Cause: The tool is simply adding the new strings to common-rst [1]. So, the unused strings are remaining...
Background (from my understand): Each document uses the common contents. However, each document has the different exclude_patterns, because Sphinx warns if there are unused files.
Ah, the exclude_patterns - indeed that will be a challenge why we need to collect these.
Therefore, each document has a partial common-rst file, not a whole common-rst.
Solution: ... I don't have a good idea as of now... Add a new document that contains all common file? OpenStack Common Guide (dummy, just to create pot file :)
Perhaps. Or delete before we start the common-rst pot file and then collect all content?
I will re-consider
I fear we need to revert Akihiro's patch that I +2ed.
Thanks all for looking into this,
Andreas
the situation.
Any idea is welcome.
Regards, KATO Tomoyuki
[1] https://github.com/openstack/openstack-manuals/blob/master/tools/generatepot... [2] https://github.com/openstack/openstack-manuals/blob/master/doc/install-guide...
Thanks Andreas,
It seems I ran "tox -e generatepot-rst" on an unrelated doc. Now it works.
Regarding the problem that I see obsolete strings in the common-rst pot, I will investigate more. There is no need to rush, but it is worth fixed soon.
Akihiro
2015-10-16 2:24 GMT+09:00 Andreas Jaeger <aj@suse.com>:
On 10/15/2015 07:02 PM, Akihiro Motoki wrote:
Hi team,
During translation of common-rst in Zanata, I found a bit odd entries in openstack-manuals/doc/common-rst/source/locale/common-rst.pot.
When and how is openstack-manuals/common-rst updated?
For example, we see the following in common-rst.pot: --- #: ../common/app_support.rst:3 msgid "Community support" msgstr ""
#: ../common/app_support.rst:5 msgid "Community Support" msgstr "" ----
However, we actually have only the first entry in common-rst/*.rst: --- $ grep -r 'Community Support' doc/common-rst/*.rst $ grep -r 'Community support' doc/common-rst/*.rst doc/common-rst/app_support.rst:Community support ---
If you look at app_support.rst, we have only the first one. Where does the second one come from?
In tools/generatepot-rst.sh, processing on 'common-rst' is skipped. I wonder which script we update common-rst.pot.
generatepot-rst.sh generates the file in every invocation, just run "tox -e generatepot-rst -- user-guide"
A git status afterwards will show: ... modified: doc/common-rst/source/locale/common-rst.pot modified: doc/user-guide/source/locale/user-guide.pot
Just the invocation " tox -e generatepot-rst -- common-rst" is skipped
Still that does not answer your initial question why the line is there twice. Debugging is welcome,
Andreas -- Andreas Jaeger aj@{suse.com,opensuse.org} Twitter/Identica: jaegerandi SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg) GPG fingerprint = 93A3 365E CE47 B889 DF7F FED1 389A 563C C272 A126
_______________________________________________ OpenStack-docs mailing list OpenStack-docs@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-docs
-- Andreas Jaeger aj@{suse.com,opensuse.org} Twitter/Identica: jaegerandi SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg) GPG fingerprint = 93A3 365E CE47 B889 DF7F FED1 389A 563C C272 A126
participants (3)
-
Akihiro Motoki
-
Andreas Jaeger
-
KATO Tomoyuki