Thanks for the patch. I noticed this issue when I found ~50% percentag in log-*.po files last week. This situation tends to happen just after _LE, _LW, _LI style is introduced into the code base. Thanks, Akihiro On Wed, Oct 15, 2014 at 5:55 PM, Andreas Jaeger <aj@suse.com> wrote:
On 10/11/2014 11:13 AM, Andreas Jaeger wrote:
On 10/10/2014 06:28 PM, Akihiro Motoki wrote:
Andreas and Elizabeth,
Nice write-up.
I have one question about the below description in the process (without reading the infra code, sorry).
2. The script connects to transifex and asks to download for each resource all "sufficiently translated" files. We define "sufficiently" as at least 75 per cent of strings are translated.
Once 75% of strings are translated, the corresponding resource is downloaded. Will the resource be updated later even if the percentage of translated strings becomes <75%? IMHO it is better to be updated even if the percentage is <75% when the resource exists in $PROJECT repo. It can be done by "tx pull" without "-a" option.
Right now the script does not download anything if it less than 75 %. If the 75 % number does not work, we can change it - and patches to implement your idea are welcome as well ;)
Akihiro, I thought a bit more about your proposal and implemented it. Thanks for catching this situation!
https://review.openstack.org/128579
Andreas -- Andreas Jaeger aj@{suse.com,opensuse.org} Twitter/Identica: jaegerandi SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn,Jennifer Guild,Felix Imendörffer,HRB16746 (AG Nürnberg) GPG fingerprint = 93A3 365E CE47 B889 DF7F FED1 389A 563C C272 A126
-- Akihiro Motoki <amotoki@gmail.com>