+1 on keeping the newline mismatch an error

 

For Horizon, it's not just a linter that fails - it's the actual compilation of the PO files, which means the translations (all of them!) become unmergeable.

Doug Fish

 

 

----- Original message -----
From: Clark Boylan <cboylan@sapwetik.org>
To: openstack-i18n@lists.openstack.org
Cc:
Subject: Re: [Openstack-i18n] "Warning: none, Errors: 1" from the difference of number of lines
Date: Mon, Oct 5, 2015 3:20 PM
 

I want to say we did that because the linters for the various projects
do msgfmt checks that fail when newlines don't match. This means that
any of those translations sneaking into the git repo proposals prevent
any translations for that project from merging. I believe we do want
this to be an error in Zanata as long as the projects are going to check
and fail on that when linting.

Clark

On Mon, Oct 5, 2015, at 12:51 PM, Alex Eng wrote:
> Hi Andreas,
>
> The reason translations can't be save when newline character doesn't
> match
> with source is due to the settings in project horizon. For some reason,
> it
> was set to "Error", and this will prevent saving of translation whenever
> this validation failed.
>
> You can change the setting via:
> https://translate.openstack.org/project/view/horizon/settings/translation
> (need to be project maintainer for admin), set the "Leading/trailing
> newline (\n)" to warning.
>
>
> ---------------------------------------------
>
> Alex Eng
> Globalisation Tools Engineering
> DID: +61 3514 8262 <callto:+61+3514+8262>
> Mobile: +614 2335 3457 <callto:+614+2335+3457>
>
> Red Hat, Asia-Pacific Pty Ltd
> Level 1, 193 North Quay
> Brisbane 4000
> Office: +61 7 3514 8100 <callto:+61+7+3514+8100>
> Fax: +61 7 3514 8199 <callto:+61+7+3514+8199>
> Website: www.redhat.com
>
> On Tue, Oct 6, 2015 at 4:59 AM, Andreas Jaeger <aj@suse.com> wrote:
>
> > Thanks for your comments and have a good night!
> >
> > # Japanese team insert meaningless newlines to avoid warnings for
> >> Liberty translations
> >> # but would not like to do that in the future.
> >>
> >
> >
> > Please file a feature request with the Zanata team, I have not found an
> > option to disable this myself ;(
> >
> > Andreas
> > --
> >  Andreas Jaeger aj@{suse.com,opensuse.org} Twitter/Identica: jaegerandi
> >   SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
> >    GF: Felix Imendörffer, Jane Smithard, Graham Norton,
> >        HRB 21284 (AG Nürnberg)
> >     GPG fingerprint = 93A3 365E CE47 B889 DF7F  FED1 389A 563C C272 A126
> >
> >
> > _______________________________________________
> > Openstack-i18n mailing list
> > Openstack-i18n@lists.openstack.org
> > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-i18n
> >
> _______________________________________________
> Openstack-i18n mailing list
> Openstack-i18n@lists.openstack.org
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-i18n

_______________________________________________
Openstack-i18n mailing list
Openstack-i18n@lists.openstack.org
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-i18n
 

_______________________________________________
Openstack-i18n mailing list
Openstack-i18n@lists.openstack.org
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-i18n