Hi Julie, On Fri, Jul 14, 2017 at 7:45 PM, Julie Pichon <jpichon@redhat.com> wrote:
Hi Patrick,
Thank you for watching and offering feedback!
On 14 July 2017 at 10:11, Patrick Huang <pahuang@redhat.com> wrote:
Thanks for sharing Julie.
Just watched the recording and wanted to provide some feedback.
- To check for invalid pot file, you can use msgfmt -c message.pot. Since ultimately we want to ensure valid pot file, this might be better than writing tests for javascript. msgfmt is part of gettext package in linux.
This is a shell command though, and the tests that are run on the tripleo-ui gate (that could block the patch from merging early if there is an issue) only run JavaScript at this point. I'm not sure if we could just run a shell command as part of such a test.
- zanata-cli pull supports a new option --min-doc-percent. e.g. zanata-cli pull --min-doc-percent 75 will only download files with translation over 75%. But again it won't remove old files dropped below 75%. Maybe delete them all before pull?
That sounds awesome! Do you know from what version this is available, is this something we could use in the infra scripts?
It's available since 3.7.0. Old bugzilla issue [1].
From what I understand, every OpenStack project still do manual ratio calculations at this point [1] so it would be good to update this for everyone. It would avoid issues where the percentage ends up slightly different between what Zanata shows and what the script calculates. (I manually deleted an unmaintained po file that was <60% in Zanata but it ended up being submitted again, because the calculations are done differently.)
There are two type of statistics we use: word based and message based. Depending on the project, these two figures may differ quite significantly. For this option, we've chosen message based statistics and round up to whole number. e.g. 95.55% will be considered as 96%.
Thanks again for all these tips.
Regards,
Julie
[1] https://bugzilla.redhat.com/show_bug.cgi?id=1215274 -- Patrick Huang Senior Software Engineer Engineering - Internationalisation Red Hat, Asia-Pacific Pty Ltd Level 1, 193 North Quay Brisbane 4000 Office: +61 7 3514 8278 <+61%207%203514%208278> Fax: +61 7 3514 8199 <+61%207%203514%208199> IRC: pahuang github: github.com/huangp Website: www.redhat.com