[neutron][stable] neutron-lib stable branches core reviewers
Hi, I just noticed that neutron-lib project has got own group "neutron-lib-stable-maint" which has +2 powers in neutron-lib stable branches [1]. As I see now in gerrit that group don't have any members. Would it be maybe possible to remove that group and add "neutron-stable-maint" to the neutron-lib stable branches instead? If yes, should I simply propose patch to change [1] or is there any other way which I should do it? [1] https://github.com/openstack/project-config/blob/master/gerrit/acls/openstac... -- Slawek Kaplonski Principal Software Engineer Red Hat
On Thu, 18 Mar 2021 at 14:48, Slawek Kaplonski <skaplons@redhat.com> wrote:
Hi,
I just noticed that neutron-lib project has got own group "neutron-lib-stable-maint" which has +2 powers in neutron-lib stable branches [1]. As I see now in gerrit that group don't have any members. Would it be maybe possible to remove that group and add "neutron-stable-maint" to the neutron-lib stable branches instead? If yes, should I simply propose patch to change [1] or is there any other way which I should do it?
I guess we never spotted that "neutron-lib-stable-maint" before, as it seems neutron cores had +2 powers before: https://review.opendev.org/c/openstack/neutron-lib/+/717093 But yes it could be useful to have either of these groups (neutron cores or stable cores) in, backports to neutron-lib are rare but some happen - I remember one some time ago where it was valid to have a patch backported.
[1] https://github.com/openstack/project-config/blob/master/gerrit/acls/openstac...
-- Slawek Kaplonski Principal Software Engineer Red Hat
-- Bernard Cafarelli
I guess maybe the +2 rights got lost during the Gerrit upgrade in November. Maybe this happened due to something was missing from the acl config (what Slawek linked). I've added the [infra] to the subject as infra team has the power to act in this matter. (unfortunately stable-maint-core doesn't have) (note: until that happens: feel free to ping me if a stable patch there needs +2, since as stable-maint-core I have the right to +2/+W there) Cheers, Előd On 2021. 03. 22. 12:35, Bernard Cafarelli wrote:
On Thu, 18 Mar 2021 at 14:48, Slawek Kaplonski <skaplons@redhat.com <mailto:skaplons@redhat.com>> wrote:
Hi,
I just noticed that neutron-lib project has got own group "neutron-lib-stable-maint" which has +2 powers in neutron-lib stable branches [1]. As I see now in gerrit that group don't have any members. Would it be maybe possible to remove that group and add "neutron-stable-maint" to the neutron-lib stable branches instead? If yes, should I simply propose patch to change [1] or is there any other way which I should do it?
I guess we never spotted that "neutron-lib-stable-maint" before, as it seems neutron cores had +2 powers before: https://review.opendev.org/c/openstack/neutron-lib/+/717093 <https://review.opendev.org/c/openstack/neutron-lib/+/717093>
But yes it could be useful to have either of these groups (neutron cores or stable cores) in, backports to neutron-lib are rare but some happen - I remember one some time ago where it was valid to have a patch backported.
[1] https://github.com/openstack/project-config/blob/master/gerrit/acls/openstac... <https://github.com/openstack/project-config/blob/master/gerrit/acls/openstack/neutron-lib.config>
-- Slawek Kaplonski Principal Software Engineer Red Hat
-- Bernard Cafarelli
Hi, Dnia czwartek, 25 marca 2021 10:54:54 CET Előd Illés pisze:
I guess maybe the +2 rights got lost during the Gerrit upgrade in November. Maybe this happened due to something was missing from the acl config (what Slawek linked). I've added the [infra] to the subject as infra team has the power to act in this matter. (unfortunately stable-maint-core doesn't have)
(note: until that happens: feel free to ping me if a stable patch there needs +2, since as stable-maint-core I have the right to +2/+W there)
Thx a lot Előd :)
Cheers,
Előd
On 2021. 03. 22. 12:35, Bernard Cafarelli wrote:
On Thu, 18 Mar 2021 at 14:48, Slawek Kaplonski <skaplons@redhat.com
<mailto:skaplons@redhat.com>> wrote: Hi,
I just noticed that neutron-lib project has got own group "neutron-lib-stable-maint" which has +2 powers in neutron-lib stable branches [1]. As I see now in gerrit that group don't have any members. Would it be maybe possible to remove that group and add "neutron-stable-maint" to the neutron-lib stable branches instead? If yes, should I simply propose patch to change [1] or is there any other way which I should do it?
I guess we never spotted that "neutron-lib-stable-maint" before, as it seems neutron cores had +2 powers before: https://review.opendev.org/c/openstack/neutron-lib/+/717093 <https://review.opendev.org/c/openstack/neutron-lib/+/717093>
But yes it could be useful to have either of these groups (neutron cores or stable cores) in, backports to neutron-lib are rare but some happen - I remember one some time ago where it was valid to have a patch backported.
[1] https://github.com/openstack/project-config/blob/master/gerrit/acls/
open
stack/neutron-lib.config <https://github.com/openstack/project-config/blob/master/gerrit/acls/op enstack/neutron-lib.config>
-- Slawek Kaplonski Principal Software Engineer Red Hat
-- Bernard Cafarelli
-- Slawek Kaplonski Principal Software Engineer Red Hat
On 2021-03-25 10:54:54 +0100 (+0100), Előd Illés wrote:
I guess maybe the +2 rights got lost during the Gerrit upgrade in November. [...]
Nope, it's all a result of https://review.opendev.org/750643 because of the exclusiveGroupPermissions on refs/heads/stable/* access. Propose a change to that file to do whatever it is you expect there. -- Jeremy Stanley
Hi, Dnia czwartek, 25 marca 2021 13:10:13 CET Jeremy Stanley pisze:
On 2021-03-25 10:54:54 +0100 (+0100), Előd Illés wrote:
I guess maybe the +2 rights got lost during the Gerrit upgrade in November.
[...]
Nope, it's all a result of https://review.opendev.org/750643 because of the exclusiveGroupPermissions on refs/heads/stable/* access.
Propose a change to that file to do whatever it is you expect there.
Thx Jeremy for pointing to that. I just proposed: https://review.opendev.org/ c/openstack/project-config/+/783011 I hope it can be accepted.
-- Jeremy Stanley
-- Slawek Kaplonski Principal Software Engineer Red Hat
participants (4)
-
Bernard Cafarelli
-
Előd Illés
-
Jeremy Stanley
-
Slawek Kaplonski