[cinder][drivers] new driver merge freeze question
Hi, Thank you for proposing the driver. I've added it to the list of current drivers[1] for 2023.2 Bobcat cycle. Currently I can see that the patch is failing on multiple jobs i.e. pep8, unit, docs, grenade etc which needs to be fixed. Also the third party CI is failing as you have already mentioned. We can push for reviews but ideally the gate should be passing and the CI should be ready which is a bare minimum for the driver to be reviewed. I will mention this driver in our weekly cinder meeting on Wednesday, 1400 UTC on #openstack-meeting-alt channel, feel free to attend the meeting on IRC. Regarding the deadline, it can be extended given the driver is almost ready and might only require minor/cosmetic changes. Also the extension provided is also for a limited time frame (had been 1 week in the past) so the driver should be ready in 1 extra week given the exception is provided. Currently I would recommend fixing the gate jobs and getting the third party CI working so it is easier to push for reviews. [1] https://etherpad.opendev.org/p/cinder-2023-2-bobcat-drivers Thanks Rajat Dhasmana On Mon, Jul 3, 2023 at 10:22 PM 蔡启龙 <caiql@toyou.com.cn> wrote:
Hello. I am working on the TOYOU NetStor cinder volume driver, https://review.opendev.org/c/openstack/cinder/+/886942. I am working hard to address some test cases that failed with our third-party-CI. In the meantime, I would appreciate reviews so that I will be in a strong position to ask for a new driver merge deadline exception if I'm only "mostly done" when we hit the deadline this Friday, 7 July. My question is whether it will be possible to ask for a new driver merge deadline exception this cycle, or if the deadline is immovable?
participants (2)
-
Rajat Dhasmana
-
蔡启龙