[tripleo] Nominate David J. Peacock (dpeacock) for Validation Framework Core
Hi TripleO Devs, David is already a key member of our team since a long time now, he provided all the needed ansible roles for the Validation Framework into tripleo-ansible-operator. He continuously provides excellent code reviews and he is a source of great ideas for the future of the Validation Framework. That's why we would highly benefit from his addition to the core reviewer team. Assuming that there are no objections, we will add David to the core team next week. Thanks, David, for your excellent work! -- Gaël Chamoulaud - (He/Him/His) .::. Red Hat .::. OpenStack .::. .::. DFG:DF Squad:VF .::.
Not that it would technically matter, but +1. Jan Buchta Manager, Openstack Engineering Red Hat Czech, s.r.o. <https://www.redhat.com/> Purkyňova 3080/97b 61200 Brno, Czech Republic jbuchta@redhat.com T: +420-532294903 M: +420-603949107 IM: jbuchta <https://red.ht/sig> <https://redhat.com/summit> On Tue, Mar 9, 2021 at 3:53 PM Gaël Chamoulaud <gchamoul@redhat.com> wrote:
Hi TripleO Devs,
David is already a key member of our team since a long time now, he provided all the needed ansible roles for the Validation Framework into tripleo-ansible-operator. He continuously provides excellent code reviews and he is a source of great ideas for the future of the Validation Framework. That's why we would highly benefit from his addition to the core reviewer team.
Assuming that there are no objections, we will add David to the core team next week.
Thanks, David, for your excellent work!
-- Gaël Chamoulaud - (He/Him/His) .::. Red Hat .::. OpenStack .::. .::. DFG:DF Squad:VF .::.
of course +1! Even +42 On 3/9/21 3:53 PM, Gaël Chamoulaud wrote:
Hi TripleO Devs,
David is already a key member of our team since a long time now, he provided all the needed ansible roles for the Validation Framework into tripleo-ansible-operator. He continuously provides excellent code reviews and he is a source of great ideas for the future of the Validation Framework. That's why we would highly benefit from his addition to the core reviewer team.
Assuming that there are no objections, we will add David to the core team next week.
Thanks, David, for your excellent work!
-- Gaël Chamoulaud - (He/Him/His) .::. Red Hat .::. OpenStack .::. .::. DFG:DF Squad:VF .::.
-- Cédric Jeanneret (He/Him/His) Sr. Software Engineer - OpenStack Platform Deployment Framework TC Red Hat EMEA https://www.redhat.com/
On Tue, Mar 9, 2021 at 4:54 PM Gaël Chamoulaud <gchamoul@redhat.com> wrote:
Hi TripleO Devs,
David is already a key member of our team since a long time now, he provided all the needed ansible roles for the Validation Framework into tripleo-ansible-operator. He continuously provides excellent code reviews and he is a source of great ideas for the future of the Validation Framework. That's why we would highly benefit from his addition to the core reviewer team.
Assuming that there are no objections, we will add David to the core team next week.
o/ Gael so it is clear and fair for everyone (e.g. I've been approached by others about candidates for tripleo-core) I'd like to be clear on your proposal here because I don't think we have a 'validation framework core' group in gerrit - do we? Is your proposal that David is added to the tripleo-core group [1] with the understanding that voting rights will be exercised only in the following repos: tripleo-validations, validations-common and validations-libs? thanks, marios [1] https://review.opendev.org/admin/groups/0319cee8020840a3016f46359b076fa6b6ea...
Thanks, David, for your excellent work!
-- Gaël Chamoulaud - (He/Him/His) .::. Red Hat .::. OpenStack .::. .::. DFG:DF Squad:VF .::.
On 09/Mar/2021 17:46, Marios Andreou wrote:
On Tue, Mar 9, 2021 at 4:54 PM Gaël Chamoulaud <gchamoul@redhat.com> wrote:
Hi TripleO Devs,
David is already a key member of our team since a long time now, he provided all the needed ansible roles for the Validation Framework into tripleo-ansible-operator. He continuously provides excellent code reviews and he is a source of great ideas for the future of the Validation Framework. That's why we would highly benefit from his addition to the core reviewer team.
Assuming that there are no objections, we will add David to the core team next week.
o/ Gael
so it is clear and fair for everyone (e.g. I've been approached by others about candidates for tripleo-core)
I'd like to be clear on your proposal here because I don't think we have a 'validation framework core' group in gerrit - do we?
Is your proposal that David is added to the tripleo-core group [1] with the understanding that voting rights will be exercised only in the following repos: tripleo-validations, validations-common and validations-libs?
Yes exactly! Sorry for the confusion.
thanks, marios
[1] https://review.opendev.org/admin/groups/ 0319cee8020840a3016f46359b076fa6b6ea831a
Thanks, David, for your excellent work!
-- Gaël Chamoulaud - (He/Him/His) .::. Red Hat .::. OpenStack .::. .::. DFG:DF Squad:VF .::.
-- Gaël Chamoulaud - (He/Him/His) .::. Red Hat .::. OpenStack .::. .::. DFG:DF Squad:VF .::.
On Tue, Mar 9, 2021 at 5:52 PM Gaël Chamoulaud <gchamoul@redhat.com> wrote:
On 09/Mar/2021 17:46, Marios Andreou wrote:
On Tue, Mar 9, 2021 at 4:54 PM Gaël Chamoulaud <gchamoul@redhat.com>
wrote:
Hi TripleO Devs,
David is already a key member of our team since a long time now, he provided all the needed ansible roles for the Validation Framework
into
tripleo-ansible-operator. He continuously provides excellent code
reviews
and he is a source of great ideas for the future of the Validation
Framework.
That's why we would highly benefit from his addition to the core reviewer
team.
Assuming that there are no objections, we will add David to the core
team
next week.
o/ Gael
so it is clear and fair for everyone (e.g. I've been approached by
candidates for tripleo-core)
I'd like to be clear on your proposal here because I don't think we have a 'validation framework core' group in gerrit - do we?
Is your proposal that David is added to the tripleo-core group [1] with
others about the
understanding that voting rights will be exercised only in the following repos: tripleo-validations, validations-common and validations-libs?
Yes exactly! Sorry for the confusion.
ACK no problem ;) As I said we need to be transparent and fair towards everyone. +1 from me to your proposal. Being obligated to do so at PTL ;) I did a quick review of activities. I can see that David has been particularly active in Wallaby [1] but has made tripleo contributions going back to 2017 [2] - I cannot see some reason to object to the proposal! regards, marios [1] https://www.stackalytics.io/?module=tripleo-group&project_type=openstack&user_id=davidjpeacock&metric=marks&release=wallaby [2] https://review.opendev.org/q/owner:davidjpeacock
thanks, marios
[1] https://review.opendev.org/admin/groups/ 0319cee8020840a3016f46359b076fa6b6ea831a
Thanks, David, for your excellent work!
-- Gaël Chamoulaud - (He/Him/His) .::. Red Hat .::. OpenStack .::. .::. DFG:DF Squad:VF .::.
-- Gaël Chamoulaud - (He/Him/His) .::. Red Hat .::. OpenStack .::. .::. DFG:DF Squad:VF .::.
Hey, Thank you Gael, +2 obviously :) Mathieu On Tue, Mar 9, 2021 at 5:06 PM Marios Andreou <marios@redhat.com> wrote:
On Tue, Mar 9, 2021 at 5:52 PM Gaël Chamoulaud <gchamoul@redhat.com> wrote:
On 09/Mar/2021 17:46, Marios Andreou wrote:
On Tue, Mar 9, 2021 at 4:54 PM Gaël Chamoulaud <gchamoul@redhat.com>
wrote:
Hi TripleO Devs,
David is already a key member of our team since a long time now, he provided all the needed ansible roles for the Validation Framework
into
tripleo-ansible-operator. He continuously provides excellent code
reviews
and he is a source of great ideas for the future of the Validation
Framework.
That's why we would highly benefit from his addition to the core reviewer
team.
Assuming that there are no objections, we will add David to the
core team
next week.
o/ Gael
so it is clear and fair for everyone (e.g. I've been approached by
candidates for tripleo-core)
I'd like to be clear on your proposal here because I don't think we have a 'validation framework core' group in gerrit - do we?
Is your proposal that David is added to the tripleo-core group [1] with
others about the
understanding that voting rights will be exercised only in the following repos: tripleo-validations, validations-common and validations-libs?
Yes exactly! Sorry for the confusion.
ACK no problem ;) As I said we need to be transparent and fair towards everyone.
+1 from me to your proposal.
Being obligated to do so at PTL ;) I did a quick review of activities. I can see that David has been particularly active in Wallaby [1] but has made tripleo contributions going back to 2017 [2] - I cannot see some reason to object to the proposal!
regards, marios
[1] https://www.stackalytics.io/?module=tripleo-group&project_type=openstack&user_id=davidjpeacock&metric=marks&release=wallaby [2] https://review.opendev.org/q/owner:davidjpeacock
thanks, marios
[1] https://review.opendev.org/admin/groups/ 0319cee8020840a3016f46359b076fa6b6ea831a
Thanks, David, for your excellent work!
-- Gaël Chamoulaud - (He/Him/His) .::. Red Hat .::. OpenStack .::. .::. DFG:DF Squad:VF .::.
-- Gaël Chamoulaud - (He/Him/His) .::. Red Hat .::. OpenStack .::. .::. DFG:DF Squad:VF .::.
Hi, I'm not core, just a member of the VF squad. I want to say that I would certainly like David to be VF Core. On Thu, Mar 11, 2021 at 3:44 PM Mathieu Bultel <mbultel@redhat.com> wrote:
Hey,
Thank you Gael,
+2 obviously :)
Mathieu
On Tue, Mar 9, 2021 at 5:06 PM Marios Andreou <marios@redhat.com> wrote:
On Tue, Mar 9, 2021 at 5:52 PM Gaël Chamoulaud <gchamoul@redhat.com> wrote:
On 09/Mar/2021 17:46, Marios Andreou wrote:
On Tue, Mar 9, 2021 at 4:54 PM Gaël Chamoulaud <gchamoul@redhat.com>
wrote:
Hi TripleO Devs,
David is already a key member of our team since a long time now, he provided all the needed ansible roles for the Validation Framework
into
tripleo-ansible-operator. He continuously provides excellent code
reviews
and he is a source of great ideas for the future of the Validation
Framework.
That's why we would highly benefit from his addition to the core reviewer
team.
Assuming that there are no objections, we will add David to the
core team
next week.
o/ Gael
so it is clear and fair for everyone (e.g. I've been approached by
others about
candidates for tripleo-core)
I'd like to be clear on your proposal here because I don't think we have a 'validation framework core' group in gerrit - do we?
Is your proposal that David is added to the tripleo-core group [1] with the understanding that voting rights will be exercised only in the following repos: tripleo-validations, validations-common and validations-libs?
Yes exactly! Sorry for the confusion.
ACK no problem ;) As I said we need to be transparent and fair towards everyone.
+1 from me to your proposal.
Being obligated to do so at PTL ;) I did a quick review of activities. I can see that David has been particularly active in Wallaby [1] but has made tripleo contributions going back to 2017 [2] - I cannot see some reason to object to the proposal!
regards, marios
[1] https://www.stackalytics.io/?module=tripleo-group&project_type=openstack&user_id=davidjpeacock&metric=marks&release=wallaby [2] https://review.opendev.org/q/owner:davidjpeacock
thanks, marios
[1] https://review.opendev.org/admin/groups/ 0319cee8020840a3016f46359b076fa6b6ea831a
Thanks, David, for your excellent work!
-- Gaël Chamoulaud - (He/Him/His) .::. Red Hat .::. OpenStack .::. .::. DFG:DF Squad:VF .::.
-- Gaël Chamoulaud - (He/Him/His) .::. Red Hat .::. OpenStack .::. .::. DFG:DF Squad:VF .::.
On Tue, Mar 9, 2021 at 11:05 AM Marios Andreou <marios@redhat.com> wrote:
On Tue, Mar 9, 2021 at 5:52 PM Gaël Chamoulaud <gchamoul@redhat.com> wrote:
Is your proposal that David is added to the tripleo-core group [1] with
On 09/Mar/2021 17:46, Marios Andreou wrote: the
understanding that voting rights will be exercised only in the following repos: tripleo-validations, validations-common and validations-libs?
Yes exactly! Sorry for the confusion.
ACK no problem ;) As I said we need to be transparent and fair towards everyone.
+1 from me to your proposal.
+1!. Thanks for the effort David! -- -- James Slagle --
+1 On Tue, Mar 9, 2021 at 7:59 AM Gaël Chamoulaud <gchamoul@redhat.com> wrote:
Hi TripleO Devs,
David is already a key member of our team since a long time now, he provided all the needed ansible roles for the Validation Framework into tripleo-ansible-operator. He continuously provides excellent code reviews and he is a source of great ideas for the future of the Validation Framework. That's why we would highly benefit from his addition to the core reviewer team.
Assuming that there are no objections, we will add David to the core team next week.
Thanks, David, for your excellent work!
-- Gaël Chamoulaud - (He/Him/His) .::. Red Hat .::. OpenStack .::. .::. DFG:DF Squad:VF .::.
+1 DVD On Wed, Mar 17, 2021 at 9:33 AM Alex Schultz <aschultz@redhat.com> wrote:
+1
On Tue, Mar 9, 2021 at 7:59 AM Gaël Chamoulaud <gchamoul@redhat.com> wrote:
Hi TripleO Devs,
David is already a key member of our team since a long time now, he provided all the needed ansible roles for the Validation Framework into tripleo-ansible-operator. He continuously provides excellent code reviews and he is a source of great ideas for the future of the Validation Framework. That's why we would highly benefit from his addition to the core reviewer team.
Assuming that there are no objections, we will add David to the core team next week.
Thanks, David, for your excellent work!
-- Gaël Chamoulaud - (He/Him/His) .::. Red Hat .::. OpenStack .::. .::. DFG:DF Squad:VF .::.
Ladies and Gentlemen, First, thanks for your votes! With the agreement of Marios, I've added David as part of the tripleo-core group and his voting rights will be exercised only on the following repositories: - tripleo-validations - validations-common - validations-libs - python-tripleoclient (only on VF related patches touching the tripleo_validator.py CLI Code) However, it would be great to create a dedicated core group for the Validation Framework team including those repositories. And thus being more compliant with what we do with others TripleO Teams. Marios, any thoughts? Congratulations David and thanks again for your hard work! On 09/Mar/2021 15:53, Gaël Chamoulaud wrote:
Hi TripleO Devs,
David is already a key member of our team since a long time now, he provided all the needed ansible roles for the Validation Framework into tripleo-ansible-operator. He continuously provides excellent code reviews and he is a source of great ideas for the future of the Validation Framework. That's why we would highly benefit from his addition to the core reviewer team.
Assuming that there are no objections, we will add David to the core team next week.
Thanks, David, for your excellent work!
-- Gaël Chamoulaud - (He/Him/His) .::. Red Hat .::. OpenStack .::. .::. DFG:DF Squad:VF .::.
-- Gaël Chamoulaud - (He/Him/His) .::. Red Hat .::. OpenStack .::. .::. DFG:DF Squad:VF .::.
Hey Gael On Fri, Mar 19, 2021 at 12:00 PM Gaël Chamoulaud <gchamoul@redhat.com> wrote:
Ladies and Gentlemen,
First, thanks for your votes!
With the agreement of Marios, I've added David as part of the tripleo-core group and his voting rights will be exercised only on the following repositories:
thanks for adding David I can see he is in the tripleo-core group members list at [1].
- tripleo-validations - validations-common - validations-libs - python-tripleoclient (only on VF related patches touching the tripleo_validator.py CLI Code)
However, it would be great to create a dedicated core group for the Validation Framework team including those repositories. And thus being more compliant with what we do with others TripleO Teams. Marios, any thoughts?
As briefly discussed this morning on #tripleo yeah I think it makes sense. I just did some digging about that so a couple of thoughts; these repos are under tripleo governance [2] so first thing so we can create a new group and add the tripleo-core group as members. I'm not sure how we create a new tripleo-validation (or whatever name) gerrit group yet though so there's that ;)... I couldn't quickly find info about that in hound [3] but I'm sure we can work that out _eventually_ Then I think we need to add a file like that [4] for the validation repos to set the access for the new group. Let's see if there are any other thoughts or comments about that proposal before we proceed anyway, regards, marios [1] https://review.opendev.org/admin/groups/0319cee8020840a3016f46359b076fa6b6ea... [2] https://opendev.org/openstack/governance/src/commit/98614886e2a93c5981be4fc9... [3] https://codesearch.opendev.org/?q=tripleo-core&i=nope&files=&excludeFiles=&repos= [4] https://opendev.org/openstack/project-config/src/branch/master/gerrit/acls/o...
participants (9)
-
Alex Schultz
-
Cédric Jeanneret
-
David Vallee Delisle
-
Gaël Chamoulaud
-
James Slagle
-
Jan Buchta
-
Jiri Podivin
-
Marios Andreou
-
Mathieu Bultel