Making WIP patch Active (without owner)
After the resolving the merge conflict, the following IBM Cinder driver patch is now in ‘Work in Progress’ state. We want to now make it Active, but the owner of the patch is no longer working with the organisation. Thus, the Gerrit UI is not showing option to publish. How to make this patch Active again? The patch was reviewed and had multiple +1 votes earlier. Patch: https://review.opendev.org/c/openstack/cinder/+/879839
I think it's only patch owner (or possible Gerrit Admins) who can remove WIP status. AFAIK it's not possible for the Core-Reviewers group to remove WIP from the patch as of today. So I'd guess the best second alternative, if patch owner is not responding, is to create another patch with similar content, and add the `Co-Authored-By` tag to it, to give credit to the Author. Then the Core Reviewers group can Abandon original patch in favor of the new one. пт, 5 сент. 2025 г. в 09:17, Nimesh Desai <Nimesh.Desai@ibm.com>:
After the resolving the merge conflict, the following IBM Cinder driver patch is now in ‘Work in Progress’ state.
We want to now make it Active, but the owner of the patch is no longer working with the organisation. Thus, the Gerrit UI is not showing option to publish. How to make this patch Active again?
The patch was reviewed and had multiple +1 votes earlier.
Patch: https://review.opendev.org/c/openstack/cinder/+/879839
Thanks for the quick suggestion. I have now created a new patch - https://review.opendev.org/c/openstack/cinder/+/959683 The older one will be abandoned. Regards, Nimesh Desai From: Dmitriy Rabotyagov <noonedeadpunk@gmail.com> Date: Friday, 5 September 2025 at 1:04 PM To: Nimesh Desai <Nimesh.Desai@ibm.com> Cc: openstack-discuss@lists.openstack.org <openstack-discuss@lists.openstack.org> Subject: [EXTERNAL] Re: Making WIP patch Active (without owner) I think it's only patch owner (or possible Gerrit Admins) who can remove WIP status. AFAIK it's not possible for the Core-Reviewers group to remove WIP from the patch as of today. So I'd guess the best second alternative, if patch I think it's only patch owner (or possible Gerrit Admins) who can remove WIP status. AFAIK it's not possible for the Core-Reviewers group to remove WIP from the patch as of today. So I'd guess the best second alternative, if patch owner is not responding, is to create another patch with similar content, and add the `Co-Authored-By` tag to it, to give credit to the Author. Then the Core Reviewers group can Abandon original patch in favor of the new one. пт, 5 сент. 2025 г. в 09:17, Nimesh Desai <Nimesh.Desai@ibm.com<mailto:Nimesh.Desai@ibm.com>>: After the resolving the merge conflict, the following IBM Cinder driver patch is now in ‘Work in Progress’ state. We want to now make it Active, but the owner of the patch is no longer working with the organisation. Thus, the Gerrit UI is not showing option to publish. How to make this patch Active again? The patch was reviewed and had multiple +1 votes earlier. Patch: https://review.opendev.org/c/openstack/cinder/+/879839<https://review.opendev.org/c/openstack/cinder/+/879839 >
Hi Nimesh, As per the suggestion by Dmitriy, I've abandoned the original patch and left a comment on the new one to mention the original author in the commit message with `Co-Authored-By` tag. Thanks Rajat Dhasmana On Fri, Sep 5, 2025 at 1:49 PM Nimesh Desai <Nimesh.Desai@ibm.com> wrote:
Thanks for the quick suggestion. I have now created a new patch - https://review.opendev.org/c/openstack/cinder/+/959683
The older one will be abandoned.
Regards,
Nimesh Desai
*From: *Dmitriy Rabotyagov <noonedeadpunk@gmail.com> *Date: *Friday, 5 September 2025 at 1:04 PM *To: *Nimesh Desai <Nimesh.Desai@ibm.com> *Cc: *openstack-discuss@lists.openstack.org < openstack-discuss@lists.openstack.org> *Subject: *[EXTERNAL] Re: Making WIP patch Active (without owner)
I think it's only patch owner (or possible Gerrit Admins) who can remove WIP status. AFAIK it's not possible for the Core-Reviewers group to remove WIP from the patch as of today. So I'd guess the best second alternative, if patch
I think it's only patch owner (or possible Gerrit Admins) who can remove WIP status. AFAIK it's not possible for the Core-Reviewers group to remove WIP from the patch as of today.
So I'd guess the best second alternative, if patch owner is not responding, is to create another patch with similar content, and add the `Co-Authored-By` tag to it, to give credit to the Author.
Then the Core Reviewers group can Abandon original patch in favor of the new one.
пт, 5 сент. 2025 г. в 09:17, Nimesh Desai <Nimesh.Desai@ibm.com>:
After the resolving the merge conflict, the following IBM Cinder driver patch is now in ‘Work in Progress’ state.
We want to now make it Active, but the owner of the patch is no longer working with the organisation. Thus, the Gerrit UI is not showing option to publish. How to make this patch Active again?
The patch was reviewed and had multiple +1 votes earlier.
Patch: https://review.opendev.org/c/openstack/cinder/+/879839
On 2025-09-05 09:33:44 +0200 (+0200), Dmitriy Rabotyagov wrote:
I think it's only patch owner (or possible Gerrit Admins) who can remove WIP status. AFAIK it's not possible for the Core-Reviewers group to remove WIP from the patch as of today. [...]
With the current state of cinder's ACL[*] that's correct, but it's a permission that can be delegated easily. It might be a good idea to grant toggleWipState to the cinder-core group similar to what's done for neutron[**]. [*] https://opendev.org/openstack/project-config/src/commit/61c8a5d/gerrit/acls/... [**] https://opendev.org/openstack/project-config/src/commit/61c8a5d/gerrit/acls/... -- Jeremy Stanley
On Fri, Sep 5, 2025 at 6:38 AM Jeremy Stanley <fungi@yuggoth.org> wrote:
On 2025-09-05 09:33:44 +0200 (+0200), Dmitriy Rabotyagov wrote:
I think it's only patch owner (or possible Gerrit Admins) who can remove WIP status. AFAIK it's not possible for the Core-Reviewers group to remove WIP from the patch as of today. [...]
With the current state of cinder's ACL[*] that's correct, but it's a permission that can be delegated easily. It might be a good idea to grant toggleWipState to the cinder-core group similar to what's done for neutron[**].
[*] https://opendev.org/openstack/project-config/src/commit/61c8a5d/gerrit/acls/... [**] https://opendev.org/openstack/project-config/src/commit/61c8a5d/gerrit/acls/... --
Neat suggestion, I've had this issue in the past with manila repos; I think it's worth doing this universally across all openstack repos: https://review.opendev.org/c/openstack/project-config/+/959904
Jeremy Stanley
I'm frankly not sure about Registered user part. Because as a contributor, who is working on the patch, I don't want any user to drop WIP label off randomly, while I keep working on it. Or set the label accidentally - then while I'll be waiting for reviews they will never come. It might be fair to do so for project maintainers, but setting the permission too loose might be not great. On Fri, 5 Sept 2025, 23:31 Goutham Pacha Ravi, <gouthampravi@gmail.com> wrote:
On Fri, Sep 5, 2025 at 6:38 AM Jeremy Stanley <fungi@yuggoth.org> wrote:
On 2025-09-05 09:33:44 +0200 (+0200), Dmitriy Rabotyagov wrote:
I think it's only patch owner (or possible Gerrit Admins) who can remove WIP status. AFAIK it's not possible for the Core-Reviewers group to remove WIP from the patch as of today. [...]
With the current state of cinder's ACL[*] that's correct, but it's a permission that can be delegated easily. It might be a good idea to grant toggleWipState to the cinder-core group similar to what's done for neutron[**].
[*]
https://opendev.org/openstack/project-config/src/commit/61c8a5d/gerrit/acls/...
[**] https://opendev.org/openstack/project-config/src/commit/61c8a5d/gerrit/acls/... --
Neat suggestion, I've had this issue in the past with manila repos; I think it's worth doing this universally across all openstack repos: https://review.opendev.org/c/openstack/project-config/+/959904
Jeremy Stanley
On 06/09/2025 06:35, Dmitriy Rabotyagov wrote:
I'm frankly not sure about Registered user part.
Because as a contributor, who is working on the patch, I don't want any user to drop WIP label off randomly, while I keep working on it. Or set the label accidentally - then while I'll be waiting for reviews they will never come.
It might be fair to do so for project maintainers, but setting the permission too loose might be not great.
personally i would block the ablity to use the Work in progress state in gerrit entrily and actully enforce our contributors guidance to use workflow -1 for work in progress patches optionally in combination with [WIP] in the commit https://opendev.org/opendev/infra-manual/src/branch/master/doc/source/develo... https://docs.openstack.org/project-team-guide/review-the-openstack-way.html#... in general we have historically discuage using the gerrit native work in progress state after it was added in favor of maintaining our documented convention of usign workflow -1 and or [WIP] in the commit. gerrit is already setup to enforce this properly where the core team and the owner of the patch can set the values. if there is a way to entirely disable setting work in progress via the ACLs that probably a better solution then extending toggle rights to cores as it avoid parallel workflows that deviate from what in our documentation.
On Fri, 5 Sept 2025, 23:31 Goutham Pacha Ravi, <gouthampravi@gmail.com> wrote:
On Fri, Sep 5, 2025 at 6:38 AM Jeremy Stanley <fungi@yuggoth.org> wrote: > > On 2025-09-05 09:33:44 +0200 (+0200), Dmitriy Rabotyagov wrote: > > I think it's only patch owner (or possible Gerrit Admins) who can > > remove WIP status. AFAIK it's not possible for the Core-Reviewers > > group to remove WIP from the patch as of today. > [...] > > With the current state of cinder's ACL[*] that's correct, but it's a > permission that can be delegated easily. It might be a good idea to > grant toggleWipState to the cinder-core group similar to what's done > for neutron[**]. > > [*] https://opendev.org/openstack/project-config/src/commit/61c8a5d/gerrit/acls/... > [**] https://opendev.org/openstack/project-config/src/commit/61c8a5d/gerrit/acls/... > --
Neat suggestion, I've had this issue in the past with manila repos; I think it's worth doing this universally across all openstack repos: https://review.opendev.org/c/openstack/project-config/+/959904
> Jeremy Stanley
On 2025-09-08 12:41:51 +0100 (+0100), Sean Mooney wrote: [...]
personally i would block the ablity to use the Work in progress state in gerrit entrily and actully enforce our contributors guidance to use workflow -1 [...]
The reason OpenDev wanted the WIP toggle (we had our own proof-of-concept implementation back in 2012 which we tried unsuccessfully to get added upstream in Gerrit at the time) is that, being a single state for the change, it can potentially be unset by a different person than the one who originally set it without pushing a new revision (or resorting to getting a Gerrit admin involved). When we gave up, we compromised by replacing the Approved label with a Workflow label that included -1 in the range, but this was only ever intended as a workaround for the lack of an explicit change state. Gerrit upstream was eventually convinced of the use case years later and added a WIP feature, so our hope was that Workflow -1 could eventually be discouraged in favor of that.
gerrit is already setup to enforce this properly where the core team and the owner of the patch can set the values. [...]
Only if the requisite label permissions have been configured in the project's individual Gerrit ACL, similar to what Goutham's change does with toggleWipState. A lot of OpenStack projects have done it (more than have configured toggleWipState), but not all. -- Jeremy Stanley
participants (6)
-
Dmitriy Rabotyagov
-
Goutham Pacha Ravi
-
Jeremy Stanley
-
Nimesh Desai
-
Rajat Dhasmana
-
Sean Mooney