[devstack] Recent change breaks cloning with GIT_DEPTH setting
FYI, devstack commit b0bd5b92 doesn't work with a GIT_DEPTH=1 setting.
That commit basically changed from
git clone ... --branch <BRANCH>
to
git clone ... git checkout <BRANCH>
So it's easy for the desired <BRANCH> to be unavailable if GIT_DEPTH is limited.
Best wishes - Nell
Right, thanks Nell for pointing that out, you're right!
The patch in question: https://review.opendev.org/c/openstack/devstack/+/882299
We changed that because --branch didn't accept hashes anymore (not exactly sure why) but didn't realize that we might be passing --deph argument there. We'll need to rework that code so that it accepts both, branches and hashes, as well as depth argument.
Thanks,
On Mon, 5 Jun 2023 at 14:15, Nell Jerram nell@tigera.io wrote:
FYI, devstack commit b0bd5b92 doesn't work with a GIT_DEPTH=1 setting.
That commit basically changed from
git clone ... --branch <BRANCH>
to
git clone ... git checkout <BRANCH>
So it's easy for the desired <BRANCH> to be unavailable if GIT_DEPTH is limited.
Best wishes - Nell
I reported that to Launchpad to have it tracked: https://bugs.launchpad.net/devstack/+bug/2023020
On Mon, 5 Jun 2023 at 15:04, Martin Kopec mkopec@redhat.com wrote:
Right, thanks Nell for pointing that out, you're right!
The patch in question: https://review.opendev.org/c/openstack/devstack/+/882299
We changed that because --branch didn't accept hashes anymore (not exactly sure why) but didn't realize that we might be passing --deph argument there. We'll need to rework that code so that it accepts both, branches and hashes, as well as depth argument.
Thanks,
On Mon, 5 Jun 2023 at 14:15, Nell Jerram nell@tigera.io wrote:
FYI, devstack commit b0bd5b92 doesn't work with a GIT_DEPTH=1 setting.
That commit basically changed from
git clone ... --branch <BRANCH>
to
git clone ... git checkout <BRANCH>
So it's easy for the desired <BRANCH> to be unavailable if GIT_DEPTH is limited.
Best wishes - Nell
-- Martin
participants (2)
-
Martin Kopec
-
Nell Jerram