[nova][os-vif][stable] Adding os-vif-core to os-vif stable branches
Happy Friday, Per $subject, I'd like to propose that we add os-vif-core to the list of teams with +2 rights on os-vif stable branches. Currently this list is restricted to "Project Bootstrappers", nova-stable-maint and stable-maint-core. os-vif doesn't see many backports, but it is a rather specialist library that requires some domain-specific knowledge to grok and the existing stable reviewers typically insist on reviews from core reviewers before approving changes. By making this change, we can avoid this little dance. We have discussed this already on #openstack-nova, but if there are any concerns, please raise them now. If not, I'll seek to have the relevant changes merged to openstack/project-config by the end of next week. I'll post these changes shortly. Cheers, Stephen [1] https://meetings.opendev.org/irclogs/%23openstack-nova/%23openstack-nova.202...
On Fri, 2021-06-25 at 11:40 +0100, Stephen Finucane wrote:
Happy Friday,
Per $subject, I'd like to propose that we add os-vif-core to the list of teams with +2 rights on os-vif stable branches. Currently this list is restricted to "Project Bootstrappers", nova-stable-maint and stable-maint-core. os-vif doesn't see many backports, but it is a rather specialist library that requires some domain-specific knowledge to grok and the existing stable reviewers typically insist on reviews from core reviewers before approving changes. By making this change, we can avoid this little dance.
We have discussed this already on #openstack-nova, but if there are any concerns, please raise them now. If not, I'll seek to have the relevant changes merged to openstack/project-config by the end of next week. I'll post these changes shortly.
Change proposed at [1]. I have -W'd it pending any feedback. Stephen [1] https://review.opendev.org/c/openstack/project-config/+/798071
Cheers, Stephen
[1] https://meetings.opendev.org/irclogs/%23openstack-nova/%23openstack-nova.202...
On Fri, Jun 25, 2021 at 11:42, Stephen Finucane <stephenfin@redhat.com> wrote:
On Fri, 2021-06-25 at 11:40 +0100, Stephen Finucane wrote:
Happy Friday,
Per $subject, I'd like to propose that we add os-vif-core to the list of teams with +2 rights on os-vif stable branches. Currently this list is restricted to "Project Bootstrappers", nova-stable-maint and stable-maint-core. os-vif doesn't see many backports, but it is a rather specialist library that requires some domain-specific knowledge to grok and the existing stable reviewers typically insist on reviews from core reviewers before approving changes. By making this change, we can avoid this little dance.
I'm OK with this change. Just a note that os-vif-core contains nova-core so by this change all nova cores get stable rights in os-vif. Cheers, gibi
We have discussed this already on #openstack-nova, but if there are any concerns, please raise them now. If not, I'll seek to have the relevant changes merged to openstack/project-config by the end of next week. I'll post these changes shortly.
Change proposed at [1]. I have -W'd it pending any feedback.
Stephen
[1] https://review.opendev.org/c/openstack/project-config/+/798071
Cheers, Stephen
[1] https://meetings.opendev.org/irclogs/%23openstack-nova/%23openstack-nova.202...
On Fri, 2021-06-25 at 14:14 +0200, Balazs Gibizer wrote:
On Fri, Jun 25, 2021 at 11:42, Stephen Finucane <stephenfin@redhat.com> wrote:
On Fri, 2021-06-25 at 11:40 +0100, Stephen Finucane wrote:
Happy Friday,
Per $subject, I'd like to propose that we add os-vif-core to the list of teams with +2 rights on os-vif stable branches. Currently this list is restricted to "Project Bootstrappers", nova-stable-maint and stable-maint-core. os-vif doesn't see many backports, but it is a rather specialist library that requires some domain-specific knowledge to grok and the existing stable reviewers typically insist on reviews from core reviewers before approving changes. By making this change, we can avoid this little dance.
I'm OK with this change.
Just a note that os-vif-core contains nova-core so by this change all nova cores get stable rights in os-vif.
i think im ok with that. the preence of the nova-core group in os-vif was alway more of a courtesy. courtesy is not really the reight word but it come with the expectation that there is no requirement ot review and if you dont feel comfortable reviewing the chagne due to a lack of context or any other reason then you shoudl fell free to not review it. i think the same applies here for stabel. just becasue you can review the stable change does not mean you have too or that you have to +2/+w if you are either unfamilar with the stable policies or otherwize dont feel equipted ot review. i think the nova core team generaly good a self moderating what they review ectra, so i dont think this is really that risky. although there is a tie into the nova-core and nova-stable-maint discussion.
Cheers, gibi
We have discussed this already on #openstack-nova, but if there are any concerns, please raise them now. If not, I'll seek to have the relevant changes merged to openstack/project-config by the end of next week. I'll post these changes shortly.
Change proposed at [1]. I have -W'd it pending any feedback.
Stephen
[1] https://review.opendev.org/c/openstack/project-config/+/798071
Cheers, Stephen
[1] https://meetings.opendev.org/irclogs/%23openstack-nova/%23openstack-nova.202...
participants (3)
-
Balazs Gibizer
-
Sean Mooney
-
Stephen Finucane