[cinder] Help with a review please
Hi, I’ve had a review going on for over 8 months now [1] and would love to get this in, it’s had +2s over the period and keeps getting nit picked, finally being knocked back due to no spec which there now is [2] This is now stalled itself after having a +2 and it is very depressing. I have had generally positive experiences contributing to openstack but this has been a real pain, is there something I can do to make this go smoother? Thanks, Sam [1] https://review.opendev.org/#/c/599866/ <https://review.opendev.org/#/c/599866/> [2] https://review.opendev.org/#/c/645056/ <https://review.opendev.org/#/c/645056/>
On 08/05, Sam Morrison wrote:
Hi,
I’ve had a review going on for over 8 months now [1] and would love to get this in, it’s had +2s over the period and keeps getting nit picked, finally being knocked back due to no spec which there now is [2] This is now stalled itself after having a +2 and it is very depressing.
I have had generally positive experiences contributing to openstack but this has been a real pain, is there something I can do to make this go smoother?
Thanks, Sam
Hi Sam, I agree, it can be very frustrating when your patch gets somehow stuck in review, and while the spec and the patch looks good to me, I cannot say that I see much point in the feature itself. If the primary reason to add this new key-value pair in the API response is for aggregation, then the caller could do that same thing with an additional call to get the service list, where it could get the AZs of the different backends and then do the aggregation. To me that would be reasonable, since the AZ is not really a usage stat. Are there any other use cases? Cheers, Gorka.
[1] https://review.opendev.org/#/c/599866/ <https://review.opendev.org/#/c/599866/> [2] https://review.opendev.org/#/c/645056/ <https://review.opendev.org/#/c/645056/>
Sam, Thank you for reaching out to the mailing list on this issue. I am sorry that the review has been stuck in something of a limbo for quite some time. This is not the developer experience we strive for as a team. Since it appears that we are having trouble reaching agreement as to whether this is a good change I would recommend bringing this topic up at our next weekly meeting so that we can all work out the details together. If you would like to discuss this issue please add it to the agenda for the next meeting [1]. Thanks! Jay [1] https://etherpad.openstack.org/p/cinder-train-meetings On 5/8/2019 2:51 AM, Sam Morrison wrote:
Hi,
I’ve had a review going on for over 8 months now [1] and would love to get this in, it’s had +2s over the period and keeps getting nit picked, finally being knocked back due to no spec which there now is [2] This is now stalled itself after having a +2 and it is very depressing.
I have had generally positive experiences contributing to openstack but this has been a real pain, is there something I can do to make this go smoother?
Thanks, Sam
[1] https://review.opendev.org/#/c/599866/ [2] https://review.opendev.org/#/c/645056/
Thanks Jay, unfortunately being in Australia means the meeting is at 2am which isn’t really practical for me to attend. I’ll respond to the reviews, I understand there is a way now to do this with the API which I guess means this won’t get in. I was just trying to make the api easier to use. Cheers, Sam
On 9 May 2019, at 1:35 am, Jay Bryant <jungleboyj@gmail.com> wrote:
Sam,
Thank you for reaching out to the mailing list on this issue. I am sorry that the review has been stuck in something of a limbo for quite some time. This is not the developer experience we strive for as a team.
Since it appears that we are having trouble reaching agreement as to whether this is a good change I would recommend bringing this topic up at our next weekly meeting so that we can all work out the details together.
If you would like to discuss this issue please add it to the agenda for the next meeting [1].
Thanks!
Jay
[1] https://etherpad.openstack.org/p/cinder-train-meetings
On 5/8/2019 2:51 AM, Sam Morrison wrote:
Hi,
I’ve had a review going on for over 8 months now [1] and would love to get this in, it’s had +2s over the period and keeps getting nit picked, finally being knocked back due to no spec which there now is [2] This is now stalled itself after having a +2 and it is very depressing.
I have had generally positive experiences contributing to openstack but this has been a real pain, is there something I can do to make this go smoother?
Thanks, Sam
[1] https://review.opendev.org/#/c/599866/ [2] https://review.opendev.org/#/c/645056/
participants (3)
-
Gorka Eguileor
-
Jay Bryant
-
Sam Morrison