[all][requirements] Pygments 2.8.0 break console blocks
Hi! After recent upper-constraints bump [1] which upgraded Pygments to version 2.8.0 we got our docs tests broken because of the console blocks [2]. So CI started failing with "Could not lex literal_block as "console". Highlighting skipped." While I can kind of understand some of the issues, with a misleading quotes (while they're fine in bash) some are totally weird. For example it starts complaining on this [3]. I'm not sure if it's intended behaviour of Pygments with 2.8.0 and pretty ok to fix the docs, but I'm not sure I understand the issue here... It feels more like Pygments issue atm. And changelog [4] is pretty excessive... [1] https://opendev.org/openstack/requirements/commit/673ce445d54f8bdf792550e2d9... [2] https://zuul.opendev.org/t/openstack/build/6eea1a7099824c90a533b57c1281d478/... [3] https://opendev.org/openstack/openstack-ansible/src/branch/master/doc/source... [4] https://pygments.org/docs/changelog/#version-2-8-0 -- Kind regards, Dmitriy
While I was writing ML, I've track down issue to PR 1672 [1]. So pretty small changes should cover that. For example, for OpenStack-Ansible this patch [2] has fixed the issue (at least for local tox). [1] https://github.com/pygments/pygments/pull/1672/files [2] https://review.opendev.org/c/openstack/openstack-ansible/+/776532 18.02.2021, 22:46, "Dmitriy Rabotyagov" <noonedeadpunk@ya.ru>:
Hi!
After recent upper-constraints bump [1] which upgraded Pygments to version 2.8.0 we got our docs tests broken because of the console blocks [2]. So CI started failing with "Could not lex literal_block as "console". Highlighting skipped."
While I can kind of understand some of the issues, with a misleading quotes (while they're fine in bash) some are totally weird. For example it starts complaining on this [3].
I'm not sure if it's intended behaviour of Pygments with 2.8.0 and pretty ok to fix the docs, but I'm not sure I understand the issue here... It feels more like Pygments issue atm. And changelog [4] is pretty excessive...
[1] https://opendev.org/openstack/requirements/commit/673ce445d54f8bdf792550e2d9... [2] https://zuul.opendev.org/t/openstack/build/6eea1a7099824c90a533b57c1281d478/... [3] https://opendev.org/openstack/openstack-ansible/src/branch/master/doc/source... [4] https://pygments.org/docs/changelog/#version-2-8-0
-- Kind regards, Dmitriy
-- Kind Regards, Dmitriy Rabotyagov
participants (1)
-
Dmitriy Rabotyagov