On Wed, May 6, 2020 at 7:17 PM Matthew Treinish <mtreinish@kortar.org> wrote:

On Wed, May 06, 2020 at 05:58:43PM +0200, Dmitry Tantsur wrote:

...

Hi folks,

Most OpenStack projects use testtools/fixtures/unittest2 for unit tests. It was immensely helpful in Python 2 times, but I wonder if we should migrate away now. I've hit at least these three bugs: https://github.com/testing-cabal/testtools/issues/235 https://github.com/testing-cabal/testtools/issues/275 https://github.com/testing-cabal/testtools/issues/144

We can invest time in fixing them, but I wonder if we should just migrate to the standard unittest (and move oslotest to it) now that we require Python >= 3.6.

Thoughts?

It's used extensively, all the fixtures usage is based on testtools, additionally all the attachments (mainly captured stdout, stderr, and logging) rely on testtools result stream which adds the concept of attachments. None of that is in stdlib unittest.

Then should we invest time to fix the testtools bugs? I understand that folks use stuff that is not in stdlib, but it's pretty annoying to not be able to use stuff that IS in stdlib. Dmitry

-Matt Treinish