[nova][octavia][masakari][designate][oslo][requirements] oslo.context>=4.0.0 seems to need updated tests
The update to see what's breaking is here https://review.opendev.org/829599
Feel free to make that patch depend on your fix to test (with rechecks)
This is a legit API change in oslo.context (Thus the major version bump). It's been a long time coming too.
I will get started on the required code changes to Designate. Maybe Octavia as well if someone else doesn't get to it before I do.
Michael
On Mon, Feb 28, 2022 at 9:04 AM Matthew Thode mthode@mthode.org wrote:
The update to see what's breaking is here https://review.opendev.org/829599
Feel free to make that patch depend on your fix to test (with rechecks)
-- Matthew Thode
On Mon, 2022-02-28 at 10:09 -0800, Michael Johnson wrote:
This is a legit API change in oslo.context (Thus the major version bump). It's been a long time coming too.
we are currently pass m3 in the rc period. i dont know if we can do a breaking change like this in yoga at this point depending on how invaise it is. we might need to hold this until after RC1 is out ideally this type of change would happen very erarly in the cycle before the ptg or m1 not at the very end on the nova side there is only one failing unit test https://6b96a36d22f450141095-9e4eb9f05513870f0e5456f29474f6b2.ssl.cf5.rackcd... but i need to also run the func tests to see if there is other impact tempest-full-py3 passed so nova iteslf is likely fine.
ill try running it locally and see if that is the only impact or not.
I will get started on the required code changes to Designate. Maybe Octavia as well if someone else doesn't get to it before I do.
Michael
On Mon, Feb 28, 2022 at 9:04 AM Matthew Thode mthode@mthode.org wrote:
The update to see what's breaking is here https://review.opendev.org/829599
Feel free to make that patch depend on your fix to test (with rechecks)
-- Matthew Thode
On Mon, 2022-02-28 at 18:37 +0000, Sean Mooney wrote:
On Mon, 2022-02-28 at 10:09 -0800, Michael Johnson wrote:
This is a legit API change in oslo.context (Thus the major version bump). It's been a long time coming too.
we are currently pass m3 in the rc period. i dont know if we can do a breaking change like this in yoga at this point depending on how invaise it is. we might need to hold this until after RC1 is out ideally this type of change would happen very erarly in the cycle before the ptg or m1 not at the very end on the nova side there is only one failing unit test https://6b96a36d22f450141095-9e4eb9f05513870f0e5456f29474f6b2.ssl.cf5.rackcd... but i need to also run the func tests to see if there is other impact tempest-full-py3 passed so nova iteslf is likely fine.
ill try running it locally and see if that is the only impact or not.
gmann beat me too it. https://review.opendev.org/c/openstack/nova/+/831244 so ya it is apprently just the one unit test so i dont think this should be an issue for nova
I will get started on the required code changes to Designate. Maybe Octavia as well if someone else doesn't get to it before I do.
Michael
On Mon, Feb 28, 2022 at 9:04 AM Matthew Thode mthode@mthode.org wrote:
The update to see what's breaking is here https://review.opendev.org/829599
Feel free to make that patch depend on your fix to test (with rechecks)
-- Matthew Thode
I hope the issue with Octavia was resolved by https://review.opendev.org/c/openstack/octavia/+/801860 . (Thank you Michael for merging this !)
AFAIK Mistral is still dependent on the old arguments and we need https://review.opendev.org/c/openstack/mistral/+/801853 to fix it. It'd be nice if somebody from Mistral team can merge this (and the series of clean up patches)
On Tue, Mar 1, 2022 at 3:47 AM Sean Mooney smooney@redhat.com wrote:
On Mon, 2022-02-28 at 18:37 +0000, Sean Mooney wrote:
On Mon, 2022-02-28 at 10:09 -0800, Michael Johnson wrote:
This is a legit API change in oslo.context (Thus the major version bump). It's been a long time coming too.
we are currently pass m3 in the rc period. i dont know if we can do a breaking change like this in yoga at this
point depending on how invaise it is.
we might need to hold this until after RC1 is out ideally this type of
change would happen very erarly in the cycle before the ptg or m1
not at the very end on the nova side there is only one failing unit test
https://6b96a36d22f450141095-9e4eb9f05513870f0e5456f29474f6b2.ssl.cf5.rackcd...
but i need to also run the func tests to see if there is other impact tempest-full-py3 passed so nova iteslf is likely fine.
ill try running it locally and see if that is the only impact or not.
gmann beat me too it. https://review.opendev.org/c/openstack/nova/+/831244 so ya it is apprently just the one unit test so i dont think this should be an issue for nova
I will get started on the required code changes to Designate. Maybe Octavia as well if someone else doesn't get to it before I do.
Michael
On Mon, Feb 28, 2022 at 9:04 AM Matthew Thode mthode@mthode.org
wrote:
The update to see what's breaking is here https://review.opendev.org/829599
Feel free to make that patch depend on your fix to test (with
rechecks)
-- Matthew Thode
Yep, thanks Takashi.
Patches for both Octavia and Designate have now merged. I fired off a recheck to confirm.
Michael
On Mon, Feb 28, 2022 at 3:28 PM Takashi Kajinami tkajinam@redhat.com wrote:
I hope the issue with Octavia was resolved by https://review.opendev.org/c/openstack/octavia/+/801860 . (Thank you Michael for merging this !)
AFAIK Mistral is still dependent on the old arguments and we need https://review.opendev.org/c/openstack/mistral/+/801853 to fix it. It'd be nice if somebody from Mistral team can merge this (and the series of clean up patches)
On Tue, Mar 1, 2022 at 3:47 AM Sean Mooney smooney@redhat.com wrote:
On Mon, 2022-02-28 at 18:37 +0000, Sean Mooney wrote:
On Mon, 2022-02-28 at 10:09 -0800, Michael Johnson wrote:
This is a legit API change in oslo.context (Thus the major version bump). It's been a long time coming too.
we are currently pass m3 in the rc period. i dont know if we can do a breaking change like this in yoga at this point depending on how invaise it is. we might need to hold this until after RC1 is out ideally this type of change would happen very erarly in the cycle before the ptg or m1 not at the very end on the nova side there is only one failing unit test https://6b96a36d22f450141095-9e4eb9f05513870f0e5456f29474f6b2.ssl.cf5.rackcd... but i need to also run the func tests to see if there is other impact tempest-full-py3 passed so nova iteslf is likely fine.
ill try running it locally and see if that is the only impact or not.
gmann beat me too it. https://review.opendev.org/c/openstack/nova/+/831244 so ya it is apprently just the one unit test so i dont think this should be an issue for nova
I will get started on the required code changes to Designate. Maybe Octavia as well if someone else doesn't get to it before I do.
Michael
On Mon, Feb 28, 2022 at 9:04 AM Matthew Thode mthode@mthode.org wrote:
The update to see what's breaking is here https://review.opendev.org/829599
Feel free to make that patch depend on your fix to test (with rechecks)
-- Matthew Thode
On 22-02-28 10:56:09, Matthew Thode wrote:
The update to see what's breaking is here https://review.opendev.org/829599
Feel free to make that patch depend on your fix to test (with rechecks)
Looks like it's just masakari now, not too many commits though :|
participants (4)
-
Matthew Thode
-
Michael Johnson
-
Sean Mooney
-
Takashi Kajinami