[nova][gate] openstack-tox-pep8 job failing
Hey all, The openstack-tox-pep8 job is now failing too since hacking 3.1.0 was released [1], which brings in a newer flake8 version, which adds new checks to the code and we have a few failures. We have a change that would pin hacking >= 3.0.1 and < 3.1.0 [2] to prevent new checks from rolling in automatically, but it is stuck behind the failing openstack-tox-docs job [3]. This is unfortunately a chicken and egg situation. The proposed nova patch for the docs job, as mentioned from my other ML post: https://review.opendev.org/727898 fails the pep8 job and the proposed nova patch for the pep8 job [2] fails the docs job. I'm not sure how people will want to proceed here because a nova-side-only gate fix would involve squashing ^ and [2]. If we can get another fix or revert to openstackdocstheme to take care of the docs job, we'd then only need [2] on the nova side to unblock the nova gate. Cheers, -melanie [1] https://review.opendev.org/728016 [2] https://review.opendev.org/727347 [3] http://lists.openstack.org/pipermail/openstack-discuss/2020-May/014876.html
On 5/14/20 17:21, melanie witt wrote:
If we can get another fix or revert to openstackdocstheme to take care of the docs job, we'd then only need [2] on the nova side to unblock the nova gate.
A roll back to openstackdocstheme 2.0.2 in upper-constraints has been proposed to unblock the nova and cinder gates in the meantime: https://review.opendev.org/728335 -melanie
[1] https://review.opendev.org/728016 [2] https://review.opendev.org/727347 [3] http://lists.openstack.org/pipermail/openstack-discuss/2020-May/014876.html
On 5/14/20 20:40, melanie witt wrote:
On 5/14/20 17:21, melanie witt wrote:
If we can get another fix or revert to openstackdocstheme to take care of the docs job, we'd then only need [2] on the nova side to unblock the nova gate.
A roll back to openstackdocstheme 2.0.2 in upper-constraints has been proposed to unblock the nova and cinder gates in the meantime:
Once ^ merges, our docs job will start passing. Then someone will need to recheck: https://review.opendev.org/727347 to fix our pep8 job. -melanie
[1] https://review.opendev.org/728016 [2] https://review.opendev.org/727347 [3] http://lists.openstack.org/pipermail/openstack-discuss/2020-May/014876.html
https://review.opendev.org/#/c/727589/ bumped hacking min version to 3.1.0.
主题: [lists.openstack.org代发]Re: [nova][gate] openstack-tox-pep8 job failing
On 5/14/20 20:40, melanie witt wrote:
On 5/14/20 17:21, melanie witt wrote:
If we can get another fix or revert to openstackdocstheme to take care of the docs job, we'd then only need [2] on the nova side to unblock the nova gate.
A roll back to openstackdocstheme 2.0.2 in upper-constraints has been proposed to unblock the nova and cinder gates in the meantime:
Once ^ merges, our docs job will start passing.
Then someone will need to recheck:
https://review.opendev.org/727347
to fix our pep8 job.
-melanie
[1] https://review.opendev.org/728016 [2] https://review.opendev.org/727347 [3] http://lists.openstack.org/pipermail/openstack-discuss/2020-May/01487 6.html
On 5/14/20 20:45, melanie witt wrote:
On 5/14/20 20:40, melanie witt wrote:
On 5/14/20 17:21, melanie witt wrote:
If we can get another fix or revert to openstackdocstheme to take care of the docs job, we'd then only need [2] on the nova side to unblock the nova gate.
A roll back to openstackdocstheme 2.0.2 in upper-constraints has been proposed to unblock the nova and cinder gates in the meantime:
Once ^ merges, our docs job will start passing.
Then someone will need to recheck:
https://review.opendev.org/727347
to fix our pep8 job.
Both of these changes have since merged and the nova gate should be unblocked now. -melanie
[1] https://review.opendev.org/728016 [2] https://review.opendev.org/727347 [3] http://lists.openstack.org/pipermail/openstack-discuss/2020-May/014876.html
On Fri, May 15, 2020 at 08:26, melanie witt <melwittt@gmail.com> wrote:
On 5/14/20 20:45, melanie witt wrote:
On 5/14/20 20:40, melanie witt wrote:
On 5/14/20 17:21, melanie witt wrote:
If we can get another fix or revert to openstackdocstheme to take care of the docs job, we'd then only need [2] on the nova side to unblock the nova gate.
A roll back to openstackdocstheme 2.0.2 in upper-constraints has been proposed to unblock the nova and cinder gates in the meantime:
Once ^ merges, our docs job will start passing.
Then someone will need to recheck:
https://review.opendev.org/727347
to fix our pep8 job.
Both of these changes have since merged and the nova gate should be unblocked now.
We also needed to merge the backport of the flake8 / hacking fix [1] to the stable/ussuri as that branch was also affected. [1] https://review.opendev.org/#/c/728803/
-melanie
[1] https://review.opendev.org/728016 [2] https://review.opendev.org/727347 [3] http://lists.openstack.org/pipermail/openstack-discuss/2020-May/014876.html
participants (3)
-
Balázs Gibizer
-
Brin Zhang(张百林)
-
melanie witt