[kolla][kolla-ansible] Contributing to a Gerrit change not owned by me
Hi everyone, I have a question about contributing to an existing change in Gerrit. Is it possible to propose additional commits or modifications to a change that I do not own (i.e., a change created by another contributor), so that my update will appear as a new patch set on the same change, not as a separate one? If yes, what’s the recommended workflow or best practice to do this in the Kolla Ansible project? Also, do I just need the approval or agreement of the change owner before pushing my patch set, or are there any other formal steps required? Thanks in advance for your guidance!
Hey Sarah, First of all: awesome, thank you for taking interest in helping out your fellow openstack'er by taking a change over the line. There are two answers to this, really, technical and etiquette: - From a technical perspective, you can download an existing change with `git review -d ######` (with the patch number) to download it, add changes, and roll those changes into the original commit using `git commit --amend` or by making a new commit and rebasing it into the original one. - From an etiquette perspective[0], I try to get permission from folks before editing their patches, with a few exceptions -- for instance, for a community member I'm familiar with (and know they likely wouldn't mind), if there's a small change needed to allow it to merge, I'll often make that minor change -- especially if I know there are other cores online to help immediately land it. If the original contributor is gone and/or out of communication, that's another case where I would be willing to take over a patch without asking. As far as formal requirements, under our new DCO (Signed-off-by:) requirements, anyone who additionally makes a change to a patch must add their sign-off as well, attesting that the code they added is A-OK for OpenStack use. -JayF 0: I am talking generally based on my experiences with Ironic. I suspect the norms are slightly different for each project, so maybe someone kolla-oriented will chime in :). On Sun, Oct 19, 2025 at 5:38 AM <sarah.kh09@gmail.com> wrote:
Hi everyone,
I have a question about contributing to an existing change in Gerrit.
Is it possible to propose additional commits or modifications to a change that I do not own (i.e., a change created by another contributor), so that my update will appear as a new patch set on the same change, not as a separate one?
If yes, what’s the recommended workflow or best practice to do this in the Kolla Ansible project?
Also, do I just need the approval or agreement of the change owner before pushing my patch set, or are there any other formal steps required?
Thanks in advance for your guidance!
Am 19.10.25 um 14:37 schrieb sarah.kh09@gmail.com:
Hi everyone,
I have a question about contributing to an existing change in Gerrit.
Is it possible to propose additional commits or modifications to a change that I do not own (i.e., a change created by another contributor), so that my update will appear as a new patch set on the same change, not as a separate one?
Hi there, yes, it is possible. You can check a patch out by clicking on DOWNLOAD in gerrit (opens an overlay) and submit the patch after doin your changes. Matthias
participants (3)
-
Jay Faulkner
-
Matthias Runge
-
sarah.kh09@gmail.com