[horizon] default create_volume setting can't be changed
Hi *, we recently upgraded from Ocata to Train and I'm struggling with a specific setting: I believe since Pike version the default for "create_volume" changed to "true" when launching instances from Horizon dashboard. I would like to change that to "false" and set it in our custom /srv/www/openstack-dashboard/openstack_dashboard/local/local_settings.d/_100_local_settings.py: LAUNCH_INSTANCE_DEFAULTS = { 'config_drive': False, 'create_volume': False, 'hide_create_volume': False, 'disable_image': False, 'disable_instance_snapshot': False, 'disable_volume': False, 'disable_volume_snapshot': False, 'enable_scheduler_hints': True, } Other configs from this file work as expected, so that custom file can't be the reason. After apache and memcached restart nothing changes, the default is still "true". Can anyone shed some light, please? I haven't tried other configs yet so I can't tell if more options are affected. Thanks! Eugen
Update: I found one (the right?) place to change the default to false: /srv/www/openstack-dashboard/static/dashboard/project/workflow/launch-instance/launch-instance-model.service.js // create_volume_default: true, create_volume_default: false, I've been struggling for years now with these dashboard settings, it started with /srv/www/openstack-dashboard/openstack_dashboard/dashboards/project/instances/workflows/create_instance.py where I needed to remove the default disk identifier (hard-coded "vda") when we were still running with xen hypervisors to let nova change the disk name. Then this changed and it had to be one of these files, I can't remember which was first, I just know that after some months I had to apply my changes to the other file, too: /srv/www/openstack-dashboard/static/dashboard/project/workflow/launch-instance/launch-instance-model.service.js /srv/www/openstack-dashboard/openstack_dashboard/dashboards/project/static/dashboard/project/workflow/launch-instance/source/source.controller.js I'm not a developer but I must say, I don't really understand this setup and why it changes all the time. Of course I might be looking in the wrong places, it would be great if someone could point me to the right direction! I'm also willing to provide more information if necessary.
Other configs from this file work as expected, so that custom file can't be the reason.
I might be wrong about that, too. I noticed that although I disabled the debug settings in /srv/www/openstack-dashboard/openstack_dashboard/local/local_settings.d/_100_local_settings.py DEBUG = False I was still seeing debug messages. I had to turn them off in /srv/www/openstack-dashboard/openstack_dashboard/settings.py to be applied. So there might be other changes not applied from our custom config file. I'd really appreciate it if anyone could comment on this. Thanks, Eugen Zitat von Eugen Block <eblock@nde.ag>:
Hi *,
we recently upgraded from Ocata to Train and I'm struggling with a specific setting: I believe since Pike version the default for "create_volume" changed to "true" when launching instances from Horizon dashboard. I would like to change that to "false" and set it in our custom /srv/www/openstack-dashboard/openstack_dashboard/local/local_settings.d/_100_local_settings.py:
LAUNCH_INSTANCE_DEFAULTS = { 'config_drive': False, 'create_volume': False, 'hide_create_volume': False, 'disable_image': False, 'disable_instance_snapshot': False, 'disable_volume': False, 'disable_volume_snapshot': False, 'enable_scheduler_hints': True, }
Other configs from this file work as expected, so that custom file can't be the reason. After apache and memcached restart nothing changes, the default is still "true". Can anyone shed some light, please? I haven't tried other configs yet so I can't tell if more options are affected.
Thanks! Eugen
Hi Eugen, I also noticed this and filed a bug report at https://bugs.launchpad.net/horizon/+bug/1892990. It was caused by a missing comma in REST_API_REQUIRED_SETTINGS in openstack_dashboard/defaults.py. It was fixed in the master this month. It affects stable/train and stable/ussuri branches. I proposed backports to ussuri and train respectively. Cloud you try the stable/train backport? https://review.opendev.org/#/q/I1eae4be4464f55a29d169403a70c958c3b8a308b Thanks, Akihiro Motoki (irc: amotoki) On Mon, Aug 24, 2020 at 11:21 PM Eugen Block <eblock@nde.ag> wrote:
Hi *,
we recently upgraded from Ocata to Train and I'm struggling with a specific setting: I believe since Pike version the default for "create_volume" changed to "true" when launching instances from Horizon dashboard. I would like to change that to "false" and set it in our custom /srv/www/openstack-dashboard/openstack_dashboard/local/local_settings.d/_100_local_settings.py:
LAUNCH_INSTANCE_DEFAULTS = { 'config_drive': False, 'create_volume': False, 'hide_create_volume': False, 'disable_image': False, 'disable_instance_snapshot': False, 'disable_volume': False, 'disable_volume_snapshot': False, 'enable_scheduler_hints': True, }
Other configs from this file work as expected, so that custom file can't be the reason. After apache and memcached restart nothing changes, the default is still "true". Can anyone shed some light, please? I haven't tried other configs yet so I can't tell if more options are affected.
Thanks! Eugen
Hi, thank you very much for the confirmation and the bug report. Setting the comma seems to do the trick, I reverted my own changes and only added the comma, after restarting apache the dashboard applied my settings. Thanks for the quick solution! Best regards, Eugen Zitat von Akihiro Motoki <amotoki@gmail.com>:
Hi Eugen,
I also noticed this and filed a bug report at https://bugs.launchpad.net/horizon/+bug/1892990. It was caused by a missing comma in REST_API_REQUIRED_SETTINGS in openstack_dashboard/defaults.py. It was fixed in the master this month. It affects stable/train and stable/ussuri branches.
I proposed backports to ussuri and train respectively. Cloud you try the stable/train backport? https://review.opendev.org/#/q/I1eae4be4464f55a29d169403a70c958c3b8a308b
Thanks, Akihiro Motoki (irc: amotoki)
On Mon, Aug 24, 2020 at 11:21 PM Eugen Block <eblock@nde.ag> wrote:
Hi *,
we recently upgraded from Ocata to Train and I'm struggling with a specific setting: I believe since Pike version the default for "create_volume" changed to "true" when launching instances from Horizon dashboard. I would like to change that to "false" and set it in our custom /srv/www/openstack-dashboard/openstack_dashboard/local/local_settings.d/_100_local_settings.py:
LAUNCH_INSTANCE_DEFAULTS = { 'config_drive': False, 'create_volume': False, 'hide_create_volume': False, 'disable_image': False, 'disable_instance_snapshot': False, 'disable_volume': False, 'disable_volume_snapshot': False, 'enable_scheduler_hints': True, }
Other configs from this file work as expected, so that custom file can't be the reason. After apache and memcached restart nothing changes, the default is still "true". Can anyone shed some light, please? I haven't tried other configs yet so I can't tell if more options are affected.
Thanks! Eugen
participants (2)
-
Akihiro Motoki
-
Eugen Block