[oslo][messaging] Container fix of QManager breaks it for containers
Hey folks, I wanted to raise attention to a relatively old issue, which has had a patch around since January [1]. Basically a regression [2] was introduced and backported to 2024.1 as part of an attempt to fix QManager execution in containers. However, it does not account for the possibility of os.getpgrp() returning 0 in some edge cases, which makes, for instance, impossible to sync database for Nova during upgrades, if QManager is used. Thus I'm asking to kindly review the [1] as it appears to be a blocker for some upgrades involving affected versions of oslo.messaging. I have not spotted this patch right away, so I proposed an alternative [3], but I'm happy to abandon it in favor of [1]. Thanks in advance for upcoming reviews :) [1] https://review.opendev.org/c/openstack/oslo.messaging/+/939540 [2] https://review.opendev.org/c/openstack/oslo.messaging/+/928034 [3] https://review.opendev.org/c/openstack/oslo.messaging/+/958528
Done. I followed path [1] as it already involved many people including me. Le jeu. 28 août 2025 à 20:42, Dmitriy Rabotyagov <noonedeadpunk@gmail.com> a écrit :
Hey folks,
I wanted to raise attention to a relatively old issue, which has had a patch around since January [1]. Basically a regression [2] was introduced and backported to 2024.1 as part of an attempt to fix QManager execution in containers. However, it does not account for the possibility of os.getpgrp() returning 0 in some edge cases, which makes, for instance, impossible to sync database for Nova during upgrades, if QManager is used.
Thus I'm asking to kindly review the [1] as it appears to be a blocker for some upgrades involving affected versions of oslo.messaging. I have not spotted this patch right away, so I proposed an alternative [3], but I'm happy to abandon it in favor of [1].
Thanks in advance for upcoming reviews :)
[1] https://review.opendev.org/c/openstack/oslo.messaging/+/939540 [2] https://review.opendev.org/c/openstack/oslo.messaging/+/928034 [3] https://review.opendev.org/c/openstack/oslo.messaging/+/958528
-- Hervé Beraud Principal Software Engineer at Red Hat irc: hberaud https://github.com/4383/
Hey folks! Can I kindly ask to look into backports now? Ie, the one for 2025.1 [1]. As it would be nice to land the fix along with a new bugfix release for oslo.messaging [1] https://review.opendev.org/c/openstack/oslo.messaging/+/958848 пт, 29 авг. 2025 г. в 10:02, Herve Beraud <hberaud@redhat.com>:
Done. I followed path [1] as it already involved many people including me.
Le jeu. 28 août 2025 à 20:42, Dmitriy Rabotyagov <noonedeadpunk@gmail.com> a écrit :
Hey folks,
I wanted to raise attention to a relatively old issue, which has had a patch around since January [1]. Basically a regression [2] was introduced and backported to 2024.1 as part of an attempt to fix QManager execution in containers. However, it does not account for the possibility of os.getpgrp() returning 0 in some edge cases, which makes, for instance, impossible to sync database for Nova during upgrades, if QManager is used.
Thus I'm asking to kindly review the [1] as it appears to be a blocker for some upgrades involving affected versions of oslo.messaging. I have not spotted this patch right away, so I proposed an alternative [3], but I'm happy to abandon it in favor of [1].
Thanks in advance for upcoming reviews :)
[1] https://review.opendev.org/c/openstack/oslo.messaging/+/939540 [2] https://review.opendev.org/c/openstack/oslo.messaging/+/928034 [3] https://review.opendev.org/c/openstack/oslo.messaging/+/958528
-- Hervé Beraud Principal Software Engineer at Red Hat irc: hberaud https://github.com/4383/
Hey, Thanks for processing all the backports proposed to the patch! There is one left though, for 2024.2: https://review.opendev.org/c/openstack/oslo.messaging/+/958849 It is waiting for +W label right now. And backport to 2024.1 was merged already as well, so 2024.2 would be having some regression in behavior now. вт, 16 сент. 2025 г. в 11:25, Dmitriy Rabotyagov <noonedeadpunk@gmail.com>:
Hey folks!
Can I kindly ask to look into backports now? Ie, the one for 2025.1 [1]. As it would be nice to land the fix along with a new bugfix release for oslo.messaging
[1] https://review.opendev.org/c/openstack/oslo.messaging/+/958848
пт, 29 авг. 2025 г. в 10:02, Herve Beraud <hberaud@redhat.com>:
Done. I followed path [1] as it already involved many people including me.
Le jeu. 28 août 2025 à 20:42, Dmitriy Rabotyagov <noonedeadpunk@gmail.com> a écrit :
Hey folks,
I wanted to raise attention to a relatively old issue, which has had a patch around since January [1]. Basically a regression [2] was introduced and backported to 2024.1 as part of an attempt to fix QManager execution in containers. However, it does not account for the possibility of os.getpgrp() returning 0 in some edge cases, which makes, for instance, impossible to sync database for Nova during upgrades, if QManager is used.
Thus I'm asking to kindly review the [1] as it appears to be a blocker for some upgrades involving affected versions of oslo.messaging. I have not spotted this patch right away, so I proposed an alternative [3], but I'm happy to abandon it in favor of [1].
Thanks in advance for upcoming reviews :)
[1] https://review.opendev.org/c/openstack/oslo.messaging/+/939540 [2] https://review.opendev.org/c/openstack/oslo.messaging/+/928034 [3] https://review.opendev.org/c/openstack/oslo.messaging/+/958528
-- Hervé Beraud Principal Software Engineer at Red Hat irc: hberaud https://github.com/4383/
participants (2)
-
Dmitriy Rabotyagov
-
Herve Beraud