[Cinder] Review pretty please
Hi Cinder cores, I've had a simple review [1] waiting for several months, could I please get some feedback on this. Thanks! Sam [1] https://review.opendev.org/c/openstack/cinder/+/764875
I'm not a Cinder dev, but I could not help looking at this suggested change. To me at least, it's an insta-merge, but I think it might get overlooked because the Commit Message doesn't detail "What you would now see" versus "What you should see", and the cognitive load on reviewers is high enough that it gets ignored. +1 from someone who has no right to say so. -- MC On Fri, Mar 19, 2021 at 3:43 PM Sam Morrison <sorrison@gmail.com> wrote:
Hi Cinder cores,
I've had a simple review [1] waiting for several months, could I please get some feedback on this.
Thanks! Sam
On 3/19/21 12:42 AM, Sam Morrison wrote:
Hi Cinder cores,
I've had a simple review [1] waiting for several months, could I please get some feedback on this.
Unfortunately, we're in the string freeze now so we can't approve the change until after RC-1 when the stable branch is cut. Also, left a suggestion for a revision on the review. Hopefully our monthly "Festival of XS Reviews" will prevent this situation from happening again. We don't want to discourage small changes like yours that actually have high impact because they're user facing.
Thanks! Sam
[1] https://review.opendev.org/c/openstack/cinder/+/764875 <https://review.opendev.org/c/openstack/cinder/+/764875>
participants (3)
-
Brian Rosmaita
-
Mike Carden
-
Sam Morrison