Do we have a definitive list of native pdf package dependencies for bindep?
I've been on a least a few pdf goal related reviews and "why can't I build docs anymore" IRC conversations now to ask if there is a definitive list anywhere of the native packages needed to build the pdf-docs tox target so we can put those in bindep.txt for each project.
os-brick looks like it has a pretty expansive set of packages defined [1]. Should each project be copying that? Where would a definitive list even live? Is that something that should go into the requirements repo's bindep file [2] or is that specific just to what binary packages are needed to run tests against the requirements repo? Maybe the list should live in the storyboard dashboard [3] for the goal?
[1] https://github.com/openstack/os-brick/commit/132a531e1768dea2db3275da376f163... [2] https://github.com/openstack/requirements/blob/master/bindep.txt [3] https://storyboard.openstack.org/#!/board/175
On 9/24/2019 10:28 AM, Matt Riedemann wrote:
os-brick looks like it has a pretty expansive set of packages defined [1]. Should each project be copying that? Where would a definitive list even live? Is that something that should go into the requirements repo's bindep file [2] or is that specific just to what binary packages are needed to run tests against the requirements repo? Maybe the list should live in the storyboard dashboard [3] for the goal?
[1] https://github.com/openstack/os-brick/commit/132a531e1768dea2db3275da376f163...
[2] https://github.com/openstack/requirements/blob/master/bindep.txt [3] https://storyboard.openstack.org/#!/board/175
Should we just use this?
https://opendev.org/openstack/openstack-zuul-jobs/src/branch/master/roles/pr...
But that's only for ubuntu bionic nodes, right? It's at least a start but people trying to build pdf-docs tox targets on CentOS, Fedora, etc likely still won't work.
On 24/09/2019 17.33, Matt Riedemann wrote:
On 9/24/2019 10:28 AM, Matt Riedemann wrote:
os-brick looks like it has a pretty expansive set of packages defined [1]. Should each project be copying that? Where would a definitive list even live? Is that something that should go into the requirements repo's bindep file [2] or is that specific just to what binary packages are needed to run tests against the requirements repo? Maybe the list should live in the storyboard dashboard [3] for the goal?
[1] https://github.com/openstack/os-brick/commit/132a531e1768dea2db3275da376f163...
[2] https://github.com/openstack/requirements/blob/master/bindep.txt [3] https://storyboard.openstack.org/#!/board/175
Should we just use this?
https://opendev.org/openstack/openstack-zuul-jobs/src/branch/master/roles/pr...
Yes.
But that's only for ubuntu bionic nodes, right? It's at least a start but people trying to build pdf-docs tox targets on CentOS, Fedora, etc likely still won't work.
https://opendev.org/openstack/openstack-manuals/src/branch/master/bindep.txt has a list for more distros if somebody wants to patch the list to handle more distros, I'll happily take them,
Andreas
On 24/09/2019 17.28, Matt Riedemann wrote:
I've been on a least a few pdf goal related reviews and "why can't I build docs anymore" IRC conversations now to ask if there is a definitive list anywhere of the native packages needed to build the pdf-docs tox target so we can put those in bindep.txt for each project.
You can still build docs without changes, tox -e docs was not changed.
The list of packages that the job installs is here: https://opendev.org/openstack/openstack-zuul-jobs/src/branch/master/roles/pr...
So, adding files to bindep.txt is optional.
os-brick looks like it has a pretty expansive set of packages defined [1]. Should each project be copying that? Where would a definitive list
The list in the prepare-build-pdf-docs role is the common subset. I'm surprised that os-brick needs more packages.
even live? Is that something that should go into the requirements repo's bindep file [2] or is that specific just to what binary packages are needed to run tests against the requirements repo? Maybe the list should live in the storyboard dashboard [3] for the goal?
If you need to add something, it needs to go in the repo, not in the requirments repo.
Andreas
[1] https://github.com/openstack/os-brick/commit/132a531e1768dea2db3275da376f163...
[2] https://github.com/openstack/requirements/blob/master/bindep.txt [3] https://storyboard.openstack.org/#!/board/175
On 9/24/2019 10:49 AM, Andreas Jaeger wrote:
You can still build docs without changes, tox -e docs was not changed.
The list of packages that the job installs is here: https://opendev.org/openstack/openstack-zuul-jobs/src/branch/master/roles/pr...
So, adding files to bindep.txt is optional.
I was thinking of this specifically:
https://review.opendev.org/#/c/683003/
Building docs in the gate is fine, it's handled by the docs job template, but building docs locally was failing because I didn't have that native package installed, and when I'm working on big docs changes I'm building them locally to make sure (1) the docs build works and (2) my formatting looks OK.
On Tuesday, 24 September 2019 21:58:09 CEST Matt Riedemann wrote:
On 9/24/2019 10:49 AM, Andreas Jaeger wrote:
You can still build docs without changes, tox -e docs was not changed.
The list of packages that the job installs is here: https://opendev.org/openstack/openstack-zuul-jobs/src/branch/master/roles/ prepare-build-pdf-docs/tasks/main.yaml#L10-L16
So, adding files to bindep.txt is optional.
I was thinking of this specifically:
https://review.opendev.org/#/c/683003/
Building docs in the gate is fine, it's handled by the docs job template, but building docs locally was failing because I didn't have that native package installed, and when I'm working on big docs changes I'm building them locally to make sure (1) the docs build works and (2) my formatting looks OK.
I was wondering: could we find a way to not duplicate this information over and over in all repositories? It's a long list of packages which needs to be kept in sync all around.
Ciao
On Wed, 2019-09-25 at 09:06 +0200, Luigi Toscano wrote:
On Tuesday, 24 September 2019 21:58:09 CEST Matt Riedemann wrote:
On 9/24/2019 10:49 AM, Andreas Jaeger wrote:
You can still build docs without changes, tox -e docs was not changed.
The list of packages that the job installs is here: https://opendev.org/openstack/openstack-zuul-jobs/src/branch/master/roles/ prepare-build-pdf-docs/tasks/main.yaml#L10-L16
So, adding files to bindep.txt is optional.
I was thinking of this specifically:
https://review.opendev.org/#/c/683003/
Building docs in the gate is fine, it's handled by the docs job template, but building docs locally was failing because I didn't have that native package installed, and when I'm working on big docs changes I'm building them locally to make sure (1) the docs build works and (2) my formatting looks OK.
I was wondering: could we find a way to not duplicate this information over and over in all repositories? It's a long list of packages which needs to be kept in sync all around.
Does bindep support referencing remote bindep.txt files? That would be an easy out. "Docs not working? Use 'tox -e bindep https://...'".
Stephen
participants (4)
-
Andreas Jaeger
-
Luigi Toscano
-
Matt Riedemann
-
Stephen Finucane